GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Improve SSL performance by calling SSLProtocol methods directly, not through the python's vectorcall interface by tarasko · Pull Request #626 · MagicStack/uvloop

Conversation

tarasko commented Sep 7, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

After profiling my app with perf I identified a couple of things that make SSLProtocol a little bit faster:

SSLProtocol.get_buffer and buffer_updated can be called directly from UVStream since it is our own type and we know it's definition
Added inline directive to all private methods of SSLProtocol to avoid vtable calls

Before:

--42.75%--__pyx_f_6uvloop_4loop___uv_stream_buffered_on_read
       |          
        --42.19%--__pyx_f_6uvloop_4loop_run_in_context1
                  |          
                   --41.92%--cfunction_vectorcall_FASTCALL_KEYWORDS
                             context_run
                             |          
                              --41.83%--_PyObject_VectorcallTstate.lto_priv.18
                                        |          
                                         --41.73%--method_vectorcall
                                                   |          
                                                    --41.32%--__pyx_pw_6uvloop_4loop_11SSLProtocol_15buffer_updated


--2.51%--__pyx_f_6uvloop_4loop___uv_stream_buffered_alloc
       |          
        --1.40%--__pyx_f_6uvloop_4loop_run_in_context1
                  |          
                   --0.67%--cfunction_vectorcall_FASTCALL_KEYWORDS
                             context_run

After:

--43.18%--__pyx_f_6uvloop_4loop___uv_stream_buffered_on_read
       |          
        --42.57%--__pyx_f_6uvloop_4loop_11SSLProtocol_buffer_updated_impl


--0.79%--__pyx_f_6uvloop_4loop___uv_stream_buffered_alloc
       |          
        --0.60%--PyGILState_Ensure

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

taras added 6 commits

September 7, 2024 03:05


          Optimize ssl performance by invoke SSLProtocol.get_buffer directly

13dd2a4


          Add inline directive to SSLProtocol private methods

d028020


          Fix tests

6a1a164


          Fix tests

fc432d2


          Undo some changes

ab16cc3


          Call UVStream.write directly from SSLProtocol

afe7e60

tarasko force-pushed the ssl_optimizations branch from 04ec4d5 to afe7e60 Compare

September 9, 2024 23:25

tarasko changed the title ~~Optimizations for SSLProtocol~~ Optimize SSL performance by calling SSLProtocol methods directly, not through the python's vectorcall interface

Oct 15, 2024

tarasko changed the title ~~Optimize SSL performance by calling SSLProtocol methods directly, not through the python's vectorcall interface~~ Improve SSL performance by calling SSLProtocol methods directly, not through the python's vectorcall interface

Oct 15, 2024


          Merge branch 'master' into ssl_optimizations

11ad720

tarasko mentioned this pull request

Jan 14, 2026

Improve performance and reduce latency of Transport.write by attempting to send data immediately if all write buffers are empty #619

Merged


          Merge branch 'master' into ssl_optimizations

ae09ab8

fantix approved these changes

Jan 26, 2026

View reviewed changes

fantix left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

uvloop/handles/stream.pyx Resolved

Uh oh!

There was an error while loading. Please reload this page.

taras added 2 commits

January 27, 2026 19:33


          Implemented PR review comments

94f8283


          Add extra comments

d149143

fantix merged commit 6a27cbe into MagicStack:master

Jan 30, 2026

32 of 34 checks passed

Uh oh!

There was an error while loading. Please reload this page.

tarasko deleted the ssl_optimizations branch

January 31, 2026 21:45

fantix mentioned this pull request

Sep 30, 2026

uvloop 0.23.0 #768

Merged

jensbjorgensen pushed a commit to jensbjorgensen/uvloop that referenced this pull request

Oct 6, 2026


          uvloop 0.23.0

c5f7deb

Changes
=======

* Add Python 3.15 and 3.15t wheel builds and CI coverage (MagicStack#758)
  (by @honglei @fantix in f7c0547)

* Add support for the `eager_start` keyword argument in create_task() (MagicStack#748)
  (by @samypr100 in 3cbb095 for MagicStack#746 MagicStack#718)

* Add thread name prefix to the default thread pool executor (MagicStack#636)
  (by @inikolaev @fantix in 0582f94 for MagicStack#562)

* Add support for special hostname `<broadcast>` (MagicStack#592)
  (by @jpbede in 3060ceb for MagicStack#540)

* Upgrade libuv to v1.52.1 (MagicStack#753)
  (by @fantix in e8efea4 for MagicStack#752)

* Improve performance by using Python C API to enter/exit context (MagicStack#627)
  (by @tarasko in 837ef22)

* Improve performance/latency of Transport.write (MagicStack#619)
  (by @tarasko in 1d9b6e0)

* Replace some SSL vectorcall with direct methods (MagicStack#626)
  (by @tarasko in 6a27cbe)

* Optimize SSL buffered reads using C values (MagicStack#629)
  (by @tarasko in a308f75)

Fixes
=====

* Detach socket on create_connection cancellation to prevent fd double-close (MagicStack#740)
  (by @junjzhang @fantix in dc680eb for MagicStack#645 MagicStack#738)

* Remove `loop._ready_len` in favor of `len(loop._ready)` (MagicStack#721)
  (by @x42005e1f in 5910a18 for MagicStack#720)

* Prefer inspect.iscoroutinefunction (MagicStack#705)
  (by @MatthieuDartiailh in fd65027 for MagicStack#703)

* Fix context tests by explicitly yielding after run_in_executor (MagicStack#743)
  (by @samypr100 in 6cd24cb)

* Fix test_create_connection_open_con_addr with Python 3.13.9+ (MagicStack#713)
  (by @shadchin in b93141a for MagicStack#701)

* Skip flaky test_cancel_post_init on asyncio 3.13+ (MagicStack#714)
  (by @fantix in 3ea5c85 for MagicStack#709)

* Fix flaky test_fs_event (MagicStack#717)
  (by @fantix in 8da4547)

* Use C __atomic builtins for debug counters (MagicStack#719)
  (by @fantix in 836e3b2)

* Update the example to work with Python 3.14 (MagicStack#710)
  (by @Jamie-Chang in b74c2f1)

Build
=====

* Replace pkg_resources with packaging and use Cython 3.1 (MagicStack#742)
  (by @samypr100 in b377b7c for MagicStack#729)

* Remove wheel as a build dependency (MagicStack#696)
  (by @DimitriPapadopoulos in 173e88c)

* Support any number of flags in UVLOOP_OPT_CFLAGS (MagicStack#630)
  (by @mgorny in 963a5f3)

Reviewers

fantix

fantix approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tarasko commented Sep 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fantix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tarasko commented Sep 7, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.