GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make universal Deb package based on deb package spec by TravisEz13 · Pull Request #14681 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Jan 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Try to make universal Deb package based on deb package spec

PR Context

Maybe?
fixes #13759

https://www.debian.org/doc/debian-policy/ch-relationships.html

the package names listed may also include lists of alternative package names, separated by vertical bar (pipe) symbols |

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
test changes based on deb spec
8120e27
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 29, 2021 19:47
@ghost ghost assigned Andrew (anmenaga) Jan 29, 2021
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 29, 2021

Copy link
Copy Markdown
Member Author

verified on buster and 20.04.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) changed the title Try to make universal Deb package based on deb package spec Make universal Deb package based on deb package spec Jan 29, 2021
@TravisEz13 Travis Plunk (TravisEz13) added BackPort-7.0.x-Consider labels Jan 29, 2021
TravisEz13
Travis Plunk (TravisEz13) commented Jan 29, 2021
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Update tools/packaging/packaging.psm1
a8f82e5
@anmenaga

Andrew (anmenaga) commented Jan 29, 2021

Copy link
Copy Markdown

Restarted CI for failed 'RemoteSession.Disconnect.Tests.ps1'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JamesWTruher
James Truher (JamesWTruher) reviewed Jan 29, 2021
View reviewed changes
Comment thread tools/packaging/packaging.psm1
"zlib1g"
"zlib1g",
"libicu72|libicu71|libicu70|libicu69|libicu68|libicu67|libicu66|libicu65|libicu63|libicu60|libicu57|libicu55|libicu52",
"libssl1.1|libssl1.0.2|libssl1.0.0"

@JamesWTruher James Truher (JamesWTruher) Jan 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this change it looks like we are eliminating the unsupported error when faced with a platform we don't understand. Does that mean we are relying on an error generated when the dependency is not found rather than a specific version?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Jan 29, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, basically, but that was only a build time error. Since the attempt here is to build a universal, package, keeping the error didn't make since.

If we hit a platform that has a missing dependency, then we should add it to the list if supported or not if the platform is not.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JamesWTruher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
JamesWTruher
James Truher (JamesWTruher) approved these changes Jan 29, 2021
View reviewed changes
anmenaga
Andrew (anmenaga) approved these changes Feb 2, 2021
View reviewed changes

@anmenaga Andrew (anmenaga) left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as maintainer based on Jim's review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anmenaga
Andrew (anmenaga) merged commit 00b4b83 into PowerShell:master Feb 2, 2021
@TravisEz13
Travis Plunk (TravisEz13) deleted the fix-deb-11 branch February 2, 2021 22:47
@iSazonov Ilya (iSazonov) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 6, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Feb 6, 2021
@ghost

Deleted user (ghost) commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost mentioned this pull request Feb 12, 2021
Debian 11 package has unsatisfied dependencies #13759
Closed
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added BackPort-7.0.x-Approved Backport-7.1.x-Done Backport to 7.1.x completed and removed BackPort-7.0.x-Consider labels Mar 2, 2021
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.0.x-Done and removed BackPort-7.0.x-Approved labels Mar 10, 2021
Dongbo Wang (daxian-dbw) pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 11, 2021
@TravisEz13 @adityapatwardhan
Make universal Deb package based on deb package spec (PowerShell#14681)
99655d1
@ghost

Deleted user (ghost) commented Mar 11, 2021

Copy link
Copy Markdown

🎉v7.0.6 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

Deleted user (ghost) commented Mar 11, 2021

Copy link
Copy Markdown

🎉v7.1.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thomas May (WamWooWam) pushed a commit to WamWooWam/PowerShell that referenced this pull request Mar 16, 2021
@TravisEz13 @adityapatwardhan
Make universal Deb package based on deb package spec (PowerShell#14681)
90e3753
Thomas May (WamWooWam) added a commit to WamWooWam/PowerShell that referenced this pull request Mar 16, 2021
@WamWooWam
Merge tag 'v7.1.3' into powercord
3cc3e1d 
[7.1.3] - 2021-03-11

*** Engine Updates and Fixes

- Remove the 32K character limit on the environment block for `Start-Process` (PowerShell#14111)
- Fix webcmdlets to properly construct URI from body when using `-NoProxy` (PowerShell#14673)

*** General Cmdlet Updates and Fixes

- Fix `PromptForCredential()` to add `targetName` as domain (PowerShell#14504)

*** Build and Packaging Improvements

<details>

<summary>

Bump .NET SDK to 5.0.4

</summary>

<ul>
<li>Bump .NET SDK to 5.0.4 (Internal 14775)</li>
<li>Disable running markdown link verification in release build CI (PowerShell#14971, PowerShell#14974, PowerShell#14975)</li>
<li>Use template that disables component governance for CI (PowerShell#14938)</li>
<li>Declare which variable group is used for checking the blob in the release build (PowerShell#14970)</li>
<li>Add suppress for nuget multi-feed warning (PowerShell#14893)</li>
<li>Disable code signing validation where the file type is not supported (PowerShell#14885)</li>
<li>Install wget on <code>CentOS</code> 7 docker image (PowerShell#14857)</li>
<li>Fix install-dotnet download (PowerShell#14856)</li>
<li>Make universal Deb package based on deb package spec (PowerShell#14681)</li>
<li>Fix release build to upload global tool packages to artifacts (PowerShell#14620)</li>
<li>Update <code>ini</code> component version in test <code>package.json</code> (PowerShell#14454)</li>
<li>Add manual release automation steps and improve changelog script (PowerShell#14445)</li>
<li>Update markdown test packages with security fixes (PowerShell#14145)</li>
<li>Fix a typo in the <code>Get-ChangeLog</code> function (PowerShell#14129)</li>
<li>Disable global tool copy to unblock release</li>
</ul>

</details>

[7.1.3]: PowerShell/PowerShell@v7.1.2...v7.1.3
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022
Back-port to 7.0: Update list of PowerShell team members in release tools #18266
Merged
22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Make universal Deb package based on deb package spec (PowerShell#14681)
81dbb17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
2 more reviewers
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@anmenaga Andrew (anmenaga)

Labels

Backport-7.0.x-Done Backport-7.1.x-Done Backport to 7.1.x completed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Debian 11 package has unsatisfied dependencies

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@TravisEz13 @anmenaga @JamesWTruher @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.