GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Disable codesign validation where the file type is not supported by TravisEz13 · Pull Request #14885 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Feb 22, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Disable codesign validation where the file type is not supported

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
disable codesign validation where it fails
f398b67
@ghost ghost assigned Ilya (iSazonov) Feb 22, 2021
@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review February 22, 2021 23:03
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners February 22, 2021 23:03
@TravisEz13 Travis Plunk (TravisEz13) added BackPort-7.0.x-Consider labels Feb 22, 2021
@TravisEz13
disable macOS filesigning too
ae8459c
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Feb 22, 2021
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Feb 23, 2021

Copy link
Copy Markdown
Member Author

Verified all errors are fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 23, 2021
@TravisEz13
Travis Plunk (TravisEz13) merged commit 1bad808 into PowerShell:master Feb 23, 2021
@TravisEz13
Travis Plunk (TravisEz13) deleted the disable-codesign-validation branch February 23, 2021 00:39
@TravisEz13 Travis Plunk (TravisEz13) added this to the 7.2.0-preview.4 milestone Feb 23, 2021
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added BackPort-7.0.x-Approved Backport-7.1.x-Done Backport to 7.1.x completed and removed BackPort-7.0.x-Consider labels Mar 2, 2021
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.0.x-Done and removed BackPort-7.0.x-Approved labels Mar 10, 2021
Dongbo Wang (daxian-dbw) pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 11, 2021
@TravisEz13 @adityapatwardhan
Disable codesign validation where the file type is not supported (Pow…
5c4d4ee 
…erShell#14885)

* disable codesign validation where it fails

* disable macOS filesigning too
@ghost

Deleted user (ghost) commented Mar 11, 2021

Copy link
Copy Markdown

🎉v7.0.6 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

Deleted user (ghost) commented Mar 11, 2021

Copy link
Copy Markdown

🎉v7.1.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 12, 2021
Bump Microsoft.PowerShell.SDK from 7.0.3 to 7.1.3 hsaito/PSOpenLocationCode#15
Closed
Bump Microsoft.PowerShell.SDK from 7.0.3 to 7.1.3 hsaito/PremiumFriday#18
Closed
build(deps): bump Microsoft.PowerShell.SDK from 6.0.4 to 7.1.3 Valks/DotNetCorePlugins#4
Closed
Bump System.Management.Automation from 7.1.1 to 7.1.3 iricigor/PS-azmi#47
Open
@dependabot dependabot Bot mentioned this pull request Mar 16, 2021
Bump Microsoft.PowerShell.Commands.Diagnostics from 6.2.1 to 7.1.3 Accenture/Ocaramba#190
Closed
Thomas May (WamWooWam) pushed a commit to WamWooWam/PowerShell that referenced this pull request Mar 16, 2021
@TravisEz13 @adityapatwardhan
Disable codesign validation where the file type is not supported (Pow…
3e67d45 
…erShell#14885)

* disable codesign validation where it fails

* disable macOS filesigning too
Thomas May (WamWooWam) added a commit to WamWooWam/PowerShell that referenced this pull request Mar 16, 2021
@WamWooWam
Merge tag 'v7.1.3' into powercord
3cc3e1d 
[7.1.3] - 2021-03-11

*** Engine Updates and Fixes

- Remove the 32K character limit on the environment block for `Start-Process` (PowerShell#14111)
- Fix webcmdlets to properly construct URI from body when using `-NoProxy` (PowerShell#14673)

*** General Cmdlet Updates and Fixes

- Fix `PromptForCredential()` to add `targetName` as domain (PowerShell#14504)

*** Build and Packaging Improvements

<details>

<summary>

Bump .NET SDK to 5.0.4

</summary>

<ul>
<li>Bump .NET SDK to 5.0.4 (Internal 14775)</li>
<li>Disable running markdown link verification in release build CI (PowerShell#14971, PowerShell#14974, PowerShell#14975)</li>
<li>Use template that disables component governance for CI (PowerShell#14938)</li>
<li>Declare which variable group is used for checking the blob in the release build (PowerShell#14970)</li>
<li>Add suppress for nuget multi-feed warning (PowerShell#14893)</li>
<li>Disable code signing validation where the file type is not supported (PowerShell#14885)</li>
<li>Install wget on <code>CentOS</code> 7 docker image (PowerShell#14857)</li>
<li>Fix install-dotnet download (PowerShell#14856)</li>
<li>Make universal Deb package based on deb package spec (PowerShell#14681)</li>
<li>Fix release build to upload global tool packages to artifacts (PowerShell#14620)</li>
<li>Update <code>ini</code> component version in test <code>package.json</code> (PowerShell#14454)</li>
<li>Add manual release automation steps and improve changelog script (PowerShell#14445)</li>
<li>Update markdown test packages with security fixes (PowerShell#14145)</li>
<li>Fix a typo in the <code>Get-ChangeLog</code> function (PowerShell#14129)</li>
<li>Disable global tool copy to unblock release</li>
</ul>

</details>

[7.1.3]: PowerShell/PowerShell@v7.1.2...v7.1.3
@ghost

Deleted user (ghost) commented Mar 16, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 17, 2021
Bump Microsoft.PowerShell.SDK from 6.2.1 to 7.1.3 Accenture/Ocaramba#191
Closed
Bump Microsoft.WSMan.Management from 6.2.1 to 7.1.3 Accenture/Ocaramba#196
Closed
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022
Back-port to 7.0: Update list of PowerShell team members in release tools #18266
Merged
22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Disable codesign validation where the file type is not supported (Pow…
d80b1ec 
…erShell#14885)

* disable codesign validation where it fails

* disable macOS filesigning too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

Backport-7.0.x-Done Backport-7.1.x-Done Backport to 7.1.x completed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.