GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update the vmImage and PowerShell root directory for macOS builds by adityapatwardhan · Pull Request #16611 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Dec 13, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Update to use macos-latest and the vmImage for the macOS release build.
Use the Agent.TempDirectory as the Powershell root, as the AzDO recommendation.
Optionally, use the Agent.TempDirectory as PS root for macOS builds.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Aditya Patwardhan (adityapatwardhan) added 2 commits December 13, 2021 14:12
@adityapatwardhan
Fix macos packaging build and update vmImage
02f25bf
@adityapatwardhan
Use Agent.TempDirectory for PowerShell root
1fd8b4f
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) December 13, 2021 22:33
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners December 13, 2021 22:33
@ghost ghost assigned Travis Plunk (TravisEz13) Dec 13, 2021
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Dec 13, 2021
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Update the vmImage and PowerShell root directory for macOS builds WIP: Update the vmImage and PowerShell root directory for macOS builds Dec 13, 2021
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 13, 2021
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Dec 13, 2021
View reviewed changes
@adityapatwardhan
Fix typo
6dba095
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Dec 13, 2021

Copy link
Copy Markdown

This PR has 28 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +18 -10
Percentile : 11.2%

Total files changed: 3

Change summary by file extension:
.yml : +18 -10

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title WIP: Update the vmImage and PowerShell root directory for macOS builds Update the vmImage and PowerShell root directory for macOS builds Dec 14, 2021
TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 14, 2021
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit a54b9a2 into PowerShell:master Dec 14, 2021
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FixMacOsBuild2 branch December 14, 2021 00:13
TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@adityapatwardhan @TrapGodBrim
Update the vmImage and PowerShell root directory for macOS builds (P…
ea8dac9
…owerShell#16611)
@ghost

Deleted user (ghost) commented Feb 24, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) added BackPort-7.0.x-Approved labels Mar 7, 2022
Dongbo Wang (daxian-dbw) pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2022
@adityapatwardhan @TravisEz13
Update the vmImage and PowerShell root directory for macOS builds (P…
555dabe
…owerShell#16611)
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.2.x-Done Backport-7.1.x-Done Backport to 7.1.x completed Backport-7.0.x-Done and removed Backport-7.2.x-Approved labels Mar 11, 2022
Dongbo Wang (daxian-dbw) pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 14, 2022
@adityapatwardhan @TravisEz13
Update the vmImage and PowerShell root directory for macOS builds (P…
3a727eb
…owerShell#16611)

# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/mac-package-build.yml
Dongbo Wang (daxian-dbw) pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 15, 2022
@adityapatwardhan @TravisEz13
Update the vmImage and PowerShell root directory for macOS builds (P…
2c9a6b8
…owerShell#16611)

# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/mac-package-build.yml
@ghost

Deleted user (ghost) commented Mar 16, 2022

Copy link
Copy Markdown

🎉v7.0.9 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost

Deleted user (ghost) commented Mar 16, 2022

Copy link
Copy Markdown

🎉v7.1.6 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost

Deleted user (ghost) commented Mar 16, 2022

Copy link
Copy Markdown

🎉v7.2.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request May 24, 2022
Update TLS test based on current platform settings #17424
Merged
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jun 7, 2022
Backport test fixes for 7.2 #17494
Merged
22 tasks
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022
Back-port to 7.0: Update list of PowerShell team members in release tools #18266
Merged
22 tasks
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Apr 16, 2024
WIP: add more detail to suspicious scriptblock logging #21475
Closed
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jul 9, 2024
Add script to update SDK for release branches #24034
Merged
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Update the vmImage and PowerShell root directory for macOS builds (P…
45630e9
…owerShell#16611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

Backport-7.0.x-Done Backport-7.1.x-Done Backport to 7.1.x completed Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@adityapatwardhan @TravisEz13 @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.