GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve WebSession.MaximumRedirection from changes by CarloToso · Pull Request #19190 · PowerShell/PowerShell

Conversation

@CarloToso

@CarloToso CarloToso commented Feb 22, 2023 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

The WebSession.MaximumRedirection parameter shouldn't change as we handle redirections.
This bug appears in edge cases when we use -WebSession -AllowInsecureRedirect -MaximumRedirection together.

Add some tests to check that WebSession doesn't change during usage

PR Context

Fix #19183

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CarloToso
fix bug
6571d1b
@CarloToso
CarloToso requested a review from Paul Higinbotham (PaulHigin) as a code owner February 22, 2023 01:20
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Feb 22, 2023
iSazonov
Ilya (iSazonov) approved these changes Feb 22, 2023
View reviewed changes
@CarloToso CarloToso mentioned this pull request Feb 25, 2023
Enable HTTP persistence when using Session with Invoke-WebRequest and Invoke-RestMethod #19173
Closed
7 of 22 tasks
CarloToso added 2 commits February 26, 2023 02:26
@CarloToso
add tests
f61c070
@CarloToso
fix tests
30e44cf
iSazonov
Ilya (iSazonov) reviewed Feb 26, 2023
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) self-assigned this Feb 26, 2023
@iSazonov Ilya (iSazonov) changed the title WebCmdlets fix bug -WebSession -AllowInsecureRedirect -MaximumRedirection together wrong number of redirections Fix WebCmdlets bug -WebSession -AllowInsecureRedirect -MaximumRedirection together wrong number of redirections Feb 26, 2023
CarloToso added 2 commits February 27, 2023 10:26
@CarloToso
add more tests
7337f24
@CarloToso
add session proxy test
7add56c
@iSazonov

Ilya (iSazonov) commented Feb 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CarloToso I suggest don't modify existing test and add new one - create WebRequestSession $session = [WebRequestSession]::new(), assign properties, iwr -WebSession $session and check that properties are unchanged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CarloToso added 2 commits February 27, 2023 23:39
@CarloToso
revert
5b1d2f4
@CarloToso
Merge branch 'master' into fix-bug-WebSession.MaximumRedirects
b35a28e
@iSazonov Ilya (iSazonov) closed this Feb 28, 2023
@iSazonov Ilya (iSazonov) reopened this Feb 28, 2023
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 28, 2023
@iSazonov

Ilya (iSazonov) commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CarloToso Please update the PR title and description.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CarloToso added 4 commits February 28, 2023 11:20
@CarloToso
add session.Credentials test
8c5b365
@CarloToso
fix test
e52ce62
@CarloToso
codefactor
ef4f5fe
@CarloToso
add session.certificates test; fix headers
de55c03
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Small and removed Extra Small labels Feb 28, 2023
@CarloToso
remove incorrectly pasted code
3f9f4a8
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Extra Small and removed Small labels Feb 28, 2023
@CarloToso
add test session.proxy
b438e17
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot removed the Extra Small label Feb 28, 2023
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Small label Feb 28, 2023
@iSazonov
Ilya (iSazonov) self-requested a review February 28, 2023 15:59
CarloToso added 3 commits February 28, 2023 18:52
@CarloToso
[WebRequestSession]::New(); modify tests; try fix proxy test
0e6d764
@CarloToso
certificates
143c6b4
@CarloToso
try fix proxy
ceaf473
iSazonov
Ilya (iSazonov) reviewed Mar 1, 2023
View reviewed changes
Comment thread ...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

CarloToso and others added 3 commits March 1, 2023 10:16
@CarloToso @iSazonov
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Web…
37de413
…Cmdlet/Common/WebRequestPSCmdlet.Common.cs

Co-authored-by: Ilya <[email protected]>
@CarloToso
merge tests
ed4ca14
@CarloToso
title
02d9d9e
iSazonov
Ilya (iSazonov) reviewed Mar 1, 2023
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
N -> n
e552850
@iSazonov Ilya (iSazonov) changed the title Fix WebCmdlets bug -WebSession -AllowInsecureRedirect -MaximumRedirection together wrong number of redirections Preserve WebSession.MaximumRedirection from changes Mar 1, 2023
iSazonov
Ilya (iSazonov) reviewed Mar 1, 2023
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

CarloToso added 3 commits March 1, 2023 16:41
@CarloToso
remove try-catch
ded4f00
@CarloToso
follow suggestion
3a5cdf0
@CarloToso
change proxy
a3180e3
iSazonov
Ilya (iSazonov) reviewed Mar 1, 2023
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated

$session = [Microsoft.PowerShell.Commands.WebRequestSession]::new()
$session.Proxy = [System.Net.WebProxy]::new($proxy)
$null = Invoke-WebRequest -Uri http://httpbin.org -PreserveAuthorizationOnRedirect -WebSession $session -Headers $headers

@iSazonov Ilya (iSazonov) Mar 1, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use external server for tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@CarloToso CarloToso Mar 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same was done in line 2419 with this comment:
# use external url, but with proxy the external url should not actually be called

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@iSazonov Ilya (iSazonov) Mar 1, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible it must be replaced with our helper.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@iSazonov Ilya (iSazonov) Mar 1, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
CarloToso added 2 commits March 1, 2023 18:24
@CarloToso
fix tests
f6a9e1c
@CarloToso
use $uri
4b3ee47
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Mar 1, 2023

Copy link
Copy Markdown

This PR has 70 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +66 -4
Percentile : 28%

Total files changed: 2

Change summary by file extension:
.cs : +5 -3
.ps1 : +61 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov
Ilya (iSazonov) merged commit f1ab653 into PowerShell:master Mar 1, 2023
@CarloToso
CarloToso deleted the fix-bug-WebSession.MaximumRedirects branch March 1, 2023 19:10
@CarloToso CarloToso mentioned this pull request Mar 2, 2023
Support HTTP persistent connections in Web Cmdlets #19249
Merged
8 of 22 tasks
@ghost

Deleted user (ghost) commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost mentioned this pull request Mar 14, 2023
InvokeWeb-Request -WebSession -AllowInsecureRedirect -MaximumRedirection together wrong number of redirections #19183
Closed
5 tasks done
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request Mar 15, 2023
Update web cmdlet docs for 7.4-preview.2 release MicrosoftDocs/PowerShell-Docs#9908
Closed
2 tasks done
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@CarloToso
Preserve WebSession.MaximumRedirection from changes (PowerShell#19190)
9de7e05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

InvokeWeb-Request -WebSession -AllowInsecureRedirect -MaximumRedirection together wrong number of redirections

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@CarloToso @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.