GeezerVison is showing github.com — Checkin generated manpage by TravisEz13 · Pull Request #24423 · PowerShell/PowerShell
Conversation
PR Summary
This pull request introduces several changes to the macOS packaging process, including updates to the build scripts and dependencies. The most significant changes involve adding a new packaging stage, removing the ronn dependency, and updating the man page generation process.
macOS Packaging Process:
- Added a new
PackageMac stage to the .vsts-ci/mac.yml file, which depends on the BuildMac stage and includes steps for macOS packaging using PowerShell. (.vsts-ci/mac.yml)
Dependency Management:
- Removed the
ronn dependency from the Start-PSBootstrap function in build.psm1 and the Get-PackageDependencies function in tools/packaging/packaging.psm1. (build.psm1) [1] (tools/packaging/packaging.psm1) [2]
Man Page Generation:
- Updated the man page generation process to use
roff instead of ronn in the New-ManGzip function in tools/packaging/packaging.psm1. (tools/packaging/packaging.psm1)
- Added a new man page for
pwsh in assets/manpage/pwsh.1. (assets/manpage/pwsh.1)
PR Context
macOS man page generation is failing. Checking in asset so we can get the release working.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Make sure all
.h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
- Breaking changes
- User-facing changes
- Testing - New and feature
- Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
- Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
- Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Aditya Patwardhan (adityapatwardhan)
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Oct 15, 2024
* checkin generataed manpage
* move ronn file into new folder
* update build and release to use new asset
* add a minimal macos packaging test
* add correct dependency for the macos packaging stage
* fix packaging error
* remove removing files
Aditya Patwardhan (adityapatwardhan)
pushed a commit
that referenced
this pull request
Oct 22, 2024
* checkin generataed manpage
* move ronn file into new folder
* update build and release to use new asset
* add a minimal macos packaging test
* add correct dependency for the macos packaging stage
* fix packaging error
* remove removing files
Aditya Patwardhan (adityapatwardhan)
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Oct 31, 2024
* checkin generataed manpage
* move ronn file into new folder
* update build and release to use new asset
* add a minimal macos packaging test
* add correct dependency for the macos packaging stage
* fix packaging error
* remove removing files
This was referenced Jan 17, 2025
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
* checkin generataed manpage
* move ronn file into new folder
* update build and release to use new asset
* add a minimal macos packaging test
* add correct dependency for the macos packaging stage
* fix packaging error
* remove removing files
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|