GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Checkin generated manpage by TravisEz13 · Pull Request #24423 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Oct 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

This pull request introduces several changes to the macOS packaging process, including updates to the build scripts and dependencies. The most significant changes involve adding a new packaging stage, removing the ronn dependency, and updating the man page generation process.

macOS Packaging Process:

  • Added a new PackageMac stage to the .vsts-ci/mac.yml file, which depends on the BuildMac stage and includes steps for macOS packaging using PowerShell. (.vsts-ci/mac.yml)

Dependency Management:

  • Removed the ronn dependency from the Start-PSBootstrap function in build.psm1 and the Get-PackageDependencies function in tools/packaging/packaging.psm1. (build.psm1) [1] (tools/packaging/packaging.psm1) [2]

Man Page Generation:

  • Updated the man page generation process to use roff instead of ronn in the New-ManGzip function in tools/packaging/packaging.psm1. (tools/packaging/packaging.psm1)
  • Added a new man page for pwsh in assets/manpage/pwsh.1. (assets/manpage/pwsh.1)

PR Context

macOS man page generation is failing. Checking in asset so we can get the release working.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      - [ ] Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@TravisEz13
checkin generataed manpage
0410008
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.2.x-Consider Backport-7.4.x-Consider Backport-7.5.x-Consider labels Oct 11, 2024
Travis Plunk (TravisEz13) added 2 commits October 14, 2024 10:31
@TravisEz13
move ronn file into new folder
77c7604
@TravisEz13
update build and release to use new asset
0d60fa0
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 14, 2024 17:32
Travis Plunk (TravisEz13) added 3 commits October 14, 2024 10:46
@TravisEz13
add a minimal macos packaging test
01a6243
@TravisEz13
add correct dependency for the macos packaging stage
83baa11
@TravisEz13
fix packaging error
cc30f3b
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Oct 14, 2024
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Oct 14, 2024
@TravisEz13
remove removing files
820dac4
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Checkin generataed manpage Checkin generated manpage Oct 14, 2024
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 14, 2024
View reviewed changes
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 14, 2024
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit ac8ab0d into PowerShell:master Oct 14, 2024
@TravisEz13
Travis Plunk (TravisEz13) deleted the generate-manpage branch October 14, 2024 19:16
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.2.x-Done and removed Backport-7.2.x-Consider labels Oct 14, 2024
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Approved and removed Backport-7.4.x-Consider labels Oct 14, 2024
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Oct 15, 2024
@TravisEz13 @adityapatwardhan
Checkin generated manpage (PowerShell#24423)
e708f1e
* checkin generataed manpage

* move ronn file into new folder

* update build and release to use new asset

* add a minimal macos packaging test

* add correct dependency for the macos packaging stage

* fix packaging error

* remove removing files
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Oct 15, 2024
[release/v7.4] Checkin generated manpage #24447
Merged
Aditya Patwardhan (adityapatwardhan) added a commit that referenced this pull request Oct 15, 2024
@adityapatwardhan
Checkin generated manpage (#24423) (#24447)
6026aeb
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Done and removed Backport-7.4.x-Approved labels Oct 15, 2024
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 17, 2024
Aditya Patwardhan (adityapatwardhan) pushed a commit that referenced this pull request Oct 22, 2024
@TravisEz13 @adityapatwardhan
Checkin generated manpage (#24423)
b80e792
* checkin generataed manpage

* move ronn file into new folder

* update build and release to use new asset

* add a minimal macos packaging test

* add correct dependency for the macos packaging stage

* fix packaging error

* remove removing files
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.5.x-Approved and removed Backport-7.5.x-Consider labels Oct 31, 2024
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Oct 31, 2024
@TravisEz13 @adityapatwardhan
Checkin generated manpage (PowerShell#24423)
89a2d83
* checkin generataed manpage

* move ronn file into new folder

* update build and release to use new asset

* add a minimal macos packaging test

* add correct dependency for the macos packaging stage

* fix packaging error

* remove removing files
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Oct 31, 2024
[release/v7.5] Checkin generated manpage #24519
Merged
Aditya Patwardhan (adityapatwardhan) added a commit that referenced this pull request Oct 31, 2024
@adityapatwardhan
Checkin generated manpage (#24423) (#24519)
afd21a3
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.5.x-Done and removed Backport-7.5.x-Approved labels Oct 31, 2024
This was referenced Jan 17, 2025
Add a new file for v7.5.0 changelog #24807
Closed
Fix backport issues with release pipeline #24835
Merged
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Aug 22, 2025
WIP [release/v7.5] rebuild based on packages #25894
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Checkin generated manpage (PowerShell#24423)
0ba4022
* checkin generataed manpage

* move ronn file into new folder

* update build and release to use new asset

* add a minimal macos packaging test

* add correct dependency for the macos packaging stage

* fix packaging error

* remove removing files
@ChrisTX Christian Pfeiffer (ChrisTX) mentioned this pull request Oct 30, 2026
Fix the truncated pwsh man page #28293
Open
7 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.2.x-Done Backport-7.4.x-Done Backport-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@TravisEz13 @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.