GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix the truncated pwsh man page by ChrisTX · Pull Request #28293 · PowerShell/PowerShell

Conversation

Christian Pfeiffer (ChrisTX) commented Oct 30, 2026

Copy link

Copy Markdown

PR Summary

Fixes #21086.

The checked-in assets/manpage/pwsh.1, which the Linux and macOS packages install, ends in the middle of the synopsis at -WindowStyle. Everything after it is missing: the rest of the synopsis, the description, all options, files, environment, automatic variables, see also and copyright.

The cause is the placeholder <style> in pwsh.1.ronn. Ronn treats <name> as a placeholder, but style is also the name of an HTML element, so it parses <style> as one and drops what follows. With Ronn 0.7.3, which generated the current pwsh.1, that's the rest of the document; Ronn-NG only drops the rest of the synopsis.

This PR:

renames the placeholder to <windowStyle>, like the other camelCase placeholders (<filePath>, <directoryPath>), so all placeholders are still rendered the same way
regenerates pwsh.1 from pwsh.1.ronn (ronn -r pwsh.1.ronn, Ronn-NG 0.10.1)

The regenerated page has all nine sections, and groff -man -ww -z pwsh.1 reports no warnings.

PR Context

The man page installed with PowerShell on Linux and macOS only shows the name and the start of the synopsis (#21086). pwsh.1 was checked in by #24423, which generates the packages' man page from that file instead of running Ronn during packaging.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix the truncated pwsh man page

921809c

The checked-in pwsh.1 ends in the synopsis at -WindowStyle, because Ronn
takes its placeholder <style> for an HTML style element and drops what
follows. Rename the placeholder to <windowStyle>, like the other
camelCase placeholders, and regenerate pwsh.1 from pwsh.1.ronn.

Fixes PowerShell#21086

Co-Authored-By: Claude Opus 5.5 <[email protected]>

Copilot AI balanced review requested due to automatic review settings

October 30, 2026 21:45

Christian Pfeiffer (ChrisTX) requested a review from a team as a code owner

October 30, 2026 21:45

azure-pipelines Bot commented Oct 30, 2026

Copy link

Copy Markdown

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot started reviewing on behalf of Christian Pfeiffer (ChrisTX)

October 30, 2026 21:46

View session

Christian Pfeiffer (ChrisTX) commented Oct 30, 2026

Copy link

Copy Markdown

Author

@microsoft-github-policy-service agree

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot AI reviewed

Oct 30, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change restoring the packaged pwsh man page.

No open issues 🎉

What changed in this PR

Fixes #21086 by restoring the complete pwsh man page installed by Linux and macOS packages, which use the checked-in generated file introduced in #24423.

Changes:

Renames <style> to <windowStyle> to prevent Ronn from interpreting the placeholder as an HTML element.
Regenerates the man page with Ronn-NG 0.10.1, restoring the complete synopsis and all nine sections.

File	Description
`assets/manpage/pwsh.1.ronn`	Corrects the placeholder that caused truncation.
`assets/manpage/pwsh.1`	Restores the complete generated man page used by packaging.

_{Review effort: Balanced}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Arch Linux Technical User (archlinux-github) pushed a commit to archlinux/aur that referenced this pull request

Nov 1, 2026


          powershell: check the generated man page

5ff8ddd

- check() fails on groff warnings for pwsh.1 (groff -man -ww -z, as in PowerShell/PowerShell#28293)
- and on sections of pwsh.1.ronn missing from pwsh.1, which groff doesn't notice: the checked-in
  page of PowerShell/PowerShell#21086 ends in the synopsis without a warning
- Runs on cross builds as well, before the test suite is skipped
- groff in checkdepends

Co-Authored-By: Claude Opus 5.5 <[email protected]>

microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label

Nov 7, 2026

microsoft-github-policy-service Bot commented Nov 7, 2026

Copy link

Copy Markdown

Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Review - Needed

The PR is being reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installed manpage on Linux does not look like pwsh.1.ronn

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.