GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added Meta, Charset, and Transitional parameters to ConvertTo-HTML by ergo3114 · Pull Request #4184 · PowerShell/PowerShell

Conversation

@ergo3114

@ergo3114 Littlejohn (ergo3114) commented Jul 4, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Related #3267

Added the Meta, Chartset, and Transitional parameters to ConvertTo-HTML

Meta Allows the user to insert <meta> tag information such as refresh, author, and keywords
Charset Sets the html encoding of the page, denoted by the <charset> html tag
Transitional A switch parameter that allows for the insertion of XHTML Transitional DTD DOCTYPE, the default being XHTML Strict DTD

Edit: Documentation can be found here

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chuanjiao10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Littlejohn (ergo3114) added 5 commits June 27, 2017 20:51
@ergo3114
- Added functionality to convert-HTML.cs to include a charset parameter
be4d32c
@ergo3114
- Fixed issues on the charset parameter where flag was always set to …
883df45 
…false
@ergo3114
- Moved Meta tag into Head tag
3caab36
@ergo3114
- Took away charset defaullt value
cdb3535
@ergo3114
- Added Transitional switch to allow users to switch between strict a…
d0222c5 
…nd transitional DOCTYPEs

- Updated Meta parameter to handle http-equiv properties
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Jul 4, 2017

Copy link
Copy Markdown

Littlejohn (@ergo3114),
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Jul 4, 2017
@ergo3114 Littlejohn (ergo3114) mentioned this pull request Jul 4, 2017
Documentation of Meta, Charset and Transitional parameter for ConvertTo-HTML MicrosoftDocs/PowerShell-Docs#1432
Merged
2 of 8 tasks
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from Steve Lee (SteveL-MSFT) July 5, 2017 22:55
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Travis Plunk (TravisEz13) Jul 5, 2017
@TravisEz13 Travis Plunk (TravisEz13) added the Documentation Needed in this repo Documentation is needed in this repo label Jul 11, 2017
TravisEz13
Travis Plunk (TravisEz13) reviewed Jul 11, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs Outdated
{
if(s != "content-type" && s != "default-style" && s !="refresh")
{
WriteObject("<meta name=\"" + s + "\" content=\"" + _meta[s] + "\">");

@TravisEz13 Travis Plunk (TravisEz13) Jul 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we encode the key and value?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ergo3114 Littlejohn (ergo3114) Jul 11, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would encoding gain us here? I am not familiar with that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) reviewed Jul 11, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs Outdated
WriteObject("<head>");
if(_charsetSpecified)
{
WriteObject("<meta charset=\"" + _charset + "\">");

@TravisEz13 Travis Plunk (TravisEz13) Jul 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably validate or encode the character set.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ergo3114 Littlejohn (ergo3114) Jul 11, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation would be great. I don't see too many changes in the charset list but it would be great if the validation were dynamic pulling from w3schools or something. I was trying to find documentation on what the browser does when a non standard charset is specified; such as "foo". I believe it analyzes the html and determines the best or just defaults to UTF-8 for HTML5.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Jul 12, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure there are illegal characters. Even a validation that validates the user hasn't specified something illegal would be better than nothing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ergo3114 Littlejohn (ergo3114) Jul 12, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put something in and resubmit it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) reviewed Jul 11, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs Outdated
WriteObject("<meta name=\"" + s + "\" content=\"" + _meta[s] + "\">");
}
else {
WriteObject("<meta http-equiv=\"" + s + "\" content=\"" + _meta[s] + "\">");

@TravisEz13 Travis Plunk (TravisEz13) Jul 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we allow these or should it be another parameter like charset

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ergo3114 Littlejohn (ergo3114) Jul 11, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you can validate the meta tag. w3schools shows the schema for the meta tag.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Jul 12, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use ValidatePattern or ValidateScript to implement it? https://blogs.technet.microsoft.com/heyscriptingguy/2011/01/11/validate-powershell-parameters-before-running-the-script/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) requested a review from James Truher (JamesWTruher) July 11, 2017 19:36
@TravisEz13

Travis Plunk (TravisEz13) commented Jul 11, 2017

Copy link
Copy Markdown
Member

James Truher (@JamesWTruher) Can you review the character set parameter here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) previously requested changes Jul 11, 2017
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have a couple of comments. Please review and respond.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Littlejohn (ergo3114) added 3 commits July 15, 2017 15:47
@ergo3114
- Added validation to the Charset parameter
35b44c0 
- Set the output of Charset to upper case if a lowercase value is given
@ergo3114
- Put the Meta parameter output inside the HTML head tag
6b325b7
@ergo3114
- Added filtering for the Meta parameter to only allow defined HTML m…
7d39a6c 
…eta values
SteveL-MSFT
Steve Lee (SteveL-MSFT) reviewed Jul 16, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs
}
set
{
_meta = value;

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 16, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the typical pattern is to use InvocationInfo.BoundParameters. This would then allow you to use the automatic properties to simplify the code a bit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ergo3114 Littlejohn (ergo3114) Jul 16, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to get InvocationInfo.BoundParameters to work. I read over InvocationInfo.cs and ImplicitRemotingCommands.cs to see if I can make sense of it but I am at a loss here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jul 17, 2017

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use an auto property and Meta == null to check if user assign a value.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 23, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be fine, too

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jul 24, 2017

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Littlejohn (@ergo3114) Please address this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ergo3114 Littlejohn (ergo3114) Jul 25, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this as two ways to do the same thing. What are you looking to gain from setting a default value versus checking a flag? Just curious.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 25, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick search shows we already have inconsistency so I'm fine staying with this pattern

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SteveL-MSFT
Steve Lee (SteveL-MSFT) reviewed Jul 16, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs Outdated
{
foreach(string s in _meta.Keys)
{
if(s == "content-type" && s == "default-style" && s =="refresh")

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 16, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be ||? In any case, there's more http-equiv than this list. Perhaps we should just have a separate parameter for http-equiv meta tags and let the user put whatever they want in it? Also, I believe the names are case-insensitive so Content-Type is valid.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ergo3114 Littlejohn (ergo3114) Jul 16, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been changed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SteveL-MSFT
Steve Lee (SteveL-MSFT) reviewed Jul 16, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs
/// Specifies the charset encoding for the HTML document
/// </summary>
[Parameter(ParameterSetName = "Page")]
[ValidateNotNullOrEmpty]

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 16, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the allowed set of (legacy) encodings is quite large although HTML5 I believe has standardized on UTF-8. So perhaps this shouldn't have a ValidateSet?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ergo3114 Littlejohn (ergo3114) Jul 16, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed to the ValidateSet.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jul 16, 2017
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Littlejohn (ergo3114) added 2 commits July 16, 2017 13:06
@ergo3114
- Changed the condition for http-equiv from && to ||
ac28b95 
- Removed Validateset from Charset parameter to allow for legacy character sets
- Added test for Meta, Charset, and Transitional property on ConvertTo-HTML command
@ergo3114
- Removed static declaration while attempting to using InvocationInfo…
3baca91 
….BoundParameters
iSazonov
Ilya (iSazonov) reviewed Jul 17, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs
}
set
{
_meta = value;

@iSazonov Ilya (iSazonov) Jul 17, 2017

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use an auto property and Meta == null to check if user assign a value.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs Outdated
}
set
{
_charset = value.ToUpper();

@iSazonov Ilya (iSazonov) Jul 17, 2017

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we convert a charset to upper case?
It seems we can remove this and use auto property.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jul 24, 2017

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs Outdated
}
set
{
_transitional = value;

@iSazonov Ilya (iSazonov) Jul 17, 2017

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use an auto property for a switch parameter without getter/setter.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Littlejohn (ergo3114) added 3 commits July 22, 2017 17:16
@ergo3114
- Removed defined get/set functions from the transitional switch para…
56a7db3 
…meter

- Removed private variable for transitional switch parameter
- Removed toUpper() functin from charset
@ergo3114
- Removed commented out testing
71168cc
@ergo3114
Merge remote-tracking branch 'refs/remotes/PowerShell/master'
06ef847
@ergo3114
- Added X-UA-Compatible as an approved meta item
65ef76c 
- Set meta hashtable keys to lower before checking in switch statement
- Updated test for the transitional parameter to check only the first line of the result
- Updated test to be more specific on the error message that is returned when thrown
- Added logic to prevent duplicate meta tags
@ergo3114
Littlejohn (ergo3114) requested review from Paul Higinbotham (PaulHigin) and Dan Travison (dantraMSFT) as code owners August 27, 2017 17:19
Littlejohn (ergo3114) added 2 commits August 27, 2017 17:03
@ergo3114
- Pull from upstream
7383f1b
@ergo3114
- Updated Test ConvertTo-HTML meta with invalid properties should thow
b82a9b6
dantraMSFT
Dan Travison (dantraMSFT) reviewed Aug 31, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs
/// </summary>
/// <returns></returns>
[Parameter(ParameterSetName = "Page")]
[ValidateNotNullOrEmpty]

@dantraMSFT Dan Travison (dantraMSFT) Aug 31, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want { get; set; } here instead of a field.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Aug 31, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs
break;
}
useditems.Add(s);
}

@SteveL-MSFT Steve Lee (SteveL-MSFT) Aug 31, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we should give a warning if we are dropping duplicates

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ergo3114 Littlejohn (ergo3114) Sep 6, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed it to a warning and decided to keep the meta tags that don't match the switch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Littlejohn (ergo3114) added 2 commits August 31, 2017 18:09
@ergo3114
- added {get;set;} for the Transitional vaiable
c0c4235
@ergo3114
- Added warning message to meta tag from error
19f2ea2
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Sep 6, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs Outdated
ThrowTerminatingError (new ErrorRecord(exc, "MetaPropertyNotFound", ErrorCategory.ParserError, null));
//Exception exc = new NotSupportedException(StringUtil.Format(ConvertHTMLStrings.MetaPropertyNotFound, s));
MshCommandRuntime mshCommandRuntime = this.CommandRuntime as MshCommandRuntime;
string Message = "Accepted meta properties are content-type, default-style, application-name, author, description, generator, keywords, x-ua-compatible, and viewport. The meta pair: " + s + " and " + _meta[s] + " may not function correctly.";

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 6, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new string in the resx file so that it can be localized

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Html.Tests.ps1 Outdated
It "Test ConvertTo-HTML meta with invalid properties should throw"{
{ ($customObject | ConvertTo-HTML -Meta @{"authors"="John Doe";"keywords"="PowerShell,PSv6"}) -join $newLine } | Should Throw "authors is not a supported meta property. Accepted meta properties are content-type, default-style, application-name, author, description, generator, keywords, x-ua-compatible, and viewport."
It "Test ConvertTo-HTML meta with invalid properties should throw warning" {
($customObject | ConvertTo-HTML -Meta @{"authors"="John Doe";"keywords"="PowerShell,PSv6"} 3>&1) -match "Accepted meta properties are" | Should Be $true

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 6, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the message could be localized, you probably just need to check that the warning contains the Meta tags you used in the test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Littlejohn (ergo3114) added 4 commits September 7, 2017 01:41
@ergo3114
- Pull warning from resource file
a380a35
@ergo3114
- Removed commented out code
4970e36
@ergo3114
- Repush for Appveyor test
3a07e00
@ergo3114
- Repushing after rebase
da80adc
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Sep 7, 2017
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Html.Tests.ps1 Outdated
}

It "Test ConvertTo-HTML meta with invalid properties should throw warning" {
($customObject | ConvertTo-HTML -Meta @{"authors"="John Doe";"keywords"="PowerShell,PSv6"} 3>&1) -match "Accepted meta properties are" | Should Be $true

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the warning message can be localized, you shouldn't check against the English string. Instead, check that the warning message contains the meta pair.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Littlejohn (ergo3114) added 2 commits September 8, 2017 13:31
@ergo3114
- Changed to pull warning message from resouce file
a0ac1a1
@ergo3114
- Changed test for invalid meta keys to look for key pair in verbose …
605453f 
…output
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Sep 8, 2017
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Sep 11, 2017
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit bbc180a into PowerShell:master Sep 11, 2017
Travis Plunk (TravisEz13) added a commit to TravisEz13/PowerShell that referenced this pull request Sep 20, 2017
@TravisEz13
Revert pester portion of Added Meta, Charset, and Transitional parame…
cf2037d 
…ters to ConvertTo-HTML (PowerShell#4184)

 (reverted from commit bbc180a)
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Sep 20, 2017
Revert pester portion of Added Meta, Charset, and Transitional parame… #4881
Merged
Dongbo Wang (daxian-dbw) pushed a commit that referenced this pull request Sep 20, 2017
@TravisEz13 @daxian-dbw
Revert the changes to Pester from merged PR #4184 (#4881)
4c6ad4a 
That PR incorrectly included Pester changes. Most likely because that individual did not update his submodules.
@joeyaiello Joey Aiello (joeyaiello) mentioned this pull request Oct 15, 2018
Docs needed for 'Added Meta, Charset, and Transitional parameters to ConvertTo-HTML' MicrosoftDocs/PowerShell-Docs#3095
Closed
@joeyaiello Joey Aiello (joeyaiello) removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@ergo3114 @TravisEz13
Added Meta, Charset, and Transitional parameters to ConvertTo-HTML (P…
b2671e2 
…owerShell#4184)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13 @daxian-dbw
Revert the changes to Pester from merged PR PowerShell#4184 (PowerShe…
efe3bf8 
…ll#4881)

That PR incorrectly included Pester changes. Most likely because that individual did not update his submodules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
+2 more reviewers
@JamesWTruher James Truher (JamesWTruher) JamesWTruher left review comments
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ergo3114 @msftclas @TravisEz13 @JamesWTruher @SteveL-MSFT @dantraMSFT @iSazonov @joeyaiello
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.