GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert pester portion of Added Meta, Charset, and Transitional parame… by TravisEz13 · Pull Request #4881 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Sep 20, 2017 •
edited by daxian-dbw
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

…ters to ConvertTo-HTML (#4184)

(reverted from commit bbc180a)

My understanding is that #4184 reverted the pester submodule. This is reverting it back.
James Truher (@JamesWTruher) contacted me. I'm not sure of the exact issue.

From James Truher (@JamesWTruher):

a previous merge bbc180a incorrectly included pester changes. Most likely because that individual did not update his submodules.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Revert pester portion of Added Meta, Charset, and Transitional parame…
cf2037d 
…ters to ConvertTo-HTML (PowerShell#4184)

 (reverted from commit bbc180a)
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Sep 20, 2017
@TravisEz13
Travis Plunk (TravisEz13) requested a review from James Truher (JamesWTruher) September 20, 2017 20:50
@TravisEz13 Travis Plunk (TravisEz13) assigned Dongbo Wang (daxian-dbw) Sep 20, 2017
JamesWTruher
James Truher (JamesWTruher) approved these changes Sep 20, 2017
View reviewed changes
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 20, 2017

Copy link
Copy Markdown
Member

Travis Plunk (@TravisEz13) Can you please add a PR description to explain why we are reverting it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JamesWTruher

James Truher (JamesWTruher) commented Sep 20, 2017

Copy link
Copy Markdown
Collaborator

a previous merge bbc180a incorrectly included pester changes. Most likely because that individual did not update his submodules.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 4c6ad4a into PowerShell:master Sep 20, 2017
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Sep 21, 2017

Copy link
Copy Markdown
Member

is there any downside to having start-psbuild do a git submodule update?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) deleted the Revert_Pester branch September 27, 2017 18:55
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13 @daxian-dbw
Revert the changes to Pester from merged PR PowerShell#4184 (PowerShe…
efe3bf8 
…ll#4881)

That PR incorrectly included Pester changes. Most likely because that individual did not update his submodules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@TravisEz13 @daxian-dbw @JamesWTruher @SteveL-MSFT @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.