GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make sure web hook gets called by TravisEz13 · Pull Request #5249 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Oct 26, 2017

Copy link
Copy Markdown
Member

if something goes wrong during the build, we might exit and not update the badge or fire the webhook.

Enable the after_success and after_failure stages of the travis-ci build so we can have a better chance of getting these done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) added 2 commits October 26, 2017 16:06
@TravisEz13
Call travis.ps1 for failure and success
7c05cc6
@TravisEz13
move code to report success or failure to when travis-ci calls us for…
44842cb 
… success or failure
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners October 26, 2017 23:12
daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Oct 26, 2017
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this arrangement. It's cleaner. I left one comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tools/travis.ps1 Outdated
$result = 'FAIL'
}

if ((-not $isPr) -and $cronBuild) {

@daxian-dbw Dongbo Wang (daxian-dbw) Oct 26, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is -not $isPr necessary? $cronBuild is true only if $env:TRAVIS_EVENT_TYPE -eq 'cron'.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Oct 26, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 26, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than Dongbo's comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) added 2 commits October 26, 2017 16:37
@TravisEz13
address PR comments
d83870e
@TravisEz13
add missing bracket
f4e7ae5
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Oct 27, 2017
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit ce03a6c into PowerShell:master Oct 27, 2017
@TravisEz13
Travis Plunk (TravisEz13) deleted the makeSureWebHookGetsCalled branch October 27, 2017 18:35
@iSazonov Ilya (iSazonov) mentioned this pull request Nov 13, 2017
Add PSTypeName Support for Import-Csv and ConvertFrom-Csv #5389
Merged
@SteveL-MSFT Steve Lee (SteveL-MSFT) mentioned this pull request Nov 13, 2017
Fix Single Value JSON null in Invoke-RestMethod #5338
Merged
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Nov 13, 2017
Try fixing the 'brew update' issue in bootstrap script #5400
Merged
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Make sure web hook gets called (PowerShell#5249)
f4b49ce 
if something goes wrong during the build, we might exit and not update the badge or fire the webhook.

Enable the after_success and after_failure stages of the travis-ci build so we can have a better chance of getting these done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @daxian-dbw @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.