GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Try fixing the 'brew update' issue in bootstrap script by daxian-dbw · Pull Request #5400 · PowerShell/PowerShell

Conversation

Dongbo Wang (daxian-dbw) commented Nov 9, 2017

Copy link

Copy Markdown

Member

This is an attempt to fix the 'brew update' failure that happens a lot in your macOS CI runs: RPC failed; curl 56 SSLRead() return error -36.

With this change, we will try run brew update twice. The first run is the same as before, but if it fails, then we increase the Git buffer size before the second attempt.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Try fixing the 'brew update' issue in bootstrap script

b0bc37c

Dongbo Wang (daxian-dbw) requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan) as code owners

November 9, 2017 23:42


          Add a log message

cceb236

Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan)

Nov 9, 2017

Aditya Patwardhan (adityapatwardhan) approved these changes

Nov 10, 2017

View reviewed changes

Aditya Patwardhan (adityapatwardhan) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With minor comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tools/installpsh-osx.sh

		# A potential solution is to increase the Git buffer size to a larger number, say 150 mb. The default buffer size is 1 mb.
		echo "First attempt of update failed. Increase Git buffer size and try again ..."
		git config --global http.postBuffer 157286400
		sleep 5

Aditya Patwardhan (adityapatwardhan) Nov 10, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required? Can you put a comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Dongbo Wang (daxian-dbw) Nov 10, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will add a comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Dongbo Wang (daxian-dbw) closed this

Nov 10, 2017

Dongbo Wang (daxian-dbw) reopened this

Nov 10, 2017

Travis Plunk (TravisEz13) reviewed

Nov 10, 2017

View reviewed changes

Comment thread

tools/installpsh-osx.sh

		# Try the update twice if the first time fails
		brew update > /dev/null && break

		# If the update fails again after increasing the Git buffer size, exit with error.

Travis Plunk (TravisEz13) Nov 10, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caching the brew cache in travis-ci might help:

cache:
  directories:
    - $HOME/Library/Caches/Homebrew

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daxian-dbw reacted with thumbs up emoji

All reactions

👍 1 reaction

Dongbo Wang (daxian-dbw) Nov 10, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Travis! I will add this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) approved these changes

Nov 10, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) mentioned this pull request

Nov 10, 2017

Support '[package]' tag in PR CI and fix nightly build on macOS #5410

Merged


          Add a comment

bd67554

Aditya Patwardhan (adityapatwardhan) commented Nov 13, 2017

Copy link

Copy Markdown

Member

Dongbo Wang (@daxian-dbw) Can you rebase and get #5249

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Dongbo Wang (daxian-dbw) commented Nov 13, 2017

Copy link

Copy Markdown

Member Author

Aditya Patwardhan (@adityapatwardhan) Sorry that I don't understand your comment -- the PR #5249 has been merged for over 2 weeks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Dongbo Wang (daxian-dbw) commented Nov 13, 2017

Copy link

Copy Markdown

Member Author

Travis-CI finally passed: https://travis-ci.org/PowerShell/PowerShell/builds/300376520?utm_source=github_status&utm_medium=notification

I will not add code that caches the brew cache yet (Travis suggested that) because I want to verify if the fix can resolve the "Curl error" in brew update. We can add that cache optimization later. Issue #5436 opened to track it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Aditya Patwardhan (adityapatwardhan) commented Nov 13, 2017

Copy link

Copy Markdown

Member

It seems the fix in #5429 does not fix all the webhook issues. The tests seems to have passed but GitHub doesnot seem it as passed. I will merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Aditya Patwardhan (adityapatwardhan) merged commit da0b384 into PowerShell:master

Nov 13, 2017

Dongbo Wang (daxian-dbw) deleted the oxsbootstrap branch

November 13, 2017 20:34

Dongbo Wang (daxian-dbw) commented Nov 13, 2017

Copy link

Copy Markdown

Member Author

Aditya Patwardhan (@adityapatwardhan) The webhook fix in that PR is for the build report in our Team channel, not for the Github package. This should be something wrong with the Travis CI.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Try fixing the 'brew update' issue in bootstrap script (PowerShell#5400)

998ffeb

* Try fixing the 'brew update' issue in bootstrap script

* Add a log message

* Add a comment

Reviewers

Travis Plunk (TravisEz13)

TravisEz13 approved these changes

Aditya Patwardhan (adityapatwardhan)

adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.