GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make Travis CI use libcurl+openssl+gssapi for macOS by markekraus · Pull Request #5629 · PowerShell/PowerShell

Conversation

@markekraus

@markekraus Mark Kraus (markekraus) commented Dec 5, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes #5590

  • makes Travis CI use the brew installed libcurl that uses OpenSSL for the crypto provider and include the gssapi option. The native libcurl provides inconsistent feature support across OS versions.
  • re-enable tests marked pending in Make the '-SslProtocol' tests pending #5605
  • GSSAPI is required for PowerShellGet in order to support HttpClientHandler.UseDefaultCredentials which it sets as true (unless you supply credentials).

PR Checklist

Note: Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Update the changelog
  • User facing Documentation needed
    • Issue filed - Issue link: Document macOS Web Cmdlet Limitations for 6.0.0 MicrosoftDocs/PowerShell-Docs#1926
  • Change is not breaking
  • [NA] Make sure you've added a new test, if existing tests do not effectively test the code changed
    • Add [feature] if the change is significant or affectes feature tests

PR Summary

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markekraus Mark Kraus (markekraus) added the Documentation Needed in this repo Documentation is needed in this repo label Dec 5, 2017
@markekraus
Mark Kraus (markekraus) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners December 5, 2017 10:31
@markekraus Mark Kraus (markekraus) changed the title Make Travis CI use libcurl+openssl Make Travis CI use libcurl+openssl+gssapi Dec 5, 2017
@markekraus
Mark Kraus (markekraus) force-pushed the macOsLibcurlFix branch from 65a4929 to a758be9 Compare December 5, 2017 12:27
@markekraus

Mark Kraus (markekraus) commented Dec 5, 2017

Copy link
Copy Markdown
Contributor Author

yay.. all passed this time.

So.. the question is where do I document this at? in the web cmdlets documentations? somewhere in this repo (install documentation)? both?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 5, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We need to document it in the web cmdlets help content, and point out what parameters are affected by this. docs/FAQ.md might also be a good place to keep this information.
markekraus reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Dec 5, 2017
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the macOsLibcurlFix branch from e232177 to bbbf5f8 Compare December 6, 2017 00:51
Mark Kraus (markekraus) added 3 commits December 5, 2017 16:53
@markekraus @daxian-dbw
[feature] Make Travis CI use libcurl+openssl
a4e4e6a
@markekraus @daxian-dbw
[feature] Update changelog
c88192e
@markekraus @daxian-dbw
[feature] Add GSSAPI to libcurl
3c9e098
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the macOsLibcurlFix branch from bbbf5f8 to 3c9e098 Compare December 6, 2017 00:53
TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 6, 2017
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about another issue this PR brings up, Please file an issue or submit a PR for this and link in this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread build.psm1

# Install patched version of curl
Start-NativeExecution { brew install curl --with-openssl } -IgnoreExitcode
Start-NativeExecution { brew install curl --with-openssl --with-gssapi } -IgnoreExitcode

@TravisEz13 Travis Plunk (TravisEz13) Dec 6, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the PowerShell brew recipe as well.
https://github.com/caskroom/homebrew-cask/blob/master/Casks/powershell.rb#L33

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 6, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to figure out what to do with the powershell package about this limitation on macOS.
CoreCLR has explicitly moved away from OpenSSL on mac, see this PR: dotnet/corefx#17011.
Please open an issue to track the macOS packaging about this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@markekraus Mark Kraus (markekraus) Dec 6, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened Homebrew/homebrew-cask#41673

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@markekraus Mark Kraus (markekraus) Dec 6, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5635

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread CHANGELOG.md
- Remove Pester as a module include with the PowerShell Packages.
In the future, you should be able to add it by running `Install-Module Pester`. (#5623, #5631)
- Make Travis CI use `libcurl+openssl` (#5629, @markekraus)
- Make Travis CI use `libcurl+openssl+gssapi` (#5629, @markekraus)

@TravisEz13 Travis Plunk (TravisEz13) Dec 6, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should only have one line for a single PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw Dongbo Wang (daxian-dbw) self-assigned this Dec 6, 2017
This was referenced Dec 6, 2017
Update powershell 6.0.0-rc Add GSSAPI support to caveat Homebrew/homebrew-cask#41673
Merged
macOS Packaging and libcurl+openssl+gssapi #5635
Closed
@daxian-dbw
[feature] Remove duplicate entry in ChangeLog.md
5f96cc6
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the macOsLibcurlFix branch from e6896f0 to 5f96cc6 Compare December 6, 2017 17:39
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 6, 2017

Copy link
Copy Markdown
Member

I didn't add the [feature] tag when resolving a conflict. Add the [feature] to trigger full test run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit ee7fbed into PowerShell:master Dec 6, 2017
@daxian-dbw Dongbo Wang (daxian-dbw) changed the title Make Travis CI use libcurl+openssl+gssapi Make Travis CI use libcurl+openssl+gssapi for macOS Dec 6, 2017
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 7, 2017
@markekraus @TravisEz13
Make Travis CI use libcurl+openssl+gssapi for macOS (PowerShell#5629)
171ee52
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Dec 7, 2017
Move 6.0.0 rc.2 changes #5646
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Dec 7, 2017
@markekraus @TravisEz13
Make Travis CI use libcurl+openssl+gssapi for macOS (#5629)
721d3e9
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.0.0-RC.2 milestone Dec 8, 2017
@markekraus
Mark Kraus (markekraus) deleted the macOsLibcurlFix branch January 19, 2018 19:00
@joeyaiello Joey Aiello (joeyaiello) mentioned this pull request Oct 15, 2018
Docs needed for 'Make Travis CI use libcurl+openssl+gssapi for macOS' MicrosoftDocs/PowerShell-Docs#3059
Closed
@joeyaiello Joey Aiello (joeyaiello) removed the Documentation Needed in this repo Documentation is needed in this repo label Oct 15, 2018
@joeyaiello Joey Aiello (joeyaiello) removed the Documentation Needed in this repo Documentation is needed in this repo label Oct 15, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@markekraus @daxian-dbw
Make Travis CI use libcurl+openssl+gssapi for macOS (PowerShell#5629)
2341f39
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@markekraus @TravisEz13
Make Travis CI use libcurl+openssl+gssapi for macOS (PowerShell#5629)
cdb7a7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

6.0.0-RC.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markekraus @daxian-dbw @TravisEz13 @joeyaiello
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.