GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WIP: Add VSTS daily and feature tag support by TravisEz13 · Pull Request #7658 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Aug 29, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Add VSTS daily and feature tag support

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga), Dan Travison (dantraMSFT) and Dongbo Wang (daxian-dbw) as code owners August 29, 2018 21:24
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 29, 2018
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the add_daily_builds branch 7 times, most recently from 1a7a660 to 744a301 Compare August 31, 2018 20:44
@TravisEz13 Travis Plunk (TravisEz13) changed the title Add VSTS daily and feature tag support WIP: Add VSTS daily and feature tag support Aug 31, 2018
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Aug 31, 2018
Add daily build non-windows platforms #7683
Merged
7 of 11 tasks
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the add_daily_builds branch from 8c52ca2 to b23ec26 Compare September 7, 2018 17:03
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the add_daily_builds branch 2 times, most recently from d4c77d9 to 1659030 Compare September 14, 2018 23:35
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Sep 17, 2018
View reviewed changes
Comment thread build.psm1 Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Sep 17, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems not complete.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 17, 2018

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) mentioned running all tests for PRs. If we go with that, then we won't be needing the tags.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the add_daily_builds branch 6 times, most recently from 2c6cfc3 to 31debca Compare September 18, 2018 23:11
Travis Plunk (TravisEz13) added 5 commits September 18, 2018 16:16
@TravisEz13
Wait for package manager not to be locked
4f25c8f
@TravisEz13
[Feature] Add daily and feature tag support
eab772c
@TravisEz13
switch windows just to always run feature tests
bc5164d
@TravisEz13
Use helper function to set build variable
e8d4b57
@TravisEz13
Update release tag generation
c9df1c5 
update codecoverage artifact push
Travis Plunk (TravisEz13) added 11 commits September 18, 2018 16:42
@TravisEz13
[Feature] update windows VSTS to support [feature] tag
1ea009a
@TravisEz13
Add logging about why we are exiting unelevated logging loop
04df8a0 
remove code to wait on process
1. it was causing issues
2. the calling code waits
shorten timeout
Add timeout when running as non-admin
Don't switch to non-admin user on AppVeyor
give everyone full access to the buffer file/folder
use non-admin user to run tests
Create non-admin user
@TravisEz13
complete comment
c62d245
@TravisEz13
fix build issues
eab1c87
@TravisEz13
fix typo in creating releasetag
2745401
@TravisEz13
fix preReleaseVersion
0b5dd72
@TravisEz13
set permission on output file
0fdffd3
@TravisEz13
load environment in new process
0b64667
@TravisEz13
use arguments instead of argument list
1719c45
@TravisEz13
fix duplicate key issue
40c90fc
@TravisEz13
remove TMPDIR
86f0854
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the add_daily_builds branch from 31debca to 86f0854 Compare September 18, 2018 23:46
Travis Plunk (TravisEz13) added 11 commits September 18, 2018 17:07
@TravisEz13
fix typo
ea77a77
@TravisEz13
use NetCred to parse username
76436fc
@TravisEz13
give non-admin user permissions to TEMP
6a93fb8
@TravisEz13
set correct temp path
5f971df
@TravisEz13
create temp and appdata folders for non-admin
8c40acf
@TravisEz13
Capture test stack trace
8803e04
@TravisEz13
fix typo
f9d5b75
@TravisEz13
add instrumentation to debug
b74cd12
@TravisEz13
don't return the icacls results
a23645a
@TravisEz13
inherit permissions
3a2d20b
@TravisEz13
create a userprofile folder for non-admi
f6bfd8e
@stale

stale Bot commented Oct 19, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Oct 19, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 20, 2018

Copy link
Copy Markdown
Member Author

I will come back to this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot removed the Stale label Oct 20, 2018
@TravisEz13 Travis Plunk (TravisEz13) closed this Nov 13, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 13, 2018

Copy link
Copy Markdown
Member Author

This was merged as #8220 . Thank Paul Higinbotham (@PaulHigin)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) deleted the add_daily_builds branch November 13, 2018 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@dantraMSFT Dan Travison (dantraMSFT) Awaiting requested review from dantraMSFT

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @daxian-dbw @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.