GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix tests running in Azure DevOps by PaulHigin · Pull Request #8220 · PowerShell/PowerShell

Conversation

@PaulHigin

@PaulHigin Paul Higinbotham (PaulHigin) commented Nov 9, 2018

Copy link
Copy Markdown
Contributor

PR Summary

This change fixes tests that were failing when run in Azure DevOps. Most issues were due to the tests running as non-elevated, and the solution was to add the "RequireAdminOnWindows" tag.

This is especially true for remoting tests, where I updated the HelpersRemoting module to create a new remote session, runspace, or invoke-command against a PSCore6 (rather than WindowsPowerShell) endpoint. If the endpoint doesn't exist then it is created. Creating endpoints and connecting to endpoints require elevated privileges, so I made all remoting tests use the "RequireAdminOnWindows" tag.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Paul Higinbotham (PaulHigin) added 9 commits November 1, 2018 13:24
@PaulHigin
Added Travis FORCE_FEATURE for testing.
4baddc5
@PaulHigin
Updated remote helper to check for and create/enable remote endpoint
3d69488
@PaulHigin
Test changes to address failures
6a2cf73
@PaulHigin
Changes to failing tests
2b1be72
@PaulHigin
More changes
c64d8dd
@PaulHigin
Updated BuildID for DevOps
9daf323
@PaulHigin
re-added fix
69c4f5d
@PaulHigin
Fixed listener compare
5281e62
@PaulHigin
Removed verbose output
6ecdbf8
@PaulHigin
Paul Higinbotham (PaulHigin) requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan) November 9, 2018 17:32
@PaulHigin
Paul Higinbotham (PaulHigin) requested review from Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners November 9, 2018 17:32
@PaulHigin Paul Higinbotham (PaulHigin) assigned Travis Plunk (TravisEz13) Nov 9, 2018
@PaulHigin
Paul Higinbotham (PaulHigin) removed the request for review from Dongbo Wang (daxian-dbw) November 9, 2018 17:32
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Nov 9, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/Start-Process.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/engine/Remoting/ImplicitRemotingBatching.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/engine/Remoting/ImplicitRemotingBatching.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/engine/Remoting/ImplicitRemotingBatching.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/engine/ResourceValidation/TestRunner.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed Nov 9, 2018
View reviewed changes
Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan
Address code review comments
592e75f
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 9, 2018
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit d4bf5c8 into PowerShell:master Nov 9, 2018
@PaulHigin
Paul Higinbotham (PaulHigin) deleted the RemoteTestExperiments branch November 12, 2018 16:29
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Nov 13, 2018
WIP: Add VSTS daily and feature tag support #7658
Closed
7 of 11 tasks
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Nov 14, 2018
Publish test package to AppVeyor daily build #8273
Merged
7 of 11 tasks
@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 17, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@PaulHigin @adityapatwardhan
Fix tests running in Azure DevOps (PowerShell#8220)
dbb7ed6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@PaulHigin @adityapatwardhan @iSazonov @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.