GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add daily build non-windows platforms by TravisEz13 · Pull Request #7683 · PowerShell/PowerShell

Conversation

Travis Plunk (TravisEz13) commented Aug 31, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

PR Summary

Add daily build non-windows platforms

Also, make the [Feature] tag work in VSTS for non-windows
Also, add a way to force feature tests to run
Also, fix an issue where -workingdirectory didn't work when running async

Branched from #7658 as the windows CI is taking a long time to work out the test issues

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
- OR
- User-facing Documentation needed
  - Issue filed - Issue link:
Testing - New and feature
- Not Applicable or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga), Dan Travison (dantraMSFT) and Dongbo Wang (daxian-dbw) as code owners

August 31, 2018 23:45

Travis Plunk (TravisEz13) commented Sep 1, 2018

Copy link

Copy Markdown

Member Author

Linux build with FORCE_FEATURE=True https://powershell.visualstudio.com/PowerShell/_build/results?buildId=1245&view=logs

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) commented Sep 1, 2018

Copy link

Copy Markdown

Member Author

macos build with FORCE_FEATURE=True https://powershell.visualstudio.com/PowerShell/_build/results?buildId=1246

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) commented Sep 3, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Travis Plunk (@TravisEz13) Have you already considered running the tests with a bot like CoreFX team does? This is more convenient than add [Feature].

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Aditya Patwardhan (adityapatwardhan) requested changes

Sep 4, 2018

View reviewed changes

Comment thread

tools/travis.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 4, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the format should be yyyyMMddhhmm ss is for seconds.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tools/travis.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 4, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an comment about FORCE_FEATURE and FORCE_PACKAGE

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) requested a review from Bruce Payette (BrucePay) as a code owner

September 4, 2018 19:41

Travis Plunk (TravisEz13) force-pushed the add_daily_build_non_windows branch 4 times, most recently from 9afc198 to 0be0cd6 Compare

September 4, 2018 21:19

Travis Plunk (TravisEz13) added 9 commits

September 4, 2018 14:32


          [Feature] Add daily support

598f278


          use environment variables for mac and Linux to force feature and package

7275b5f


          Add comments per feedback

ee91c8c


          capture environment

bc000cf


          [Feature] make VSTS work with [Feature]

13cc43f


          remove as script uploads artifacts now

161a8e7


          update linux pool

2169db9


          [Feature] switch to production mac pool

dfda2c9


          [feature] use sudo for apt-get commands

0dcf406

Travis Plunk (TravisEz13) force-pushed the add_daily_build_non_windows branch 6 times, most recently from 975745d to 18cfb8f Compare

September 5, 2018 20:59

Travis Plunk (TravisEz13) changed the title ~~Add daily build non-windows platforms~~ WIP: Add daily build non-windows platforms

Sep 5, 2018

Travis Plunk (TravisEz13) force-pushed the add_daily_build_non_windows branch from 6ec80f5 to 2f72688 Compare

September 5, 2018 21:43

Travis Plunk (TravisEz13) added 4 commits

September 5, 2018 15:44


          [Feature] Workaround using no profile

6df1612


          run gem with sudo in VSTS

8f37617


          update test

a3acb45


          [Feature] Update ExecuteCommandAsyncHelper to actually execute comman…

aa6b242

…d when not reading input

Travis Plunk (TravisEz13) force-pushed the add_daily_build_non_windows branch from 2f72688 to aa6b242 Compare

September 5, 2018 22:45


          fix codefactor issues

d7109b4

Travis Plunk (TravisEz13) changed the title ~~WIP: Add daily build non-windows platforms~~ Add daily build non-windows platforms

Sep 6, 2018

Travis Plunk (TravisEz13) commented Sep 6, 2018

Copy link

Copy Markdown

Member Author

Aditya Patwardhan (@adityapatwardhan) your issues have been addressed as well as codefactor and the test issues

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Aditya Patwardhan (adityapatwardhan) requested changes

Sep 6, 2018

View reviewed changes

Comment thread

.vsts-ci/windows.yml Outdated

		- powershell: Write-Host "##vso[build.updatebuildnumber]$env:BUILD_SOURCEBRANCHNAME-$env:BUILD_SOURCEVERSION-$((get-date).ToString("yyyyMMddhhss"))"
		- powershell: \|
		Get-ChildItem -Path env:
		displayName: Capture envirenment

Aditya Patwardhan (adityapatwardhan) Sep 6, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo environment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

src/Microsoft.PowerShell.ConsoleHost/host/msh/Executor.cs Outdated

		@@ -194,6 +206,13 @@ internal void ExecuteCommandAsyncHelper(Pipeline tempPipeline, out Exception exc
		tempPipeline.Error.DataReady += new EventHandler(ErrorObjectStreamHandler);
		PipelineFinishedWaitHandle waiterThereIsAFlyInMySoup = new PipelineFinishedWaitHandle(tempPipeline);

Aditya Patwardhan (adityapatwardhan) Sep 6, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change name of the variable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tools/travis.ps1 Outdated

		# If the current job is a pull request, the env variable 'TRAVIS_PULL_REQUEST_SHA' contains
		# the commit SHA of the HEAD commit of the PR.
		$commitMessage = git log --format=%B -n 1 $commitId
		Write-Verbose "commitMessage: $commitMessage" -verbose

Aditya Patwardhan (adityapatwardhan) Sep 6, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Write-Log be used here instead?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tools/travis.ps1 Outdated

		# Run a full build if the build was trigger via cron, api or the commit message contains `[Feature]`
		$hasFeatureTag = $commitMessage -match '\[feature\]'
		$hasPackageTag = $commitMessage -match '\[package\]'
		# or the environment valiable `FORCE_FEATURE` equals `True`

Aditya Patwardhan (adityapatwardhan) Sep 6, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo variable

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Address PR comments

e9c57a3

Aditya Patwardhan (adityapatwardhan) approved these changes

Sep 6, 2018

View reviewed changes

Steve Lee (SteveL-MSFT) approved these changes

Sep 6, 2018

View reviewed changes

Travis Plunk (TravisEz13) merged commit 2141c2a into PowerShell:master

Sep 6, 2018

Travis Plunk (TravisEz13) deleted the add_daily_build_non_windows branch

September 6, 2018 19:27

Travis Plunk (TravisEz13) added a commit that referenced this pull request

Sep 7, 2018


          Add daily build non-windows platforms (#7683)

433a263

Add daily build non-windows platforms
  - Also, make the [Feature] tag work in VSTS for non-windows
  - Also, add a way to force feature tests to run
  - Also, fix an issue where `-workingdirectory` didn't work when running async

Travis Plunk (TravisEz13) added this to the v6.1.0 milestone

Sep 7, 2018

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Add daily build non-windows platforms (PowerShell#7683)

2edf4b3

Add daily build non-windows platforms
  - Also, make the [Feature] tag work in VSTS for non-windows
  - Also, add a way to force feature tests to run
  - Also, fix an issue where `-workingdirectory` didn't work when running async

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Add daily build non-windows platforms (PowerShell#7683)

da02b68

Add daily build non-windows platforms
  - Also, make the [Feature] tag work in VSTS for non-windows
  - Also, add a way to force feature tests to run
  - Also, fix an issue where `-workingdirectory` didn't work when running async

Reviewers

Steve Lee (SteveL-MSFT)

SteveL-MSFT approved these changes

Aditya Patwardhan (adityapatwardhan)

adityapatwardhan approved these changes

Andrew (anmenaga)

Awaiting requested review from anmenaga

Dan Travison (dantraMSFT)

Awaiting requested review from dantraMSFT

Dongbo Wang (daxian-dbw)

Awaiting requested review from daxian-dbw

Bruce Payette (BrucePay)

Awaiting requested review from BrucePay

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Travis Plunk (TravisEz13) commented Aug 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Travis Plunk (TravisEz13) commented Sep 1, 2018

Uh oh!

Travis Plunk (TravisEz13) commented Sep 1, 2018

Uh oh!

Ilya (iSazonov) commented Sep 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aditya Patwardhan (adityapatwardhan) Sep 4, 2018

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) Sep 4, 2018

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) commented Sep 6, 2018

Uh oh!

Aditya Patwardhan (adityapatwardhan) Sep 6, 2018

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) Sep 6, 2018

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) Sep 6, 2018

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) Sep 6, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Travis Plunk (TravisEz13) commented Aug 31, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) commented Sep 3, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.