GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — Remove use of cmdlet aliases from .\test\powershell by xtqqczze · Pull Request #8546 · PowerShell/PowerShell Conversation
|
|
xtqqczze Thanks for your contribution! We never used message suppressions and I would delete its. In the case we could fast merge. If you think that this could be useful please open new issue for discussion. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Remove PSAvoidUsingCmdletAliases message suppression.
|
xtqqczze Sorry, I meant that comments is not needed too. We don't have |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ilya (@iSazonov) When using vscode with the ms-vscode.powershell extension enabled, rule violations from PSScriptAnalyzer testing are listed as warnings in the 'Problems' pane, for example: Certain tests have comments explaining a rule should be ignored, because at the present time rules can only be suppressed on a file level for Pester tests. These comments help identify spurious warnings in the vscode 'Problems' pane and provide a placeholder for future implementation of rule suppression at a test level. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
xtqqczze I see your point. These comments is obvious and don't add value but reduce readability. Your proposal will be useful after we (1) get implementation of local suppressions and (2) force CIs. Today I suggest split replacing aliases and suppressing messages. For second work you could open a tracking issue if you want. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
xtqqczze Thanks for your contribution! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
* Avoid use of sleep alias (follow-up to PowerShell#8546) * Specify default parameter name * Shorten overly specific comments
* Avoid use of sleep alias (follow-up to #8546) * Specify default parameter name * Shorten overly specific comments
* Avoid use of sleep alias (follow-up to PowerShell#8546) * Specify default parameter name * Shorten overly specific comments
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.