GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revise use of Start-Sleep cmdlet by xtqqczze · Pull Request #8633 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jan 12, 2019

Copy link
Copy Markdown
Contributor

Revise use of Start-Sleep cmdlet.

PR Summary

  • Avoid use of sleep alias (follow-up to Remove use of cmdlet aliases from .\test\powershell #8546).
  • Specify default parameter name.
  • Shorten overly specific comments.

PR Context

Improve code clarity.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
xtqqczze requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 12, 2019 18:17
iSazonov
Ilya (iSazonov) approved these changes Jan 12, 2019
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jan 12, 2019
@iSazonov

Ilya (iSazonov) commented Jan 13, 2019

Copy link
Copy Markdown
Collaborator

xtqqczze Please rebase to get latest test updates and pass CIs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
xtqqczze force-pushed the start-sleep branch from 8227429 to aa1c6eb Compare January 13, 2019 22:56
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 14, 2019
View reviewed changes
@xtqqczze
[Feature] Revise use of Start-Sleep cmdlet
636c2e8 
* Avoid use of sleep alias (follow-up to PowerShell#8546)
* Specify default parameter name
* Shorten overly specific comments
@xtqqczze
xtqqczze force-pushed the start-sleep branch from aa1c6eb to 636c2e8 Compare January 14, 2019 19:24
@iSazonov

Ilya (iSazonov) commented Jan 15, 2019

Copy link
Copy Markdown
Collaborator

xtqqczze Please rebase to get new updates and pass CIs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) changed the title [PSStyle] Revise use of Start-Sleep cmdlet Revise use of Start-Sleep cmdlet Jan 15, 2019
@iSazonov Ilya (iSazonov) self-assigned this Jan 15, 2019
@xtqqczze
xtqqczze force-pushed the start-sleep branch from a231690 to 636c2e8 Compare January 15, 2019 03:58
@iSazonov
Ilya (iSazonov) merged commit 6126624 into PowerShell:master Jan 15, 2019
@xtqqczze
xtqqczze deleted the start-sleep branch January 18, 2019 23:32
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze @iSazonov
Revise use of Start-Sleep cmdlet (PowerShell#8633)
b7f086f 
* Avoid use of sleep alias (follow-up to PowerShell#8546)
* Specify default parameter name
* Shorten overly specific comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.