GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix cleanup config files by iSazonov · Pull Request #8761 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Jan 28, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Related #8715.

Add attempts to delete configuration files.

PR Context

There sometimes is a race condition in xUnit tests - powershell.config.json file is blocked in one process and another process tries to remove the file.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Fix cleanup config files
dc13142
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT), Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) January 28, 2019 04:47
RDIL
Reece Dunham (RDIL) approved these changes Jan 28, 2019
View reviewed changes
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jan 28, 2019
View reviewed changes
Comment thread test/xUnit/csharp/test_PSConfiguration.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/xUnit/csharp/test_PSConfiguration.cs Outdated
{
File.Delete(systemWideConfigFile);
}
var count = 10;

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jan 28, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxPause is better than count

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jan 28, 2019

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Address comments
80c5cd2
@iSazonov

Ilya (iSazonov) commented Jan 29, 2019

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) Please update your review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Aditya Patwardhan (adityapatwardhan) Jan 29, 2019
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jan 29, 2019
View reviewed changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) mentioned this pull request Jan 29, 2019
WIP Use early preview of .Net Core 3.0 #8370
Merged
3 of 11 tasks
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 29, 2019
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 5097e2a into PowerShell:master Jan 30, 2019
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 30, 2019
@iSazonov
Ilya (iSazonov) deleted the xunit-deletefile branch January 30, 2019 04:02
@iSazonov Ilya (iSazonov) mentioned this pull request Jan 30, 2019
The TestRunspaceWithPowerShellAndInitialSessionState intermittently fails (about 9%) #8784
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @adityapatwardhan
Fix cleanup config files for the csharp xUnit tests (PowerShell#8761)
7e49b3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@RDIL Reece Dunham (RDIL) RDIL approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iSazonov @SteveL-MSFT @adityapatwardhan @RDIL
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.