GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make linux CI parallel by TravisEz13 · Pull Request #9209 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Mar 23, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Make the Linux CI build once and then run the tests on 4 different machines, by tag.

PR Context

Running in parallel allows us to run all tests in about the same amount of clock time

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) added 2 commits March 22, 2019 17:51
@TravisEz13
disable mac debug
4fcf478
@TravisEz13
make linux parallel
a2e8b19
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the make_linux_CI_parallel branch from 788183a to a2e8b19 Compare March 23, 2019 00:56
@TravisEz13
fix test job names
bb3143d
@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review March 23, 2019 01:31
@TravisEz13
Travis Plunk (TravisEz13) requested review from Paul Higinbotham (PaulHigin), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners March 23, 2019 01:31
@TravisEz13
remove debug from linux
de64d32
@TravisEz13 Travis Plunk (TravisEz13) changed the title Make linux ci parallel Make linux CI parallel Mar 23, 2019
@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 23, 2019
@iSazonov

Ilya (iSazonov) commented Mar 23, 2019

Copy link
Copy Markdown
Collaborator

Looks great!

Unelevated tests on all platforms take about 13-14 minutes. Can we split them and run on 2-3 VMs?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Mar 23, 2019
View reviewed changes
RDIL
Reece Dunham (RDIL) approved these changes Mar 23, 2019
View reviewed changes

@RDIL Reece Dunham (RDIL) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I agree with Ilya, the unelevated pspester tests would be better off on different VMs for speed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13

Travis Plunk (TravisEz13) commented Mar 23, 2019

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) We can split them up by folder or another tag. Folder would be easier.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Mar 23, 2019

Copy link
Copy Markdown
Member Author

We also need to remove the [feature] tag code. It causes problems and isn't needed after this PR. I'll do it in another PR...
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Mar 23, 2019

Copy link
Copy Markdown
Contributor

Travis Plunk (@TravisEz13) I’ll take care of it after this is merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Mar 23, 2019

Copy link
Copy Markdown
Collaborator

Folder would be easier.

It seems we need to put the list in a config file to load-balance VMs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Mar 23, 2019

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) That might work... the script would need to see if any folders had been added and run those on some machine designated as a primary machine
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Mar 23, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Interesting, can these machines interact so as to receive a test batch from a controller VM and return a report? This would solve the load-balancing problem. And we could use this for remoting tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL Reece Dunham (RDIL) mentioned this pull request Mar 23, 2019
Remove code from CI.psm1 to optionally run Feature tests #9212
Merged
7 of 10 tasks
@TravisEz13

Travis Plunk (TravisEz13) commented Mar 23, 2019

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) Interactions between the machines may work sometimes but not consistently. The machines are only given private IP Addresses and are not guaranteed to be on the same subnet. I don't think we need that complexity. It's not needed to create a solution. The added complexity would add failure cases.

A simpler solution does mean that we would need to manually rebalance occasionally, but I don't think that is a problem.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Mar 23, 2019

Copy link
Copy Markdown
Member

Come on PoshChan-Bot (@PoshChan) you are nitpicking the letter case 😆
vexx32 and RDIL reacted with laugh emoji
All reactions
  • 😄 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Mar 23, 2019

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) Please remind me in 3 hours
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PoshChan

PoshChan-Bot (PoshChan) commented Mar 23, 2019

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13), all requests start with the magic word Please.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PowerShell PowerShell Team (PowerShell) deleted a comment from PoshChan-Bot (PoshChan) Mar 23, 2019
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.2.0-GA-Consider milestone Mar 24, 2019
@TravisEz13
Travis Plunk (TravisEz13) merged commit 5aed18d into PowerShell:master Mar 24, 2019
@TravisEz13
Travis Plunk (TravisEz13) deleted the make_linux_CI_parallel branch March 24, 2019 01:23
@ThreeFive-O ThreeFive-O mentioned this pull request Mar 24, 2019
Linux CI build does not fail when Pester Tag is missing #9193
Closed
Travis Plunk (TravisEz13) added a commit that referenced this pull request Mar 25, 2019
@TravisEz13
Make Linux CI parallel (#9209)
566f4da 
Make the Linux CI build once and then run the tests on 4 different machines, by tag.

## PR Context

Running in parallel allows us to run all tests in about the same amount of clock time
@TravisEz13 Travis Plunk (TravisEz13) modified the milestones: 6.2.0-GA-Consider, 6.2.0 Mar 25, 2019
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Apr 3, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Make Linux CI parallel (PowerShell#9209)
53a699e 
Make the Linux CI build once and then run the tests on 4 different machines, by tag.

## PR Context

Running in parallel allows us to run all tests in about the same amount of clock time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
+1 more reviewer
@RDIL Reece Dunham (RDIL) RDIL approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@TravisEz13 @iSazonov @RDIL @daxian-dbw @PoshChan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.