GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove polluting tests by youknowone · Pull Request #6733 · RustPython/RustPython

Conversation

@youknowone

@youknowone youknowone commented Jan 14, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated CI/CD pipeline configuration to optimize test environment handling.

✏️ Tip: You can customize this high-level summary in your review settings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@youknowone
remove polluting tests
9c0a9dd
@coderabbitai

coderabbitai Bot commented Jan 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This change removes two test entries from environment-polluting test lists in the CI workflow configuration. Specifically, multiprocessing fork server and spawn thread tests are removed from the Linux and macOS test pollution tracking environment variables.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
​.github/workflows/ci.yaml		 Removed test.test_multiprocessing_forkserver.test_threads from Linux environment-polluting tests and test.test_multiprocessing_spawn.test_threads from macOS environment-polluting tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Two threads hop away,
From the pollution list they'd stay,
Linux and macOS now fly free,
The CI pipeline's spree! ✨

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3890f9 and 9c0a9dd.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone marked this pull request as ready for review January 14, 2026 23:36
@youknowone
youknowone merged commit b214362 into main Jan 14, 2026
13 of 17 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone deleted the ci branch January 14, 2026 23:36
terryluan12 pushed a commit to terryluan12/RustPython that referenced this pull request Jan 15, 2026
@youknowone @terryluan12
remove polluting tests (RustPython#6733)
bf6340e
@fanninpm

fanninpm commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Please also remove the corresponding lines in the test files themselves.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coderabbitai coderabbitai Bot mentioned this pull request Jan 20, 2026
libregrtest from 3.14.2 #6818
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jan 31, 2026
Align del behavior #6772
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Feb 28, 2026
Cleanup ci.yaml matrix usage #7260
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@youknowone @fanninpm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.