GeezerVison

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

.github/workflows/ci.yaml (2)

300-303: Use matrix args here too to avoid drift.

Line 303 hardcodes -u all, while Line 310 already pulls from matrix.extra_test_args. Reusing matrix input here keeps a single source of truth.

♻️ Proposed change

-          target/release/rustpython -m test -j 1 -u all --slowest --fail-env-changed --timeout 600 -v ${{ env.PLATFORM_INDEPENDENT_TESTS }}
+          target/release/rustpython -m test -j 1 ${{ join(matrix.extra_test_args, ' ') }} --slowest --fail-env-changed --timeout 600 -v ${{ env.PLATFORM_INDEPENDENT_TESTS }}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yaml around lines 300 - 303, The workflow step "run
cpython platform-independent tests" uses a hardcoded "-u all" in the test
command; replace that hardcoded arg with the matrix variable already used
elsewhere (matrix.extra_test_args or env.PLATFORM_INDEPENDENT_TESTS) so the step
consumes the same single source of truth as the other test step—update the run
string that invokes "target/release/rustpython -m test ..." to include the
matrix.extra_test_args (or the existing PLATFORM_INDEPENDENT_TESTS env var)
instead of "-u all" and ensure the job matrix defines extra_test_args
consistently.

---

315-332: Skip env-polluter verification step when list is empty.

With current matrix values, this step is a no-op on every OS. Adding a step-level guard makes intent clearer and trims unnecessary CI work.

🧹 Proposed guard

       - name: run cpython tests to check if env polluters have stopped polluting
+        if: ${{ join(matrix.env_polluting_tests, '') != '' }}
         shell: bash
         run: |
           for thing in ${{ join(matrix.env_polluting_tests, ' ') }}; do

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yaml around lines 315 - 332, The CI step named "run
cpython tests to check if env polluters have stopped polluting" currently runs
even when matrix.env_polluting_tests is empty; add a step-level guard so the
step only runs when matrix.env_polluting_tests is non-empty (i.e., check
matrix.env_polluting_tests before executing the for-loop), thereby skipping the
whole step when there are no env polluters to verify.