GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — replace auto commit to format suggestion by youknowone · Pull Request #7375 · RustPython/RustPython

Conversation

@youknowone

@youknowone youknowone commented Mar 7, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

fix #7311

Summary by CodeRabbit

  • Chores
    • Updated pull request formatting workflow. Automatic formatting and commit functionality has been removed. Formatting validation is now performed without auto-applying changes to PRs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShaharNaveh reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@youknowone
replace auto commit to format suggestion
8e48008
@coderabbitai

coderabbitai Bot commented Mar 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9fe86054-7616-4cfa-bedf-8228f5c01b8f

📥 Commits

Reviewing files that changed from the base of the PR and between fc1c278 and 8e48008.

📒 Files selected for processing (2)
  • .github/workflows/pr-auto-commit.yaml
  • .github/workflows/pr-format.yaml
📝 Walkthrough

Walkthrough

Removed the vulnerable pr-auto-commit.yaml workflow that auto-committed formatting changes to PRs, replacing it with a new pr-format.yaml workflow that performs format checks and posts non-invasive formatting suggestions via reviewdog instead.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/pr-auto-commit.yaml, .github/workflows/pr-format.yaml		 Deleted vulnerable auto-commit workflow that directly interpolated branch names into shell commands. Added read-only format-check workflow using reviewdog to post inline formatting suggestions without committing to the PR branch.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Prevent shell injection #7310 — Modifies the same pr-auto-commit.yaml workflow to address HEAD ref handling concerns.
  • Ruff as part of PR auto-format #6421 — Updates GitHub Actions formatting workflows with Ruff integration changes.
  • Update CI auto-formate #6237 — Removes the pr-auto-commit auto-commit workflow and replaces it with a format-check workflow approach.

Suggested reviewers

  • ShaharNaveh

Poem

🐰 A workflow once pushed with secrets so near,
Now safely suggests—without commit or fear!
Reviewdog whispers formatting advice,
No shell injections, no malicious splice,
The rabbit hops on, the pipeline is bright! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone marked this pull request as ready for review March 7, 2026 05:52
@youknowone
youknowone enabled auto-merge (squash) March 7, 2026 05:52
@youknowone
youknowone disabled auto-merge March 7, 2026 05:53
@youknowone
youknowone merged commit ed5bffe into RustPython:main Mar 7, 2026
11 of 14 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone deleted the workflow branch March 7, 2026 05:53
youknowone added a commit to youknowone/RustPython that referenced this pull request Mar 8, 2026
@youknowone
replace auto commit to format suggestion (RustPython#7375)
b2b7d31
This was referenced Mar 12, 2026
Fix pr-format CI to fail on formatting changes #7411
Merged
Add zizmor CI #7463
Merged
Add actionlint step #7464
Merged
youknowone added a commit to youknowone/RustPython that referenced this pull request Mar 22, 2026
@youknowone
replace auto commit to format suggestion (RustPython#7375)
f0bf9f5
This was referenced Mar 22, 2026
Bytecode parity #7475
Merged
Pin setup-python action to a commit hash - part 2 #7493
Closed
youknowone added a commit that referenced this pull request Sep 16, 2026
@youknowone
replace auto commit to format suggestion (#7375)
2bdc231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Security: Branch name injection in pr-auto-commit.yaml — actively exploited by hackerbot-claw

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.