GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Pin `setup-python` action to a commit hash - part 2 by ShaharNaveh · Pull Request #7493 · RustPython/RustPython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Mar 24, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

extracted from #7491
Probably blocked until #7483 is merged

Summary by CodeRabbit

  • Chores
    • Pinned CI action references to exact commits in several workflow jobs to improve build stability and reproducibility.
    • Minor workflow formatting cleanup (added spacing) to improve readability of CI configuration.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coderabbitai

coderabbitai Bot commented Mar 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 2a702950-9b2d-4cce-9b03-4daf10990582

📥 Commits

Reviewing files that changed from the base of the PR and between d3f062e and 4f5dd83.

📒 Files selected for processing (1)
  • .github/workflows/cron-ci.yaml
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/cron-ci.yaml
📝 Walkthrough

Walkthrough

Pinned actions/setup-python to a specific commit SHA in multiple cron CI jobs and added blank-line formatting around those steps in the workflow YAML. No other workflow logic or step inputs were changed.

Changes

Cohort / File(s) Summary
Workflow Configuration
​.github/workflows/cron-ci.yaml		 Updated actions/setup-python ref from v6.2.0 to commit a309ff8b426b58ec0e2a45f0f869d46889d02405 (annotated # v6.2.0) in the codecov, whatsleft, and benchmark jobs; added surrounding blank lines for readability. No other inputs, commands, or job flow altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Cleanup release.yml a bit #7499 — pins third-party GitHub Actions to commit SHAs in workflow files (related pattern).
  • Pin setup-python action to a commit hash - part 3 #7494 — pins actions/setup-python to the same commit SHA in another workflow file.
  • Pin setup-python action to a commit hash - part 1 #7492 — applies the identical actions/setup-python SHA pin in a workflow YAML.

Suggested labels

skip:ci

Suggested reviewers

  • youknowone
  • fanninpm
  • coolreader18

Poem

🐇 I hop through YAML, tidy and spry,
Pinning a hash so actions don't fly,
Blank lines tucked neat, each step in its place,
Cron hums along at a calm, steady pace.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: pinning the setup-python action to a commit hash in the cron-ci workflow, which is part 2 of this work.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShaharNaveh
Pin setup-python action to a commit hash
0f28aae
@ShaharNaveh
ShaharNaveh force-pushed the setup-python-pin-2 branch from ae37379 to 0f28aae Compare March 24, 2026 01:00
coderabbitai[bot]
coderabbitai Bot reviewed Mar 24, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/cron-ci.yaml:
- Around line 53-54: The YAML uses a block scalar for the codecov action's files
input which v5 expects as a comma-separated string; update the `files` input for
the Codecov step (the `files` key used with the codecov action invocation) to a
single-line, comma-separated value (e.g., "path/to/file1, path/to/file2")
instead of the multi-line block scalar so the action parses it correctly.
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 2292b149-9795-47ff-b60e-505240d7053d

📥 Commits

Reviewing files that changed from the base of the PR and between 8c01615 and ae37379.

📒 Files selected for processing (2)
  • .github/workflows/cron-ci.yaml
  • .github/workflows/pr-format.yaml

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/cron-ci.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ShaharNaveh
Fix param
d3f062e
@ShaharNaveh ShaharNaveh changed the title Pin setup-python action to a commit hash - part 2 Pin setup-python action to a commit hash - part 2 Mar 24, 2026
youknowone
youknowone approved these changes Mar 25, 2026
View reviewed changes
@youknowone

youknowone commented Mar 25, 2026

Copy link
Copy Markdown
Member

oh, please chcek the action lint
ShaharNaveh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShaharNaveh added 2 commits March 25, 2026 07:46
@ShaharNaveh
Merge remote-tracking branch 'upstream/main' into setup-python-pin-2
2afe19a
@ShaharNaveh
Merge remote-tracking branch 'upstream/main' into setup-python-pin-2
4f5dd83
@ShaharNaveh

ShaharNaveh commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

@youknowone the errors here aren't related to the changes, can we merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShaharNaveh

ShaharNaveh commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

closed by #7571
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShaharNaveh ShaharNaveh closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ShaharNaveh @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.