GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Unified action for installing Linux deps by ShaharNaveh · Pull Request #7381 · RustPython/RustPython

Conversation

ShaharNaveh commented Mar 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Followup on #7379

Summary by CodeRabbit

Chores
- Centralized Linux build dependency installation in CI into a reusable composite action, replacing inline apt-get steps across jobs.
- Jobs can now request specific toolsets (multilib, musl, cross‑compiler, clang) via flags, enabling conditional package installation per job and reducing duplication.
- Minor CI formatting tweak with no functional impact.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ShaharNaveh added 2 commits

March 7, 2026 13:39


          Use new action

83532bf


          Fix name

5f4e4a2

coderabbitai Bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 221eabc0-0af7-4a9f-b3c6-8ac106138e87

📥 Commits

Reviewing files that changed from the base of the PR and between 7bb83b0 and 11f1af7.

📒 Files selected for processing (1)

.github/actions/install-linux-deps/action.yml

🚧 Files skipped from review as they are similar to previous changes (1)

.github/actions/install-linux-deps/action.yml

📝 Walkthrough

Walkthrough

Adds a new composite GitHub Action at .github/actions/install-linux-deps/action.yml to conditionally install Linux packages via boolean inputs, and refactors .github/workflows/ci.yaml to replace inline apt-get installs with calls to that action in relevant CI jobs.

Changes

Cohort / File(s)	Summary
New composite action `.github/actions/install-linux-deps/action.yml`	Adds a composite GitHub Action exposing boolean inputs (`gcc-multilib`, `musl-tools`, `gcc-aarch64-linux-gnu`, `clang`) and a shell step that conditionally constructs an apt-get package list and runs `sudo apt-get update` + `sudo apt-get install --no-install-recommends` when inputs are true.
CI workflow updates `.github/workflows/ci.yaml`	Replaces inline `sudo apt-get` update/install steps with `uses: ./.github/actions/install-linux-deps` invocations in multiple jobs (x86 32bit, aarch64, wasm-wasi), passing feature flags; minor whitespace adjustment near Wasmer setup.

Sequence Diagram(s)

sequenceDiagram
  participant Workflow as "CI Workflow Job"
  participant Action as "install-linux-deps Action"
  participant Runner as "Runner / Shell"
  participant Apt as "apt-get (system)"

  Workflow->>Action: uses ./.github/actions/install-linux-deps with flags
  Action->>Runner: execute composite shell step
  Runner->>Apt: sudo apt-get update
  Runner->>Apt: sudo apt-get install --no-install-recommends <conditional pkgs>
  Apt-->>Runner: packages installed
  Runner-->>Action: step completes
  Action-->>Workflow: action finished

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

youknowone

Poem

🐰 I tumbled through CI with a twitchy nose,

One tiny action where the package list grows.
Flags like little carrots, picked when they're due,
Now installs are tidy — compact and true. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Unified action for installing Linux deps' directly and clearly summarizes the main change: creating a centralized GitHub Action to consolidate Linux dependency installation across multiple CI jobs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot reviewed

Mar 7, 2026

View reviewed changes

coderabbitai Bot left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yaml:
- Around line 219-224: The workflow references the wrong local action path
"./.github/actions/install-linux/deps" which will fail; update all occurrences
of that uses: string (the three places in the file) to point to the actual
action directory name "./.github/actions/install-linux-deps" (matching the
folder/action.yml file), i.e., replace the hyphen-mismatched path used in the
steps that install gcc-multilib and musl-tools so GitHub Actions can locate the
action.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: fc4c84d1-9de0-4359-9b6c-9c5b1fbf2d9e

📥 Commits

Reviewing files that changed from the base of the PR and between f680f8a and 5f4e4a2.

📒 Files selected for processing (2)

.github/actions/install-linux-deps/action.yml
.github/workflows/ci.yaml

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

.github/workflows/ci.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

ShaharNaveh added 2 commits

March 7, 2026 13:57


          Use correct path

7bb83b0


          Install recommends

11f1af7

youknowone approved these changes

Mar 8, 2026

View reviewed changes

youknowone merged commit e669944 into RustPython:main

Mar 8, 2026

11 of 13 checks passed

Uh oh!

There was an error while loading. Please reload this page.

youknowone pushed a commit to youknowone/RustPython that referenced this pull request

Mar 8, 2026


          Unified action for installing Linux deps (RustPython#7381)

b03602c

coderabbitai Bot mentioned this pull request

Mar 9, 2026

Use matrix for cargo check #7388

Merged

youknowone pushed a commit to youknowone/RustPython that referenced this pull request

Mar 22, 2026


          Unified action for installing Linux deps (RustPython#7381)

2e28067

coderabbitai Bot mentioned this pull request

Mar 22, 2026

Bytecode parity #7475

Merged

youknowone pushed a commit that referenced this pull request

Sep 16, 2026


          Unified action for installing Linux deps (#7381)

ea8bf5d

Reviewers

coderabbitai[bot]

coderabbitai[bot] left review comments

youknowone

youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ShaharNaveh commented Mar 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShaharNaveh commented Mar 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.