GeezerVison

.github/workflows/ci.yaml (1)

227-229: ⚠️ Potential issue | 🔴 Critical

Fix the Install dependencies step shape and scope.

Line 229 is invalid GitHub Actions syntax: with: must be a mapping, so this job will not pass workflow validation. Even after that is fixed, this step still runs for the macos-latest row even though it invokes the Linux-only install-linux-deps action.

One working shape

       matrix:
         include:
         - os: ubuntu-latest
           targets:
             - aarch64-linux-android
             - i686-unknown-linux-gnu
             - i686-unknown-linux-musl
             - wasm32-wasip2
             - x86_64-unknown-freebsd
-          dependencies:
-            gcc-multilib: true
-            musl-tools: true
+          gcc_multilib: true
+          musl_tools: true
         - os: ubuntu-latest
           targets:
             - aarch64-unknown-linux-gnu
-          dependencies:
-            gcc-aarch64-linux-gnu: true # conflict with `gcc-multilib`
+          gcc_aarch64_linux_gnu: true # conflict with `gcc-multilib`
         - os: macos-latest
           targets:
             - aarch64-apple-ios
             - x86_64-apple-darwin
...
       - name: Install dependencies
+        if: runner.os == 'Linux'
         uses: ./.github/actions/install-linux-deps
-        with: ${{ matrix.dependencies || fromJSON('{}') }}
+        with:
+          gcc-multilib: ${{ matrix.gcc_multilib || false }}
+          musl-tools: ${{ matrix.musl_tools || false }}
+          clang: ${{ matrix.clang || false }}
+          gcc-aarch64-linux-gnu: ${{ matrix.gcc_aarch64_linux_gnu || false }}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yaml around lines 227 - 229, The "Install dependencies"
step uses invalid YAML for the with: field and also unconditionally invokes the
Linux-only action ./.github/actions/install-linux-deps for non-Linux matrix
rows; change the step to provide a proper mapping for the inputs (e.g., a key
like dependencies mapped to the expression using matrix.dependencies) and add a
conditional that restricts the step to Linux matrix entries (use matrix.os in
the if: expression) so the step only runs for Linux jobs and the with: block is
valid.

.github/workflows/ci.yaml (1)

227-229: ⚠️ Potential issue | 🔴 Critical

Schema violation: with: requires a mapping, not a scalar expression.

The syntax with: ${{ matrix.dependencies || fromJSON('{}') }} is invalid. GitHub Actions expects with: to contain an explicit mapping of input names to values. Additionally, this step will run on macOS where install-linux-deps is not applicable.

The fix proposed in the previous review remains valid—flatten the dependency flags to top-level matrix properties and bind them explicitly with an OS condition.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yaml around lines 227 - 229, The CI step "Install
dependencies" uses an invalid scalar for with: and is not guarded by OS; change
the step to pass a mapping (e.g. with: dependencies: ${{ matrix.dependencies }}
) and add an OS guard (if: runner.os == 'Linux') so the local action
./.github/actions/install-linux-deps only runs on Linux; also ensure your matrix
defines the top-level property matrix.dependencies (use fromJSON default when
building the matrix if needed) so the referenced matrix key exists.