GeezerVison is showing github.com — fix cron-ci by youknowone · Pull Request #7483 · RustPython/RustPython
Conversation
youknowone
commented
Mar 23, 2026
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit
-
Chores
- Updated CI workflow configuration to enable additional Rust compilation features and improve build coverage reporting.
- Enhanced shell script command handling in CI pipelines for safer filename processing.
-
Tests
- Improved test runner robustness with better error handling for edge cases.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coderabbitai
Bot
commented
Mar 23, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Caution
Review failed
The pull request is closed.
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 6401fa58-a631-4345-902e-360a0a2db154
📥 Commits
Reviewing files that changed from the base of the PR and between 4107217 and 36d9705.
📒 Files selected for processing (2)
.github/workflows/cron-ci.yamlextra_tests/custom_text_test_runner.py
📝 Walkthrough
Walkthrough
CI workflow updates Rust feature flags (stdio, host_env) and improves shell command safety with null-delimiter handling. Test runner refactors method dict access into a helper function and makes module field extraction more robust with fallback logic.
Changes
| Cohort / File(s) |
Summary |
CI Workflow Configuration
.github/workflows/cron-ci.yaml |
Updated CARGO_ARGS to include stdio and host_env features; modified cargo llvm-cov command to match; changed Codecov action input parameter from file: to files:; reworked shell commands in benchmark job to use find -print0 with xargs -0 for safer filename handling. |
Test Runner Refactoring
extra_tests/custom_text_test_runner.py |
Added _get_method_dict(test) helper to centralize retrieval of test method's underlying function __dict__, reducing repeated attribute access; made suite "module" field extraction more robust with conditional regex matching that falls back to str(test) if regex fails. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Suggested reviewers
Poem
🐰 Hop, skip, and a leap,
Features added, nice and deep,
Safer paths with null delimiters true,
Helper functions make code new,
CI workflows bloom in morning dew!
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
youknowone
added a commit
that referenced
this pull request
Sep 16, 2026
* fix cron-ci
* fix custom_text_test_runner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.