GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Pin `setup-python` action to a commit hash - part 0 by ShaharNaveh · Pull Request #7491 · RustPython/RustPython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Mar 24, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated GitHub Actions workflow for dependency checking to improve output handling and validation logic.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coderabbitai

coderabbitai Bot commented Mar 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 1f25e9f4-6cf4-4179-a216-4057beee3b32

📥 Commits

Reviewing files that changed from the base of the PR and between 464b6bc and 85cca4d.

📒 Files selected for processing (1)
  • .github/workflows/lib-deps-check.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/lib-deps-check.yaml
📝 Walkthrough

Walkthrough

The workflow pins the actions/setup-python action to a specific commit SHA and refactors the dependency check step to capture command output directly into a shell variable, then write it to $GITHUB_OUTPUT using a heredoc. The "Post comment" step's condition is updated to check the output variable directly instead of a separate boolean flag.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/lib-deps-check.yaml		 Pinned actions/setup-python to commit SHA, refactored output capture mechanism from temporary file to shell variable with heredoc writing, and updated post-comment gating condition to check deps_output variable directly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Output flows in variable streams,
No temp files cluttering our dreams,
A cleaner path, direct and true,
The workflow hops to something new!
Heredoc writes with graceful ease, ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Pin setup-python action to a commit hash - part 0' accurately reflects the main change: pinning the actions/setup-python dependency to a specific commit SHA instead of a version tag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 24, 2026
View reviewed changes
Comment thread .github/workflows/lib-deps-check.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 24, 2026
View reviewed changes
Comment thread .github/workflows/lib-deps-check.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 24, 2026
Pin setup-python action to a commit hash - part 1 #7492
Merged
Pin setup-python action to a commit hash - part 2 #7493
Closed
Pin setup-python action to a commit hash - part 3 #7494
Merged
@ShaharNaveh
Pin setup-python action to a commit hash
85cca4d
@ShaharNaveh
ShaharNaveh force-pushed the setup-python-pin branch from 464b6bc to 85cca4d Compare March 24, 2026 01:05
@ShaharNaveh ShaharNaveh changed the title Pin setup-python action to a commit hash Pin setup-python action to a commit hash - part 0 Mar 24, 2026
youknowone
youknowone approved these changes Mar 24, 2026
View reviewed changes
@youknowone
youknowone merged commit 56c3a37 into RustPython:main Mar 24, 2026
18 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Copilot AI pushed a commit that referenced this pull request Mar 25, 2026
@ShaharNaveh
Pin setup-python action to a commit hash (#7491)
32b8af3
@ShaharNaveh ShaharNaveh mentioned this pull request Apr 9, 2026
Update some libs and tests from 3.14.3 to 3.14.4 #7576
Merged
youknowone pushed a commit that referenced this pull request Sep 16, 2026
@ShaharNaveh
Pin setup-python action to a commit hash (#7491)
c0f7c3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ShaharNaveh @youknowone @github-advanced-security
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.