GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Pin `rust-toolchain` action to a commit hash - part 1 by ShaharNaveh · Pull Request #7500 · RustPython/RustPython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Mar 24, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated CI workflow configuration for improved build consistency and reliability.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 24, 2026
View reviewed changes
Comment thread .github/workflows/ci.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/ci.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/ci.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/ci.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/ci.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/ci.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/ci.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.
@coderabbitai

coderabbitai Bot commented Mar 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ab45d1cb-d79d-4493-ad67-23da5e7051d7

📥 Commits

Reviewing files that changed from the base of the PR and between 82432be and 980e36b.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
📝 Walkthrough

Walkthrough

Updated GitHub Actions CI workflow to pin the dtolnay/rust-toolchain action to a specific commit hash instead of floating tags, and added explicit toolchain: stable parameters to relevant jobs. The miri job retains its dynamic nightly channel configuration.

Changes

Cohort / File(s) Summary
CI Toolchain Pinning
.github/workflows/ci.yaml		 Pinned dtolnay/rust-toolchain action to commit efa25f7f19611383d5b0ccf2d1c8914531636bf9 across multiple jobs. Added explicit with: toolchain: stable inputs to clippy and wasm/stable check jobs. Miri job updated to use pinned action commit while preserving toolchain: ${{ env.NIGHTLY_CHANNEL }} dynamic selection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Pin rustc nightly to nightly-2025-07-18 for miri tests #5999: Modifies miri job's Rust toolchain configuration in the same CI workflow, with the retrieved PR pinning miri to a specific nightly version.
  • Unpin Rust nightly in CI #6022: Updates the same CI workflow with changes to the miri job's toolchain handling using the NIGHTLY_CHANNEL variable.

Suggested reviewers

  • youknowone

Poem

🐰 A rabbit pins down the toolchain's spring,
No more shall versions dance and fling!
Stable, locked, and miri bright,
CI workflows flow just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: pinning the rust-toolchain action to a commit hash rather than using floating tags.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShaharNaveh
Pin rust-toolchain action to a commit hash
980e36b
@ShaharNaveh
ShaharNaveh force-pushed the rust-toolchain-pin-hash-0 branch from 899b2de to 980e36b Compare March 24, 2026 12:53
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 24, 2026
View reviewed changes
Comment thread .github/workflows/ci.yaml
persist-credentials: false

- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
Comment thread .github/workflows/ci.yaml
gcc-aarch64-linux-gnu: ${{ matrix.dependencies.gcc-aarch64-linux-gnu || false }}

- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
Comment thread .github/workflows/ci.yaml
persist-credentials: false

- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
Comment thread .github/workflows/ci.yaml
@@ -413,7 +418,9 @@ jobs:

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
Comment thread .github/workflows/ci.yaml
@@ -485,9 +492,10 @@ jobs:
with:

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
Comment thread .github/workflows/ci.yaml
target: wasm32-wasip1
toolchain: stable

- uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
Comment thread .github/workflows/ci.yaml Outdated

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
youknowone
youknowone approved these changes Mar 25, 2026
View reviewed changes
@youknowone
youknowone merged commit 6db7910 into RustPython:main Mar 25, 2026
18 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Copilot AI pushed a commit that referenced this pull request Mar 25, 2026
@ShaharNaveh
Pin rust-toolchain action to a commit hash (#7500)
1825015
This was referenced Mar 30, 2026
Fix lint warnings in release.yml #7538
Merged
[zizmor] ignore superfluous-actions #7548
Merged
youknowone pushed a commit that referenced this pull request Sep 16, 2026
@ShaharNaveh
Pin rust-toolchain action to a commit hash (#7500)
5d03f11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ShaharNaveh @youknowone @github-advanced-security
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.