GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix lint warnings in `release.yml` by ShaharNaveh · Pull Request #7538 · RustPython/RustPython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Mar 30, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration: removed a workflow-level write permission and pinned several build/deploy actions to fixed revisions while preserving existing build targets and deploy behavior.
    • Formatting of one action's inputs adjusted for clarity.
    • No user-visible changes or functional impact to the product.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coderabbitai

coderabbitai Bot commented Mar 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 3dd4efab-c650-4100-9a98-f1e1a0b71cd7

📥 Commits

Reviewing files that changed from the base of the PR and between bb54085 and f80f93e.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/release.yml
📝 Walkthrough

Walkthrough

Pins GitHub Actions used in the release workflow to specific commit SHAs, removes the workflow-level contents: write permission, and converts the WABT action's with configuration from an inline mapping to a multi-line mapping while keeping the same version values.

Changes

Cohort / File(s) Summary
GitHub Actions workflow configuration
/.github/workflows/release.yml		 Removed workflow-level permissions: contents: write; pinned dtolnay/rust-toolchain@stable, mwilliamson/setup-wabt-action@v3, and peaceiris/actions-gh-pages@v4 to specific commit SHAs; changed with for WABT from inline to multi-line mapping (kept wabt-version: "1.0.30"); preserved deploy step inputs and conditions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Cleanup release.yml a bit #7499 — Also pins third-party GitHub Actions to specific commit SHAs in .github/workflows/release.yml.
  • Adjust permissions of update-doc-db job #7496 — Removes or tightens workflow-level contents: write permissions in workflow files.
  • Pin rust-toolchain action to a commit hash - part 1 #7500 — Pins dtolnay/rust-toolchain action to a specific commit SHA across workflows.

Suggested labels

skip:ci

Suggested reviewers

  • youknowone

Poem

🐰 I hopped through YAML lines tonight,

Pinned each action snug and tight,
Took away a write of old,
Kept the versions, neat and bold,
Builds will hum without a fright.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix lint warnings in release.yml' accurately describes the main change - pinning GitHub Actions to specific commit SHAs and adjusting configuration structure to resolve lint warnings in the release workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 30, 2026
View reviewed changes
Comment thread .github/workflows/release.yml
persist-credentials: false

- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
Comment thread .github/workflows/release.yml
persist-credentials: false

- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
@ShaharNaveh
Fix lint warnings in release.yml
f80f93e
@ShaharNaveh
ShaharNaveh force-pushed the ci-release-warnings branch from bb54085 to f80f93e Compare March 30, 2026 08:25
youknowone
youknowone approved these changes Mar 30, 2026
View reviewed changes
@youknowone
youknowone merged commit 9900c76 into RustPython:main Mar 30, 2026
15 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@coderabbitai coderabbitai Bot mentioned this pull request Mar 30, 2026
Resolve excessive-permissions warning in ci.yaml #7547
Merged
youknowone pushed a commit that referenced this pull request Sep 16, 2026
@ShaharNaveh
Fix lint warnings in release.yml (#7538)
d998b62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ShaharNaveh @youknowone @github-advanced-security
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.