GeezerVison is showing github.com — Resolve shellcheck warning on `ci.yaml` by ShaharNaveh · Pull Request #7501 · RustPython/RustPython
Conversation
ShaharNaveh
commented
Mar 24, 2026
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit
- Chores
- Improved CI reliability by making shell argument handling and exit-code checks more robust.
- Made test-loop invocation safer to ensure selected tests are respected and avoid shell-parsing issues.
- Ensured WASM test runner uses a quoted working directory to prevent path-related failures and improve cross-platform stability.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coderabbitai
Bot
commented
Mar 24, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
@coderabbitai resume to resume automatic reviews.@coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
- ▶️ Resume reviews
- 🔍 Trigger review
📝 Walkthrough
Walkthrough
CI workflow .github/workflows/ci.yaml updated for safer shell handling: quoted outputs and arguments, switched env-polluting-tests iteration to a line-based read loop, quote-wrapped numeric exit comparisons, and quoted $(pwd) for wasmer run --dir.
Changes
| Cohort / File(s) |
Summary |
CI workflow
./.github/workflows/ci.yaml |
Shell-hardening edits: append cores to "$GITHUB_OUTPUT"; build TESTS from matrix.env_polluting_tests and iterate with while IFS= read -r thing; do ... done <<< "$TESTS"; pass test entries as -v "${thing}"; use quoted numeric comparisons ("${exit_code}"); quote $(pwd) for wasmer run --dir in wasm-wasi steps. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
🐇 I hopped through YAML late at night,
Quoted each var to set things right.
Tests now read lines tidy and neat,
Wasmer finds home with quoted feet,
CI hums on—my whiskers bright.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name |
Status |
Explanation |
| Description Check |
✅ Passed |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check |
✅ Passed |
The title accurately describes the main change: resolving shellcheck warnings in the ci.yaml workflow file by improving shell quoting and variable handling. |
| Docstring Coverage |
✅ Passed |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.