GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CI: Don't skip windows tests by ShaharNaveh · Pull Request #8004 · RustPython/RustPython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Jun 1, 2026 •
edited by youknowone
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Closes Handle windows test proper way #3960
  • This PR follows our AI policy

Summary

Summary by CodeRabbit

  • Chores
    • Enhanced CI/CD testing configuration to enable additional Windows compatibility verification for CPython.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ShaharNaveh added 2 commits June 1, 2026 15:47
@ShaharNaveh
CI: Don't skip tests on windows
e237302
@ShaharNaveh
Mark failing tests
be5114b
@coderabbitai

coderabbitai Bot commented Jun 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Windows CPython test matrix configuration in the CI workflow is updated to remove previously skipped tests by clearing the skips list to an empty array. This enables all CPython tests to run on Windows without exclusions.

Changes

Windows CPython Test Skip Configuration

Layer / File(s) Summary
Windows CPython test skip removal
.github/workflows/ci.yaml		 The Windows snippets_cpython matrix entry replaces its populated skips list with an empty list, allowing all CPython tests to run without exclusions for that configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • youknowone
  • fanninpm
  • bschoenmaeckers

Poem

🐰 The Windows tests now run free,
No skips to hold them back, you see!
CPython tests, once left behind,
Now execute with unburdened mind.
Empty the list, let them all run—
CI's work on Windows, freshly begun!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'CI: Don't skip windows tests' directly matches the changeset, which removes skips from the Windows matrix entry in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/venv
[x] test: cpython/Lib/test/test_venv.py (TODO: 17)

dependencies:

  • venv

dependent tests: (1 tests)

  • venv: test_venv

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone enabled auto-merge (squash) June 1, 2026 15:36
youknowone
youknowone approved these changes Jun 1, 2026
View reviewed changes
@ShaharNaveh

ShaharNaveh commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@youknowone because it's waiting for the cached CI entry to complete it's not gonna be auto-merged:/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone disabled auto-merge June 2, 2026 06:40
@youknowone
youknowone merged commit 0c9ed36 into RustPython:main Jun 2, 2026
27 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@youknowone

youknowone commented Jun 2, 2026

Copy link
Copy Markdown
Member

Thanks, I have to remove the old one and add new one in settings whenever the CI task name is changed.
ShaharNaveh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fanninpm fanninpm mentioned this pull request Jun 2, 2026
Update random and cryptography crates #8010
Merged
1 of 2 tasks
JamesClarke7283 added a commit to JamesClarke7283/RustPython that referenced this pull request Jun 3, 2026
@JamesClarke7283 @claude
Merge branch 'main' into fix-7941-thread-stack-overflow
41b4f73 
Brings the branch up to date with main so CI job names match the
required status checks (the windows snippets/cpython job was renamed
by RustPython#8004 when its matrix skips were cleared). Also picks up RustPython#8018's
_thread.rs stack-margin updates, which are orthogonal to the
apply_thread_stack_size fix in this PR.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
@coderabbitai coderabbitai Bot mentioned this pull request Jun 19, 2026
Run windows tests with -u all #8134
Merged
2 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Jun 27, 2026
Set python args to be like CPython in CI #8181
Merged
2 tasks
youknowone pushed a commit that referenced this pull request Sep 16, 2026
@ShaharNaveh
CI: Don't skip windows tests (#8004)
d58fc9e
youknowone pushed a commit to JamesClarke7283/RustPython that referenced this pull request Sep 16, 2026
@JamesClarke7283 @claude
Merge branch 'main' into fix-7941-thread-stack-overflow
b9483d7 
Brings the branch up to date with main so CI job names match the
required status checks (the windows snippets/cpython job was renamed
by RustPython#8004 when its matrix skips were cleared). Also picks up RustPython#8018's
_thread.rs stack-margin updates, which are orthogonal to the
apply_thread_stack_size fix in this PR.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle windows test proper way

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ShaharNaveh @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.