GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Run windows tests with `-u all` by ShaharNaveh · Pull Request #8134 · RustPython/RustPython

Conversation

ShaharNaveh commented Jun 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Closes #xxxx
This PR follows our AI policy

Summary

Summary by CodeRabbit

Chores
- Enhanced CI/CD testing configuration for Windows environments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ShaharNaveh added 2 commits

June 19, 2026 17:38


          Enable all test resources on windows

9de49d7


          Mark tests

coderabbitai Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

Lib/test/test_wmi.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 2ec6dd68-dfa5-4bbf-b6a4-16ab67dfe329

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

📝 Walkthrough

Walkthrough

In .github/workflows/ci.yaml, the snippets_cpython job's windows-2025 matrix entry has its extra_test_args changed from an empty list ([]) to ['-u all'], removing a prior TODO placeholder and enabling the -u all flag for CPython test runs on that platform.

Changes

CI Windows CPython Test Configuration

Layer / File(s)	Summary
windows-2025 extra_test_args update `.github/workflows/ci.yaml`	`extra_test_args` for the `windows-2025` matrix entry in `snippets_cpython` is changed from `[]` to `['-u all']`, activating the `-u all` resource-use flag for that CI run.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

RustPython/RustPython#8004: Modifies the same snippets_cpython Windows matrix entry in ci.yaml, changing the skips field — a direct sibling configuration change in the same matrix block.

Poem

🐇 A TODO once sat, collecting dust and sighs,
On windows-2025 where the CPython flies.
-u all now waves its flag with pride,
No more empty brackets left to hide!
The rabbit hops on, tests running wide~ ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the main change: updating Windows tests to run with the `-u all` flag, which matches the primary modification in `.github/workflows/ci.yaml`.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/codecs.py
[x] test: cpython/Lib/test/test_charmapcodec.py
[ ] test: cpython/Lib/test/test_codeccallbacks.py (TODO: 9)
[x] test: cpython/Lib/test/test_codecencodings_cn.py (TODO: 4)
[x] test: cpython/Lib/test/test_codecencodings_hk.py (TODO: 1)
[x] test: cpython/Lib/test/test_codecencodings_iso2022.py (TODO: 5)
[x] test: cpython/Lib/test/test_codecencodings_jp.py (TODO: 7)
[x] test: cpython/Lib/test/test_codecencodings_kr.py (TODO: 3)
[x] test: cpython/Lib/test/test_codecencodings_tw.py (TODO: 1)
[ ] test: cpython/Lib/test/test_codecmaps_cn.py (TODO: 3)
[ ] test: cpython/Lib/test/test_codecmaps_hk.py (TODO: 1)
[ ] test: cpython/Lib/test/test_codecmaps_jp.py (TODO: 6)
[ ] test: cpython/Lib/test/test_codecmaps_kr.py (TODO: 3)
[ ] test: cpython/Lib/test/test_codecmaps_tw.py (TODO: 3)
[ ] test: cpython/Lib/test/test_codecs.py (TODO: 12)
[ ] test: cpython/Lib/test/test_multibytecodec.py (TODO: 1)
[x] test: cpython/Lib/test/testcodec.py

dependencies:

codecs

dependent tests: (161 tests)

codecs: test_charmapcodec test_codeccallbacks test_codecs test_eof test_exceptions test_importlib test_inspect test_io test_json test_locale test_logging test_multibytecodec test_os test_pdb test_plistlib test_sax test_str test_sys
- encodings: test_pydoc
  - locale: test__locale test_builtin test_c_locale_coercion test_calendar test_decimal test_float test_format test_re test_regrtest test_strftime test_strptime test_types test_utf8_mode
- json: test_embed test_pyrepl test_subprocess test_sysconfig test_tomllib test_tools test_traceback test_zoneinfo
  - importlib.metadata: test_importlib
  - multiprocessing.resource_tracker: test_concurrent_futures
- pickle: test_annotationlib test_argparse test_array test_ast test_asyncio test_bool test_bytes test_bz2 test_collections test_concurrent_futures test_configparser test_coroutines test_csv test_ctypes test_defaultdict test_deque test_descr test_dict test_dictviews test_email test_enum test_enumerate test_fractions test_functools test_generators test_genericalias test_http_cookies test_ipaddress test_iter test_itertools test_list test_lzma test_memoryio test_memoryview test_minidom test_opcache test_operator test_ordered_dict test_pathlib test_pickle test_picklebuffer test_pickletools test_platform test_positional_only_arg test_posix test_random test_range test_set test_shelve test_slice test_socket test_statistics test_string test_structseq test_super test_time test_trace test_tuple test_turtle test_type_aliases test_type_params test_typing test_unittest test_uuid test_xml_dom_minicompat test_xml_etree test_xpickle test_zipfile test_zlib test_zoneinfo
  - tracemalloc: test_tracemalloc
- plistlib:
  - platform: test__osx_support test_asyncio test_baseexception test_cmath test_ctypes test_fcntl test_math test_mimetypes test_shutil test_ssl test_winreg test_wsgiref
- tokenize: test_linecache test_peg_generator test_tabnanny test_tokenize test_unparse
  - inspect: test_abc test_asyncgen test_buffer test_clinic test_code test_grammar test_monitoring test_ntpath test_patma test_posixpath test_signal test_sqlite3 test_type_annotations test_yield_from test_zipimport test_zipimport_support
  - linecache: test_bdb
  - traceback: test_asyncio test_code_module test_contextlib test_contextlib_async test_dictcomps test_http_cookiejar test_importlib test_listcomps test_pyexpat test_setcomps test_threadedtempfile test_threading test_unittest test_with

[x] lib: cpython/Lib/tokenize.py
[x] test: cpython/Lib/test/test_tokenize.py (TODO: 8)

dependencies:

tokenize

dependent tests: (149 tests)

tokenize: test_inspect test_linecache test_peg_generator test_tabnanny test_tokenize test_unparse
- idlelib: test_idle
- importlib._bootstrap_external: test_importlib test_unittest
  - modulefinder: test_importlib test_modulefinder
  - py_compile: test_argparse test_cmd_line_script test_compileall test_importlib test_multiprocessing_main_handling test_py_compile test_pydoc test_runpy
  - pydoc: test_enum
- inspect: test_abc test_asyncgen test_buffer test_builtin test_clinic test_code test_collections test_coroutines test_decimal test_functools test_generators test_grammar test_monitoring test_ntpath test_operator test_patma test_posixpath test_signal test_sqlite3 test_traceback test_turtle test_type_annotations test_types test_typing test_unittest test_yield_from test_zipimport test_zipimport_support test_zoneinfo
  - ast: test_ast test_compile test_compiler_codegen test_dis test_fstring test_future_stmt test_peepholer test_site test_ssl test_type_comments test_ucn
  - bdb: test_bdb test_pdb
  - cmd: test_cmd
  - dataclasses: test__colorize test_copy test_ctypes test_genericalias test_pprint test_regrtest
  - pkgutil: test_pkgutil test_pyrepl
  - rlcompleter: test_pyrepl test_rlcompleter
  - trace: test_trace
  - xmlrpc.server: test_docxmlrpc test_xmlrpc
- linecache:
  - timeit: test_timeit
  - traceback: test_asyncio test_code_module test_contextlib test_contextlib_async test_dictcomps test_exceptions test_http_cookiejar test_importlib test_iter test_listcomps test_pyexpat test_setcomps test_socket test_subprocess test_sys test_threadedtempfile test_threading test_unittest test_with
  - tracemalloc: test_tracemalloc
- traceback:
  - concurrent.futures.process: test_concurrent_futures
  - http.cookiejar: test_urllib2
  - logging: test_asyncio test_hashlib test_logging test_support test_urllib2net
  - multiprocessing: test_asyncio test_concurrent_futures test_fcntl test_memoryview test_re
  - socketserver: test_imaplib test_socketserver test_wsgiref
  - threading: test_android test_asyncio test_bytes test_bz2 test_concurrent_futures test_context test_ctypes test_email test_fork1 test_frame test_ftplib test_gc test_httplib test_httpservers test_importlib test_io test_ioctl test_itertools test_largefile test_opcache test_pathlib test_poll test_poplib test_pyrepl test_queue test_robotparser test_sched test_smtplib test_super test_syslog test_termios test_threading_local test_time test_urllib2_localnet test_weakref test_winreg test_zstd

[x] test: cpython/Lib/test/test_winsound.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on winsound)

[x] test: cpython/Lib/test/test_winconsoleio.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on winconsoleio)

[x] lib: cpython/Lib/venv
[x] test: cpython/Lib/test/test_venv.py (TODO: 18)

dependencies:

venv

dependent tests: (1 tests)

venv: test_venv

[x] test: cpython/Lib/test/test_wmi.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on wmi)

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          mark wmi test

7e4449f

youknowone approved these changes

Jun 22, 2026

View reviewed changes

youknowone reviewed

Jun 22, 2026

View reviewed changes

Comment thread

Lib/test/test_wmi.py

		with self.assertRaises(ValueError):
		wmi_exec_query("not select, just in case someone tries something")

		@unittest.skipIf(__import__("sys").platform == "win32", "TODO: RUSTPYTHON; Timeout after 10 minutes")

youknowone Jun 22, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wmi itself is windows-only test. skipIf is nonsense.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ShaharNaveh Jun 22, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, my rational was that it will be easier to see at the diagnostics of how many tests do we skip on each platform, I can just skip it without any conditions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone merged commit 55b96f9 into RustPython:main

Jun 22, 2026

27 checks passed

Uh oh!

There was an error while loading. Please reload this page.

youknowone pushed a commit that referenced this pull request

Sep 16, 2026


          Run windows tests with -u all (#8134)

221d95c

* Enable all test resources on windows

* Mark tests

* mark wmi test

Reviewers

youknowone

youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ShaharNaveh commented Jun 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

github-actions Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Library Dependencies

Uh oh!

youknowone Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

ShaharNaveh Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShaharNaveh commented Jun 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.