GeezerVison

Argument binding now uses metadata separate from displayed signatures. Known parameter layouts are validated before conversion, while selected custom parsers retain their own validation behavior. Built-in and standard-library argument handling and tests were updated.

Changes: Argument binding

Layer / File(s)	Summary
Binding metadata and signatures crates/vm/src/function/argument.rs, crates/derive-impl/src/from_args.rs, crates/vm/src/function/signature.rs, crates/derive-impl/src/pyclass.rs	FromArgs and SigArg now carry binding metadata separately from displayed parameters. Derives and tuple arguments propagate metadata, and native call flags use it.
Known-shape validation crates/vm/src/function/argument.rs, extra_tests/snippets/vm_argument_errors.py	BindingShape checks known parameter layouts before conversion. Tests cover validation order, receivers, variadic parameters, custom parsers, and malformed layouts.
Built-in callable integrations crates/vm/src/builtins/{int,str,object,type}.rs, crates/stdlib/src/_datetime.rs, crates/wasm/src/ssl.rs	Built-in argument handling and SSL hostname binding now use the updated binding behavior.
Custom parser integrations and tests crates/vm/src/builtins/property.rs, crates/vm/src/stdlib/{_interpreters,_operator,_thread,typevar}.rs, extra_tests/snippets/vm_argument_errors.py	Selected parsers disable generated binding or retain custom error handling. TypeVar arguments use a flattened constraints structure, and tests cover custom parser conversion and error behavior.

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant check_before_convert
  participant BindingShape
  participant FromArgsParser
  Caller->>check_before_convert: provide arguments
  check_before_convert->>BindingShape: validate known parameter shape
  BindingShape-->>check_before_convert: return validation result
  check_before_convert->>FromArgsParser: convert arguments after validation

Loading

Possibly related PRs

• RustPython/RustPython#9513: Addresses missing-argument checks before conversion and preserves legacy parser ordering.
• RustPython/RustPython#9242: Checks excess positional arguments before conversion using FromArgs::arity().
• RustPython/RustPython#9503: Adds keyword rejection before conversion, related to the binding validation changes.

Suggested reviewers: youknowone

Merge Risk: Low · previous review a5d24

Calls to int or str subclasses with too many positional arguments report a different error message than CPython. The behavior otherwise works, so this is a narrow diagnostic-text issue that can be fixed or tracked before or after merge.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 17.39% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: default Clinic argument binding for FromArgs implementations.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 17.39% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 23 functions across 16 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Generate unit tests (beta)

• Create a new PR

• X
• Mastodon
• Reddit
• LinkedIn

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.