GeezerVison

LLM Description written by Claude Code:claude-opus-5-5

Refs #1094 (fixes the hosted and vendored legs; the vex leg for a member lock pinned before this fix is a follow-up, see below)

Root cause

hosted::governing_root::refusal skips the #884 package.json-workspaces member check whenever the member directory holds any npm-family lock (has_own_npm_family_lock). npm reads no package-lock.json / npm-shrinkwrap.json inside a workspace member: it always installs members from the workspace root's lock. So a stray member lock (common after a package moves into a monorepo with its old lock still committed) suppressed the refusal. Hosted scan / get then pinned the ignored member lock, and vendored mode vendored into it. Both exited 0 while npm installed the unpatched package.

Fix

• governing_root::npm_member_stray_lock (new, pub(crate)): a directory whose only own locks are npm locks, listed by an ancestor package.json workspaces whose root holds package-lock.json or npm-shrinkwrap.json. The workspace-root walk is split out of package_json_workspace_refusal (package_json_workspace_root) so both checks share it. Fix workspace-member refusal for vlt and brace/class globs (#1071, #942) #1073's vlt fallback (merged from main) lives in that shared walk too.
• Hosted: refusal runs that check when the member has its own lock, and refuses with the existing redirect_workspace_lockfile_elsewhere. The message names the root lock and the ignored member lock, plus the workspace root to run from. That's the only remedy that clears the refusal, since the directory stays a listed member whatever lock it holds (Bugbot).
• Vendored: npm_flavor::npm_member_stray_lock_refusal refuses the package-lock flavor in that layout with vendor_lockfile_missing, the same code a member with no lock gets. Both vendor_npm_any and npm_lock_vendor_preflight raise it. The preflight runs before any download or hosted→vendored takeover revert, so a leftover hosted pin is never restored only to have vendoring refused (Bugbot). vendor --revert / rollback don't go through this path, so anything already vendored there can still be unwound.
• The own-lock shortcut stays for a member that also holds a lock its own manager reads (pnpm, yarn, Bun, vlt, Rush) and for a root with no npm lock. pnpm and vlt ignore package.json workspaces, and yarn berry treats a nested yarn.lock as its own project. Classic yarn and Bun weren't tested in the issue and aren't changed here.
• CLI_CONTRACT.md: the redirect_workspace_lockfile_elsewhere row now describes the new case.
• Since the 09:24Z main merge (Decide which lockfile governs installs in one table #1044's governing-lock table), the check reads npm's locks and the other families' locks from NpmLockFamily / npm_lock_files() instead of the removed NPM_LOCKS / OWN_LOCKS lists.

Follow-up (why Refs, not Fixes)

With this change, socket-patch no longer writes a pin into an ignored member lock. But a member lock pinned by an earlier version is still read by vex, which would attest it. Gating that needs a new VEX omission code and note in the contract (the existing unattested gate's note is Gradle-specific). I left #1094 open for that piece.

Tests (red → green)

Commands run locally:

• cargo clippy --workspace --all-features -- -D warnings: clean (on d9a569f, and on the 09:24Z main merge)
• cargo test --workspace --all-features --no-fail-fast (on the main merge 3c8e956): 237 test binaries pass. The only 12 failures are permission-based write-failure tests (*_write_failure_*, *unremovable*, relax_loop_must_not_traverse_symlinked_root), which can't fail as root, the user this sandbox runs as. Re-run as an unprivileged user (setpriv --reuid=65534), all 12 pass.
• On 75fdc9a (09:24Z main merge): cargo test --workspace --all-features --no-fail-fast fails the same 12 root-only permission tests plus mode_migration_pypi::pipenv_hosted_to_vendored_names_the_unpatched_requirements, which needs pypi.org (unreachable from this sandbox; unrelated to npm). Everything else passes, including in_process_redirect_pnpm (23) and scan_vendor_e2e (37).
• cargo fmt: the changed code is formatted. main itself isn't cargo fmt --check clean (about 120 files), and CI doesn't run fmt, so I didn't reformat unrelated files.

No wrapper changes (npm/, pypi/, gem/): the logic lives in the core crate only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01479CXaUep24uv6zcJnZ59g

Generated by Claude Code