Description

cheshi-mantu

opened on May 21, 2024

Issue body actions

I'm submitting a ...

• bug report
• feature request
• support request => Please do not submit support request here, see note at the top of this template.

What is the current behavior?

when pytest tests are being executed the content of marks with parameters is saved to labels section as a tag.

code like

@pytest.mark.skip("skip this test")
@allure.title(TestNames.FAILING_TEST.get_name())
def test_failing_test():
    f"""{TestNames.FAILING_TEST.get_description()}"""
    assert False

will result in

"labels": [
    {
      "name": "tag",
      "value": "@pytest.mark.skip('skip this test')"
    }
<snip>
]

the tag's text will contain spaces, which will result in errors in the integrations Allure Testops has, e.g. when trying to export the data to jira we'll get

response body {"errorMessages":[],"errors":{"labels":"The label '@pytest.mark.skip('Skipping the test because the tests are using token.')' contains spaces which is invalid."}}

as most of the system do not allow creation of tags/labels with spaces.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

N/A

What is the expected behaviour?

marks with parameters aren't transferred to the *-result.json files as tags.

What is the motivation / use case for changing the behavior?

tag is a 1 word label should not contain spaces.

Please tell us about your environment:

• Allure version: 2.1.0
• Test framework: [email protected]
• Allure adaptor: [email protected]

Other information

N/A

Activity

1. delatrie

   added

   theme:pytest

   on May 21, 2024
2. delatrie

   added

   task:improvementChange that improves some user experience but can't be considered a new featureChange that improves some user experience but can't be considered a new feature

   on Jun 1, 2024
3. delatrie

   added the

   Feature

   issue type on Apr 22, 2025
4. delatrie commented on Apr 22, 2025

   

   delatrie

   on Apr 22, 2025

   Contributor

   More actions

   Built-in marks should also be ignored even without arguments. This includes skip, skipif, xfail, usefixtures, parametrize, and filterwarnings. We have other means to indicate their effect, and they aren't used for filtering in the vast majority of cases.
5. sharovd

   added a commit that references this issue on May 17, 2025

   fix: don't convert built-in (reserved) pytest markers to allure tags (a…

   36d6db7
6. sharovd commented on May 17, 2025

   

   sharovd

   on May 17, 2025

   Contributor

   More actions

   Hi everyone!

   @delatrie, thanks for the context and the idea on how to fix this!
   After applying the changes, all built-in pytest marks are now ignored, so the described issue is no longer reproducible. The labels field in the test result json file no longer contains a tag with the skip pytest marker.

   The code and unit tests changes are available in the PR #862 - I’d appreciate your review when you have time.

   Reacted by Maksim Stepanov
7. delatrie

   added a commit that references this issue on Jun 9, 2025

   fix: don't convert built-in (reserved) pytest markers to allure tags (a…

   e141153
8. delatrie

   closed this as completedin 4d67928on Jun 9, 2025
9. sharovd

   added a commit that references this issue on Jun 9, 2025

   Don't convert built-in (reserved) pytest markers to allure tags (fix a…

   This issue will close once commit 4d67928 is merged into the 'master' branch.

   4d67928

Issue actions