GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don't convert built-in (reserved) pytest markers to allure tags (fix #817) by sharovd · Pull Request #862 · allure-framework/allure-python

Conversation

@sharovd

@sharovd sharovd commented May 17, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Context

  • Fix the issue to prevent saving marks with parameters as labels → tag #817

  • Code changes:

    • The pytest_markers(item) method in utils.py has been simplified - now only "simple" user-defined pytest markers are converted to allure tags. Built-in (reserved) markers (e.g. skip, xfail, etc.) are now ignored. The approach was taken from allure-pytest-bdd implementation
  • Unit tests changes:

    • Existing tests in tag_test.py have been updated, new tests have been added for each built-in (reserved) marker to verify they are ignored
    • Renamed both the update and the new tests to make their purpose clearer
    • Removed test_pytest_marker_with_kwargs_native_encoding as a duplicate of test_pytest_marker_with_kwargs_utf_encoding - they looked identical
    • Updated the affected test in pytest_rerunfailures_test.py accordingly

Checklist

  • Sign Allure CLA
  • Provide unit tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

delatrie and brolnickij reacted with heart emoji
All reactions
  • ❤️ 2 reactions
This was referenced May 17, 2025
Add support the display of duplicate tag names (fix #832) #852
Closed
to prevent saving marks with parameters as labels → tag #817
Closed
@delatrie delatrie added type:enhancement theme:pytest labels May 20, 2025
@delatrie
delatrie self-requested a review May 20, 2025 10:48
@epszaw epszaw assigned delatrie Jun 4, 2025
delatrie
delatrie requested changes Jun 9, 2025
View reviewed changes

@delatrie delatrie left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @sharovd ! Good job here!

Sorry for having kept you waiting for so long.

I would like to suggest a couple of tiny changes, please, check them out.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread tests/allure_pytest/acceptance/label/tag/tag_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tests/allure_pytest/acceptance/label/tag/tag_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tests/allure_pytest/acceptance/label/tag/tag_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tests/allure_pytest/acceptance/label/tag/tag_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

sharovd added 3 commits June 9, 2025 21:21
@sharovd @delatrie
fix: don't convert built-in (reserved) pytest markers to allure tags (a…
e141153
…llure-framework#817)
@sharovd @delatrie
fix the issue found by the linter (F401 'allure_commons.utils.represe…
26b6a9c
…nt' imported but unused)
@sharovd @delatrie
apply suggestions from code review
c3b3197
@delatrie
delatrie force-pushed the fix-817-ignore-built-in-marks branch from 3f3ba87 to c3b3197 Compare June 9, 2025 14:21
delatrie
delatrie approved these changes Jun 9, 2025
View reviewed changes
@delatrie
delatrie merged commit 4d67928 into allure-framework:master Jun 9, 2025
@mshonichev mshonichev mentioned this pull request Jul 15, 2025
missing mark_to_str import after recent update of allure-python Denis-Alexeev/pytest-glamor-allure#69
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delatrie delatrie delatrie approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@delatrie delatrie

Labels

theme:pytest type:enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sharovd @delatrie
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.