GeezerVison is showing github.com — Add support the display of duplicate tag names (fix #832) by sharovd · Pull Request #852 · allure-framework/allure-python
Conversation
sharovd
commented
Apr 5, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Context
- Fix the issue Allure report's tags support the display of duplicate tag names #832
- All user-defined markers (e.g.
case_id) will be fully collected according to the described problem
- Only the closest built-in pytest markers (e.g.
skipif) will still be collected according to the existing tests
- Modified
pytest_markers() method and corresponding test test_show_reserved_pytest_markers_full_decorator()
Checklist
P.S.: This is my first open source contribution. I'm happy to improve it if there's anything that needs to be changed or improved. Thanks for reviewing!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
delatrie
commented
Apr 22, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Hi, @sharovd
Thank you for investing your time in allure-pytest.
The thing is that allure-pytest is unique among other Allure integrations in that it tries to convert to tags something that doesn't really fit into the idea of tags: pytest markers with arguments. I believe implementing this was a mistake, as it creates more problems than it solves. We shouldn't also convert built-in markers, as we have better options to indicate their effect. I've described it in more detail in the issue.
And if we don't convert the abovementioned markers, the problem with missing tags will resolve itself (multiple markers with no arguments means the tag values will be the same, and there is no point in having multiple tags with absolutely the same values).
We have an existing issue that addresses just that: #817, and we should implement it. If you're still willing to work on markers-to-tags conversion, you may take the implementation from allure-pytest-bdd and adjust the tests accordingly.
|
sharovd reacted with eyes emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@delatrie, hi!
Thanks for the details, and sorry for the delay from my side.
I’ve looked into issue #817 and suggested a solution in PR #862 - please review.
I believe we can now close this PR?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@sharovd , thanks for addressing it so quickly. I'm closing this PR in favor of #862 now
|
sharovd reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.