GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: more info on currency digits by cexbrayat · Pull Request #24661 · angular/angular

Conversation

@cexbrayat

@cexbrayat cexbrayat commented Jun 25, 2018

Copy link
Copy Markdown
Member

Adds an example of using the currency pipe with a currency that has no cents like CLP,
which will format the amount with no digits if digitsInfo is not provided:

<!-- outputs CA$14.00 -->
{{ 14 | currency:'CAD' }}
<!-- outputs CLP14 -->
{{ 14 | currency:'CLP' }}

Amends the docs, adds an example and fix an error with a current example.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

See #24141 (comment)

What is the new behavior?

Adds a small example of using the currency pipe with no digitsInfo and with a currency that has no cents to illustrate that the formatting done by the pipe by default follows the ISO 4217 specification.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericmartinezr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@googlebot googlebot added the cla: yes label Jun 25, 2018
@cexbrayat cexbrayat mentioned this pull request Jun 25, 2018
API doc for pipes #24141
Closed
2 of 3 tasks
ocombe
ocombe approved these changes Jun 25, 2018
View reviewed changes
@ocombe ocombe added comp: docs area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release labels Jun 25, 2018
@jbogarthyde

jbogarthyde commented Jun 25, 2018

Copy link
Copy Markdown
Contributor

See also this pending PR on rounding behavior:
#24303

s-gbz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jbogarthyde jbogarthyde mentioned this pull request Jun 25, 2018
docs: describe rounding behaviour of "DecimalPipe" (#24038) #24303
Closed
1 of 3 tasks
@cexbrayat
docs: more info on currency digits
98978c0
Adds an example of using the `currency` pipe with a currency that has no cents like CLP,
which will format the amount with no digits if `digitsInfo` is not provided:

    <!-- outputs CA$14.00 -->
    {{ 14 | currency:'CAD' }}
    <!-- outputs CLP14 -->
    {{ 14 | currency:'CLP' }}

Amends the docs, adds an example and fix an error with a current example.
@cexbrayat
cexbrayat force-pushed the fix/currency-docs branch from 4367d5d to 98978c0 Compare June 25, 2018 21:18
@brandonroberts brandonroberts assigned vicb Jul 2, 2018
@brandonroberts

brandonroberts commented Jul 2, 2018

Copy link
Copy Markdown
Contributor

@vicb will you provide an approval for this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brandonroberts brandonroberts self-assigned this Jul 2, 2018
@brandonroberts brandonroberts assigned mhevery Jul 10, 2018
@mhevery

mhevery commented Jul 17, 2018

Copy link
Copy Markdown
Contributor

http://test/OCL:204944974:BASE:204945010:1531852362437:7e2a8198

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Jul 17, 2018
vicb
vicb approved these changes Jul 20, 2018
View reviewed changes
vicb pushed a commit that referenced this pull request Jul 20, 2018
@cexbrayat @vicb
docs: more info on currency digits (#24661)
ae0fce6
Adds an example of using the `currency` pipe with a currency that has no cents like CLP,
which will format the amount with no digits if `digitsInfo` is not provided:

    <!-- outputs CA$14.00 -->
    {{ 14 | currency:'CAD' }}
    <!-- outputs CLP14 -->
    {{ 14 | currency:'CLP' }}

Amends the docs, adds an example and fix an error with a current example.

PR Close #24661
@vicb vicb closed this in 270176b Jul 20, 2018
@cexbrayat cexbrayat mentioned this pull request Jul 22, 2018
docs: e2e tests for number/percent/currency pipe #25028
Closed
3 tasks done
cexbrayat added a commit to cexbrayat/angular that referenced this pull request Jul 22, 2018
@cexbrayat
docs: tests for number/percent/currency pipe
6097ec1
Will avoid errors in examples like the one fixed in angular#24661
vicb pushed a commit that referenced this pull request Jul 23, 2018
@cexbrayat @vicb
docs: tests for number/percent/currency pipe (#25028)
6eca367
Will avoid errors in examples like the one fixed in #24661

Closes #25028
vicb pushed a commit that referenced this pull request Jul 23, 2018
@cexbrayat @vicb
docs: tests for number/percent/currency pipe (#25028)
be3cca4
Will avoid errors in examples like the one fixed in #24661

Closes #25028
@jenniferfell jenniferfell added the state: community Someone from the Angular community is working on this issue or submitted this PR label Oct 9, 2018
@jenniferfell jenniferfell unassigned vicb Oct 9, 2018
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@vicb vicb vicb approved these changes
@ocombe ocombe ocombe approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandonroberts brandonroberts

@mhevery mhevery

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@cexbrayat @jbogarthyde @brandonroberts @mhevery @vicb @ocombe @googlebot @jenniferfell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.