GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: e2e tests for number/percent/currency pipe by cexbrayat · Pull Request #25028 · angular/angular

Conversation

@cexbrayat

@cexbrayat cexbrayat commented Jul 22, 2018

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The number pipes were not tested in e2e.

What is the new behavior?

This PR adds e2e tests for the number/percent/currency pipe and will avoid errors in examples like the one fixed in #24661

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@googlebot googlebot added the cla: yes label Jul 22, 2018
@cexbrayat
cexbrayat force-pushed the test/currency-pipe branch 3 times, most recently from 1190142 to 08e209c Compare July 22, 2018 16:45
@cexbrayat
docs: tests for number/percent/currency pipe
6097ec1 
Will avoid errors in examples like the one fixed in angular#24661
@cexbrayat
cexbrayat force-pushed the test/currency-pipe branch from 08e209c to 6097ec1 Compare July 22, 2018 17:06
@brandonroberts
brandonroberts requested a review from ocombe July 23, 2018 12:35
@brandonroberts brandonroberts self-assigned this Jul 23, 2018
@brandonroberts brandonroberts added comp: docs area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release labels Jul 23, 2018
ocombe
ocombe approved these changes Jul 23, 2018
View reviewed changes
@jenniferfell jenniferfell added state: community Someone from the Angular community is working on this issue or submitted this PR and removed state: community Someone from the Angular community is working on this issue or submitted this PR labels Jul 23, 2018
@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Jul 23, 2018
@vicb

vicb commented Jul 23, 2018

Copy link
Copy Markdown
Contributor

http://test/OCL:205689561:BASE:205689659:1532368916468:eff2238a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vicb pushed a commit that referenced this pull request Jul 23, 2018
@cexbrayat @vicb
docs: tests for number/percent/currency pipe (#25028)
6eca367 
Will avoid errors in examples like the one fixed in #24661

Closes #25028
@vicb

vicb commented Jul 23, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I had to merge this PR manually because of a conflict on the 6.0.x branch.
-> merged in both master and 6.0.x

Thanks for the PR @cexbrayat
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vicb vicb closed this Jul 23, 2018
vicb pushed a commit that referenced this pull request Jul 23, 2018
@cexbrayat @vicb
docs: tests for number/percent/currency pipe (#25028)
be3cca4 
Will avoid errors in examples like the one fixed in #24661

Closes #25028
vicb added a commit to vicb/angular that referenced this pull request Jul 24, 2018
@vicb
refactor(common): fix a merge error
a433b0b 
A `keyvalue-pipe` was inadvertently pulled in  When merging angular#25028 (commit
6eca367). This pipe is NOT in the patch branch and the test fails.

This commit remove the faulty spec.
@vicb vicb mentioned this pull request Jul 24, 2018
refactor(common): fix a merge error #25053
Closed
vicb added a commit that referenced this pull request Jul 24, 2018
@vicb
refactor(common): fix a merge error (#25053)
5f680d4 
A `keyvalue-pipe` was inadvertently pulled in  When merging #25028 (commit
6eca367). This pipe is NOT in the patch branch and the test fails.

This commit remove the faulty spec.

PR Close #25053
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ocombe ocombe ocombe approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandonroberts brandonroberts

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@cexbrayat @vicb @ocombe @brandonroberts @googlebot @jenniferfell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.