GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor(compiler): check that ng-container don't have class bindings by JeanMeche · Pull Request #71844 · angular/angular

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Nov 5, 2026

Copy link
Copy Markdown
Member

This is the same change as #70808 but for g3 only due to its breaking nature.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JeanMeche
JeanMeche requested a review from mattrbeck November 5, 2026 16:14
@angular-robot angular-robot Bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Nov 5, 2026
@ngbot ngbot Bot added this to the Backlog milestone Nov 5, 2026
@JeanMeche

JeanMeche commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

TGP came back green. This is good to go.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JeanMeche JeanMeche added the target: patch This PR is targeted for the next patch release label Nov 5, 2026
mattrbeck
mattrbeck approved these changes Nov 7, 2026
View reviewed changes
Comment thread packages/compiler/src/render3/r3_template_transform.ts
`Attribute bindings are not supported on ng-container. Use property bindings instead.`,
bound.sourceSpan,
);
// TODO(v23): Enable this breaking change

@mattrbeck mattrbeck Nov 7, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ The tests from #70808 were dropped here. Could we bring them into r3_template_transform_spec.ts as xit with a TODO(v23)? That's what the CSS-variable change did (shadow_css_spec.ts, dom_renderer_spec.ts), and it makes the v23 switch-over mechanical.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JeanMeche reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@JeanMeche JeanMeche Nov 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Added the tests from #70808 into r3_template_transform_spec.ts as xit with // TODO(v23): Enable this breaking change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JeanMeche
refactor(compiler): check that ng-container don't have class bindings
1344b06 
This is the same change as angular#70808 but for g3 only due to its breaking nature.
@JeanMeche
JeanMeche force-pushed the g3-ngcontainer-class branch from 539f7ae to 1344b06 Compare November 7, 2026 16:07
@SkyZeroZx SkyZeroZx mentioned this pull request Nov 8, 2026
Report bindings that have no effect on ng-container, ng-template, and ng-content #71881
Open
This was referenced Nov 8, 2026
feat(compiler-cli): add ignoredBinding check #71882
Closed
feat(compiler): check that ng-container don't have class bindings #70808
Open
@Flarette

Flarette commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Same as my note on #70808: this is one case of #71881, which #71882 and #71884 cover as NG8031. Needs reconciliation with #71882 and #71884 before merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Nov 10, 2026
@thePunderWoman
thePunderWoman merged commit 5cd01d6 into angular:main Nov 10, 2026
25 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@thePunderWoman

thePunderWoman commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

  • main: 5cd01d6
  • 22.2.x: 85e1962
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JeanMeche
JeanMeche deleted the g3-ngcontainer-class branch November 11, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattrbeck mattrbeck mattrbeck approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JeanMeche @Flarette @thePunderWoman @mattrbeck
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.