GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat(compiler): check that ng-container don't have class bindings by JeanMeche · Pull Request #70808 · angular/angular

Conversation

JeanMeche commented Sep 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Those are never applied and we should throw at compiler time.

class attributes are still supported because we allow them for content projection purposes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

angular-robot Bot added detected: feature

PR contains a feature commit

area: compiler Issues related to `ngc`, Angular's template compiler labels

Sep 18, 2026

ngbot Bot added this to the Backlog milestone

Sep 18, 2026

JeanMeche force-pushed the container-class branch 2 times, most recently from e44228d to 28ac0ee Compare

September 18, 2026 21:00

JeanMeche added state: blocked on G3 cleanup This change requires a G3 cleanup and removed detected: feature PR contains a feature commit labels

Sep 22, 2026

JeanMeche force-pushed the container-class branch from ab41f11 to 5936f83 Compare

September 22, 2026 22:12

angular-robot Bot added the detected: feature PR contains a feature commit label

Sep 22, 2026

JeanMeche requested a review from mattrbeck

September 22, 2026 22:25

JeanMeche marked this pull request as ready for review

September 22, 2026 22:25

JeanMeche force-pushed the container-class branch 2 times, most recently from 40b0416 to a45b5fd Compare

September 22, 2026 22:52

JeanMeche changed the title ~~feat(compiler): check that ng-container don't class bindings~~ feat(compiler): check that ng-container don't have class bindings nor aria attributes

Sep 22, 2026

JeanMeche force-pushed the container-class branch from a45b5fd to cb2b479 Compare

September 23, 2026 00:18

JeanMeche changed the title ~~feat(compiler): check that ng-container don't have class bindings nor aria attributes~~ feat(compiler): check that ng-container don't have class bindings

Sep 23, 2026


          feat(compiler): check that ng-container don't have class bindings

5fe7be1

Those are never applied and we should throw at compiler time.

JeanMeche force-pushed the container-class branch from cb2b479 to 5fe7be1 Compare

September 23, 2026 22:30

mattrbeck approved these changes

Sep 28, 2026

View reviewed changes

mattrbeck left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the partial linker re-parse templates? I wonder if adding this change without an exemption in the partial linker will cause breakages when parsing dependencies which still bind the class on ng-container

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

packages/compiler/src/render3/r3_template_transform.ts

		@@ -242,6 +242,11 @@ class HtmlAstToIvyAst implements html.Visitor {
		`Attribute bindings are not supported on ng-container. Use property bindings instead.`,

mattrbeck Sep 28, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user wrote [attr.class]="foo" today, they'd get an error telling them to use [class]="foo", which would now also error. Maybe we can report these errors in a way that's a little more clear?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

packages/compiler/src/render3/r3_template_transform.ts

		);
		} else if (
		bound.type === BindingType.Class \|\|
		(bound.type === BindingType.Property && bound.name === 'class')

mattrbeck Sep 28, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be breaking if a directive has a "class" input today?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

packages/compiler/src/render3/r3_template_transform.ts

		);
		} else if (
		bound.type === BindingType.Class \|\|
		(bound.type === BindingType.Property && bound.name === 'class')

mattrbeck Sep 28, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also check if bound.name === 'style'?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

packages/compiler/src/render3/r3_template_transform.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

JeanMeche mentioned this pull request

Nov 5, 2026

refactor(compiler): check that ng-container don't have class bindings #71844

Merged

JeanMeche removed the state: blocked on G3 cleanup This change requires a G3 cleanup label

Nov 5, 2026

JeanMeche added a commit to JeanMeche/angular that referenced this pull request

Nov 7, 2026


          refactor(compiler): check that ng-container don't have class bindings

1344b06

This is the same change as angular#70808 but for g3 only due to its breaking nature.

SkyZeroZx mentioned this pull request

Nov 8, 2026

Report bindings that have no effect on ng-container, ng-template, and ng-content #71881

Open

JeanMeche mentioned this pull request

Nov 8, 2026

feat(compiler-cli): add ignoredBinding check #71882

Closed

6 of 14 tasks

Flarette commented Nov 8, 2026

Copy link

Copy Markdown

Contributor

This is one case of #71881. #71882 reports class bindings on <ng-container> as NG8031, along with style, event, and other bindings that <ng-container>, <ng-template>, and <ng-content> ignore. It runs in the type checker, so the linker concern doesn't apply, and it skips bindings a directive claims. #71884 makes it an error, like the TODO(v23) in #71844.

If both land, class bindings get the parse error and NG8031, so this needs reconciliation with #71882 and #71884 before merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

thePunderWoman pushed a commit that referenced this pull request

Nov 10, 2026


          refactor(compiler): check that ng-container don't have class bindings

5cd01d6

This is the same change as #70808 but for g3 only due to its breaking nature.

thePunderWoman pushed a commit that referenced this pull request

Nov 10, 2026


          refactor(compiler): check that ng-container don't have class bindings

85e1962

This is the same change as #70808 but for g3 only due to its breaking nature.

(cherry picked from commit 5cd01d6)

JeanMeche added state: blocked breaking changes labels

Nov 11, 2026

JeanMeche removed this from the Backlog milestone

Nov 11, 2026

JeanMeche added this to the v23 candidates milestone

Nov 11, 2026

Reviewers

mattrbeck

mattrbeck approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area: compiler

Issues related to `ngc`, Angular's template compiler

breaking changes detected: feature

PR contains a feature commit

state: blocked

Projects

None yet

Milestone

v23 candidates

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

JeanMeche commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattrbeck left a comment

Choose a reason for hiding this comment

Uh oh!

mattrbeck Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

mattrbeck Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

mattrbeck Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Flarette commented Nov 8, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JeanMeche commented Sep 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.