GeezerVison is showing github.com — feat(compiler-cli): make NG8031 an error by Flarette · Pull Request #71884 · angular/angular
Conversation
Flarette
commented
Nov 8, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Depends on #71882. Review only the last commit; the earlier ones are #71882.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
- Bugfix
- Feature
- Code style update (formatting, local variables)
- Refactoring (no functional changes, no api changes)
- Build related changes
- CI related changes
- Documentation content changes
- angular.dev application / infrastructure changes
- Other... Please describe:
What is the current behavior?
After #71882, NG8031 is a warning, and NG0319 only logs, even under errorOnUnknownProperties. An
unclaimed event on <ng-container> gets both NG8030 (with strictUnclaimedEventNames) and NG8031.
Issue Number: #71881
What is the new behavior?
This changes severities only; what gets reported stays as in #71882.
- NG8031 is an error by default. While it's on, NG8030 skips
<ng-container>, so each ignored
event gets one error.
- NG0319 throws under
errorOnUnknownProperties, like NG0303.
Does this PR introduce a breaking change?
With strictTemplates, a binding or static attribute that NG8031 reports stops compiling,
including a property binding on <ng-container> under NO_ERRORS_SCHEMA. Each error points at a
binding that never had an effect.
Tests that use errorOnUnknownProperties fail on NG0319.
Migration: remove the binding, move it to an element, or import the directive that claims it. To
report NG8031 as a warning while migrating, set extendedDiagnostics.checks.ignoredBinding to
"warning".
Other information
- All 172
ng_project targets in this repo build with this change.
- Independent of feat(compiler-cli): make NG8032 an error #71883 (NG8032 as an error); either can land first.
- Is this fine for a minor release, or should it wait for a major?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
<ng-container>, <ng-template>, and <ng-content> don't render an
element, so Angular ignores class, style, attribute, and event bindings
on them, and every binding on <ng-content>. These templates compile and
run without a word, although the bindings never take effect.
Add NG8031 (`ignoredBinding`), a type-check diagnostic that
reports these bindings and static attributes. It needs strictTemplates,
is a warning by default, and is configured through
`extendedDiagnostics.checks` like NG8011. It doesn't report:
- bindings that a directive input or output claims;
- directive host bindings, since a directive is reusable;
- static attributes when a directive or a structural directive matched
the element, a content projection slot selects it, or Angular reads
the attribute;
- global event targets such as `document:` and `window:`.
Add NG0319, a dev-mode runtime error that logs class, style, and event
bindings on <ng-container> and <ng-template>, so JIT is covered too.
Add NG8032, a template type-check warning for a component whose
selector matches <ng-container> or <ng-template>. Neither can host a
component: dev mode throws an assertion, and production mode throws a
DOM error when it attaches the component's view to a comment node.
It's a warning for now, because a template that never renders the
element, for example behind an `@if` that is always false, runs today.
The language service no longer suggests DOM attributes on
<ng-container>.
Also report `[attr.x]` on an <ng-container> inside <svg>. The parse
check missed it there, so the binding failed later with a misleading
assertion in dev mode. Templates that hit the new parse error never
worked.
Also fix `<ng-content selector="h1">` in the upgrade examples, which
meant `select`. NG8031 found it, and the repo's build fails on
warnings.
This was referenced Nov 8, 2026
This was referenced Nov 8, 2026
Don't report a property or event binding whose name appears in the
selector of a directive that matched by that selector. Directive
matching uses these binding names, so the binding makes the directive
match even when no input or output claims it, as in
`<ng-template [foobar]>` with a `[foobar]` selector and no input.
Host directives aren't matched by their selector, so their selectors
don't count.
Also add tests for `[class]` and class interpolation on <ng-container>,
an event binding on <ng-template>, a static class that a projection
slot selects, and <ng-template> inside <svg> and inside a namespaced
element.
Move the three selectorless NG8031 tests from the intentional ngp
differences to the known ngp failures, in their own group. They fail
on ngp with NG2024, because ngp doesn't resolve selectorless
dependencies yet.
Report bindings that <ng-container>, <ng-template>, and <ng-content>
ignore as errors, since they never take effect.
- NG8031 (`ignoredBinding`) is now an error by default. While it's on,
NG8030 skips <ng-container>, so each ignored event is reported once.
- NG0319 now throws under `errorOnUnknownProperties`, like NG0303.
BREAKING CHANGE: Bindings that have no effect are now errors
With strictTemplates, a binding that <ng-container>, <ng-template>,
or <ng-content> ignores, or a static attribute on them that nothing
reads, now fails to compile with NG8031. This includes property
bindings on <ng-container> under NO_ERRORS_SCHEMA.
Tests that use `errorOnUnknownProperties` now fail on NG0319.
Each error points at a binding that never had an effect. Remove the
binding, move it to an element, or add the directive that claims it
to the component's imports. To report NG8031 as a warning while you
migrate, set `extendedDiagnostics.checks.ignoredBinding` to
`"warning"`.
|
Question for maintainers: unknown properties on <ng-container> ([foo]) are reported by NG8002 today, and by NG8031 only under NO_ERRORS_SCHEMA. Now that this PR makes NG8031 an error, should NG8031 own all bindings on <ng-container> and <ng-template>, with NG8002 skipping them while NG8031 runs as an error? Without strictTemplates, or with ignoredBinding set to "warning" or "suppress", NG8002 would behave as today.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 8, 2026
|
No need to maintain these 2 PRs, until we have setteled on the parent one.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
crisbeto
Awaiting requested review from crisbeto
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|