GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — CLOUDSTACK-8609. [VMware] VM is not accessible after a migration acro… by likitha · Pull Request #556 · apache/cloudstack

Conversation

likitha commented Jul 2, 2015

Copy link

Copy Markdown

…ss clusters.

Once a VM is successfully started, don't delete the files associated with the unregistered VM, if the files are in a storage that is being used by the new VM.
Attempt to unregister a VM in another DC, only if there is a host associated with a VM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          CLOUDSTACK-8609. [VMware] VM is not accessible after a migration acro…

a97a402

…ss clusters.

Once a VM is successfully started, don't delete the files associated with the unregistered VM, if the files are in a storage that is being used by the new VM.
Attempt to unregister a VM in another DC, only if there is a host associated with a VM.

remibergsma commented Aug 9, 2015

Copy link

Copy Markdown

Contributor

Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

remibergsma added a commit to remibergsma/cloudstack that referenced this pull request

Aug 17, 2015


          Closing PRs older than a month without activity

8ade5dc

This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#508
This closes apache#384
This closes apache#372

remibergsma mentioned this pull request

Aug 17, 2015

Closing PRs older than 1 month and without activity #706

Closed

remibergsma added a commit to remibergsma/cloudstack that referenced this pull request

Aug 17, 2015


          Closing PRs older than a month without activity

aa193a5

This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#384
This closes apache#372

remibergsma added a commit to remibergsma/cloudstack that referenced this pull request

Aug 17, 2015


          Closing PRs older than a month without activity

7d28b3d

This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#384
This closes apache#372

pedro-martins reviewed

Feb 1, 2016

View reviewed changes

Comment thread

plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java

pedro-martins Feb 1, 2016

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, likitha.
Could you extract the code between lines 1770 - 1775 and 1776 - 1780 to methods with a little test case and Javadoc explaining what the methods do, the params that they use and what they return?

Another thing, how about you replace the logic in 'if's at lines 2272, 2283 and 2291 for a method with a little test case and a Javadoc, that receives 2 params, (List skipDatastores, String name ) and returns skipDatastores == null || !skipDatastores.contains(name).

Ty.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

rodrigo93 commented Feb 14, 2016

Copy link

Copy Markdown

Contributor

Could someone put this PR to test again? If it fails, it could be closed since the author seems to be inactive on github since September of the last year and the PR is very old.
If someone shows up some interest in continuing it, then it could be opened again.

PS: This is just a suggestion.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

GabrielBrascher reviewed

Feb 21, 2016

View reviewed changes

Comment thread

vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java

		List<ObjectContent> ocs = _context.getService().retrieveProperties(_context.getPropertyCollector(), pfSpecArr);

		List<DatastoreMO> datastores = new ArrayList<DatastoreMO>();
		if (ocs != null && ocs.size() > 0) {

GabrielBrascher Feb 21, 2016

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @likitha, you could use CollectionUtils.isEmpty for this conditional.
It returns true if the List is empty or null.
Thanks.
Documentation: https://commons.apache.org/proper/commons-collections/apidocs/org/apache/commons/collections4/CollectionUtils.html#isEmpty%28java.util.Collection%29

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

yadvr commented May 2, 2016

Copy link

Copy Markdown

Member

tag:vmware-pickup

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bvbharatk commented Jun 5, 2016

Copy link

Copy Markdown

Contributor

ACS CI BVT Run

Sumarry:
Build Number 137
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sureshanaparti commented May 9, 2017

Copy link

Copy Markdown

Contributor

Continued with the code changes here in a new PR #2091.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sureshanaparti mentioned this pull request

May 9, 2017

CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters #2091

Merged

DaanHoogland commented May 17, 2017

Copy link

Copy Markdown

Contributor

closing as @sureshanaparti tookk this to #2091

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

DaanHoogland closed this

May 17, 2017

yadvr pushed a commit that referenced this pull request

Aug 21, 2018


          CLOUDSTACK-8609: [VMware] VM is not accessible after migration across…

e9003fa

… clusters (#2091)

[VMware] VM is not accessible after migration across clusters.

Once a VM is successfully started, don't delete the files associated with the unregistered VM, if the files are in a storage that is being used by the new VM.
Attempt to unregister a VM in another DC, only if there is a host associated with a VM.

This closes #556

yadvr pushed a commit that referenced this pull request

Jan 20, 2021


          locales: update German translation (#556)

0ee8c19

Add and update translations for German

Signed-off-by: Rohit Yadav <[email protected]>

blueorangutan commented Sep 9, 2025

Copy link

Copy Markdown

@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

blueorangutan commented Sep 9, 2025

Copy link

Copy Markdown

UI build failed: ✖️
(SL-JID-743)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.