GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Cloudstack 8612 by likitha · Pull Request #562 · apache/cloudstack

Conversation

@likitha

@likitha likitha commented Jul 6, 2015

Copy link
Copy Markdown

To ensure that setting a high timeout value for snapshot backup operation will not affect vCenter connections made for any other operations besides volume snapshot, split the existing vCenter session timeout configuration into two configurations,

  1. To tune timeout value for CS's session vCenter during snapshot backup operation - 'vmware.snapshot.backup.session.timeout' (new; default: 20 minutes)
  2. For all other operations - 'vmware.vcenter.session.timeout' (existing; default: 20 minutes)

Additional change -
Users could potentially run into a timeout issue while trying to snapshot large VMs. There is a timeout for async-jobs that ensures that any job that has been in process for too long is cancelled by CS MS. This timeout is configurable using a global configuration ‘job.cancel.threshold.minutes’ and it defaults to 1 hour.
Now for large volumes even though users configure other snapshot timeout values (‘vmware.snapshot.backup.session.timeout’ and ‘backup.snapshot.wait‘) to a very high value, the snapshot operation will still fail because the job will be cancelled in 1 hour.
Hence proposing a configuration that will allow admins to separate out the job cancellation timeout for ‘volume snapshot’ jobs from other vm work jobs - 'volume.snapshot.job.cancel.threshold'.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Likitha Shetty added 2 commits July 6, 2015 11:35
Likitha Shetty
CLOUDSTACK-8612. [VMware] Make vCenter session timeout configurable f…
1093a96 
…or volume snapshot.

Separate out vmware vcenter session timeout config for volume snapshot backup operation.
Likitha Shetty
CLOUDSTACK-8612. [VMware] Make vCenter session timeout configurable f…
c8c9d81 
…or volume snapshot.

Separate out async job timeout for volume snapshot job from other vm work jobs.
@asfbot

asfbot commented Jul 6, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #690 SUCCESS
This pull request looks good
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DaanHoogland
DaanHoogland reviewed Jul 10, 2015
View reviewed changes
Comment thread framework/jobs/src/org/apache/cloudstack/framework/jobs/dao/SyncQueueItemDaoImpl.java

@DaanHoogland DaanHoogland Jul 10, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use try-with-resource

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DaanHoogland

DaanHoogland commented Jul 10, 2015

Copy link
Copy Markdown
Contributor

Can you add unit- and/or integration tests?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@remibergsma

remibergsma commented Aug 9, 2015

Copy link
Copy Markdown
Contributor

Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
@remibergsma
Closing PRs older than a month without activity
8ade5dc 
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#508
This closes apache#384
This closes apache#372
@remibergsma remibergsma mentioned this pull request Aug 17, 2015
Closing PRs older than 1 month and without activity #706
Closed
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
@remibergsma
Closing PRs older than a month without activity
aa193a5 
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#384
This closes apache#372
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
@remibergsma
Closing PRs older than a month without activity
7d28b3d 
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#384
This closes apache#372
@yadvr

yadvr commented May 2, 2016

Copy link
Copy Markdown
Member

tag:vmware-pickup
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bvbharatk

bvbharatk commented Jun 5, 2016

Copy link
Copy Markdown
Contributor

ACS CI BVT Run

Sumarry:
Build Number 136
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kiwiflyer kiwiflyer added component:vmware status:needs-work labels May 10, 2017
@sureshanaparti sureshanaparti mentioned this pull request May 11, 2017
CLOUDSTACK-8612 [VMware] Make vCenter session timeout configurable for volume snapshot #2099
Closed
1 of 5 tasks
@sureshanaparti

sureshanaparti commented May 11, 2017

Copy link
Copy Markdown
Contributor

Continuing with the code changes here in a new PR #2099.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DaanHoogland

DaanHoogland commented May 17, 2017

Copy link
Copy Markdown
Contributor

closing as @sureshanaparti handles this in #2099
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DaanHoogland DaanHoogland closed this May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

component:vmware status:needs-work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@likitha @asfbot @DaanHoogland @remibergsma @yadvr @bvbharatk @sureshanaparti @kiwiflyer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.