GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — CLOUDSTACK-8745 : verify usage after root disk migration by nitt10prashant · Pull Request #713 · apache/cloudstack

Conversation

nitt10prashant commented Aug 18, 2015

Copy link

Copy Markdown

Contributor

put storage in maintenance mode and start ha vm and check usage ... === TestName: test_ha_with_storage_maintenance | Status : SUCCESS ===
ok

Ran 1 test in 842.294s

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

asfbot commented Aug 18, 2015

Copy link

Copy Markdown

cloudstack-pull-rats #342 ABORTED

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asfbot commented Aug 18, 2015

Copy link

Copy Markdown

cloudstack-pull-requests #1037 ABORTED

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asfbot commented Aug 18, 2015

Copy link

Copy Markdown

cloudstack-pull-analysis #274 UNSTABLE
Looks like there's a problem with this pull request

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ksowmya reviewed

Aug 19, 2015

View reviewed changes

Comment thread

test/integration/component/maint/test_ha_pool_maintenance.py Outdated

ksowmya Aug 19, 2015

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are enableMaintenance and cancelMaintenance methods available now directly from StoragePool in base.py. It's better to use that instead of repeating?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nitt10prashant Aug 19, 2015

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those methods can be used only with storage pool class object.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ksowmya Aug 19, 2015

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... I thought something like this should work: StoragePool.enableMaintenance(self.api_client, id=storageself.storageid[0][0]) since it is a classmethod
I am just trying to confirm you're using the latest base.py since couple of these enhancements went in recently into base.py...
If it still doesn't fit in, it's ok. You can continue the way you've done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nitt10prashant commented Aug 19, 2015

Copy link

Copy Markdown

Contributor Author

test result of enough storage is not available to perform test

put storage in maintenance mode and start ha vm and check usage ... SKIP: sufficient storage not available in any cluster for zone 90d85d89-01c4-4a91-b76e-eedf947b40f6

Ran 1 test in 4.059s

OK (SKIP=1)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asfbot commented Aug 19, 2015

Copy link

Copy Markdown

cloudstack-pull-rats #349 ABORTED

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asfbot commented Aug 19, 2015

Copy link

Copy Markdown

cloudstack-pull-analysis #281 ABORTED

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sanju1010 commented Sep 14, 2015

Copy link

Copy Markdown

Contributor

LGTM!!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asfbot commented Sep 14, 2015

Copy link

Copy Markdown

cloudstack-pull-analysis #526 ABORTED

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asfbot commented Sep 14, 2015

Copy link

Copy Markdown

cloudstack-pull-rats #590 ABORTED

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pavanb018 commented Sep 21, 2015

Copy link

Copy Markdown

Contributor

The test Looks good to me.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

yadvr commented Jan 27, 2016

Copy link

Copy Markdown

Member

@nitt10prashant please rebase and meld into a single commit

nitt10prashant reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nitt10prashant commented Mar 2, 2016

Copy link

Copy Markdown

Contributor Author

sure

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          CLOUDSTACK-8745 : verify usage after root disk migration

456abb0

modified to use maintenance method is base.py and added some more checks

CLOUDSTACK-8745: Fail test if list response in empty

nitt10prashant force-pushed the pool_maint branch from 198b4b0 to 456abb0 Compare

April 21, 2016 05:31

nitt10prashant commented Apr 22, 2016

Copy link

Copy Markdown

Contributor Author

@bhaisaab rebased and merged into single commit ,@swill @koushik-das can you please look into this

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

swill commented Apr 22, 2016

Copy link

Copy Markdown

Contributor

I need one more LGTM code review on this one. I will try to test this in my lab today. Thanks...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

swill commented Apr 22, 2016

Copy link

Copy Markdown

Contributor

I think this one is ready unless anyone has any final words...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asfgit merged commit 456abb0 into apache:master

Apr 25, 2016

asfgit pushed a commit that referenced this pull request

Apr 25, 2016


          Merge pull request #713 from nitt10prashant/pool_maint

a2d4692

CLOUDSTACK-8745 : verify usage after root disk migrationput storage in maintenance mode and start ha vm and check usage ... === TestName: test_ha_with_storage_maintenance | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 842.294s

OK

* pr/713:
  CLOUDSTACK-8745 : verify usage after root disk migration

Signed-off-by: Will Stevens <[email protected]>

yadvr pushed a commit that referenced this pull request

Jan 20, 2021


          config: extend basic customize theming options (#718)

8ad082d

Customize link hover color
Customize loading color
Customize navigation menu color

Fixes #712
Fixes #713
Fixes #714

Signed-off-by: Rohit Yadav <[email protected]>

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.