GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names by yadvr · Pull Request #718 · apache/cloudstack

Conversation

yadvr commented Aug 19, 2015

Copy link

Copy Markdown

Member

This tries to avoid cleaning by a device name.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names

ee5638e

This tries to avoid cleaning by a device name.

Signed-off-by: Rohit Yadav <[email protected]>

asfbot commented Aug 19, 2015

Copy link

Copy Markdown

cloudstack-pull-rats #352 ABORTED

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

remibergsma commented Aug 19, 2015

Copy link

Copy Markdown

Contributor

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asfbot commented Aug 19, 2015

Copy link

Copy Markdown

cloudstack-pull-analysis #284 ABORTED

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

milamberspace commented Aug 19, 2015

Copy link

Copy Markdown

Contributor

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

remibergsma commented Aug 19, 2015

Copy link

Copy Markdown

Contributor

@bhaisaab Let's make sure this ends up in master as well!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asfgit pushed a commit that referenced this pull request

Aug 19, 2015


          CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names

74f697a

This tries to avoid cleaning by a device name.

Signed-off-by: Rohit Yadav <[email protected]>

This closes #718

yadvr commented Aug 19, 2015

Copy link

Copy Markdown

Member Author

@remibergsma thanks, done.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

yadvr closed this

Aug 19, 2015

asfgit pushed a commit that referenced this pull request

Aug 19, 2015


          CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names

3fd35dd

This tries to avoid cleaning by a device name.

This closes #718

(cherry picked from commit 74f697a)
Signed-off-by: Rohit Yadav <[email protected]>

jburwell reviewed

Aug 19, 2015

View reviewed changes

Comment thread

plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java

jburwell Aug 19, 2015

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned about the unchecked array access in the event of malformed/unexpected input. Consider the following as a bit of extra safety in the event of malformed input beginning at line 289:

if (tokens != null && tokens.length < 2) {
   // Should we emit a log warning here to indicate that we received an unexpected string format?
   continue;
}

final String device = tokens[2];
if (!Strings.isNullOrEmpty(device) &&
    !device.equalsIgnoreCase(linkLocalBr)) {

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

yadvr Aug 19, 2015

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR we cannot make any changes now that it is merged already; perhaps send a new PR or I can pick it up later.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

yadvr added a commit to shapeblue/cloudstack that referenced this pull request

Aug 24, 2015


          CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

86d29c4

Based on @jburwell's comment on PR apache#718

Signed-off-by: Rohit Yadav <[email protected]>

yadvr mentioned this pull request

Aug 24, 2015

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input #733

Merged

yadvr added a commit to shapeblue/cloudstack that referenced this pull request

Aug 24, 2015


          CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

972117e

Based on @jburwell's comment on PR apache#718

Signed-off-by: Rohit Yadav <[email protected]>

yadvr mentioned this pull request

Aug 24, 2015

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input #735

Merged

yadvr added a commit to shapeblue/cloudstack that referenced this pull request

Aug 26, 2015


          CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

7e455fa

Based on @jburwell's comment on PR apache#718

This closes apache#735

Signed-off-by: Rohit Yadav <[email protected]>

yadvr added a commit to shapeblue/cloudstack that referenced this pull request

Aug 26, 2015


          CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

2a382e0

Based on @jburwell's comment on PR apache#718

This closes apache#733

Signed-off-by: Rohit Yadav <[email protected]>

asfgit pushed a commit that referenced this pull request

Aug 26, 2015


          Merge pull request #735 from shapeblue/kvm-linkbr-checks-master

5d232ea

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected inputBased on @jburwell's comment on PR #718

* pr/735:
  CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

Signed-off-by: Rohit Yadav <[email protected]>

asfgit pushed a commit that referenced this pull request

Aug 26, 2015


          Merge pull request #733 from shapeblue/kvm-linkbr-checks

acf1baf

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected inputBased on @jburwell's comment on PR #718

* pr/733:
  CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

Signed-off-by: Rohit Yadav <[email protected]>

yadvr pushed a commit that referenced this pull request

Jan 20, 2021


          config: extend basic customize theming options (#718)

8ad082d

Customize link hover color
Customize loading color
Customize navigation menu color

Fixes #712
Fixes #713
Fixes #714

Signed-off-by: Rohit Yadav <[email protected]>

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.