GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input by yadvr · Pull Request #735 · apache/cloudstack

Conversation

@yadvr

@yadvr yadvr commented Aug 24, 2015

Copy link
Copy Markdown
Member

Based on @jburwell's comment on PR #718

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@yadvr yadvr mentioned this pull request Aug 24, 2015
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input #733
Merged
@asfbot

asfbot commented Aug 24, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #379 SUCCESS
This pull request looks good

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@asfbot

asfbot commented Aug 24, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #312 SUCCESS
This pull request looks good

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@remibergsma

remibergsma commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@remibergsma

remibergsma commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

@jburwell can you review this please? Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jburwell
jburwell reviewed Aug 25, 2015
View reviewed changes
Comment thread plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java

@jburwell jburwell Aug 25, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading through this block, it feels like lines 289-293 should be extracted to a private method:

static parseDevice(final String line) {
     final String[] tokens = line.split( " ");
     if (tokens != null && tokens.length < 2) {
        return "";
     }

     final String device = tokens[2];
     return Strings.isNullOrEmpty(device) : " " ? device;
} 

The extraction of this method would not only shorten the deleteExitingLinkLocalLocalRoutetTable method, but clearly express the intent. It also allows a unit test to be written to verify that parsing works as expected for different types of input.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@yadvr yadvr Aug 26, 2015

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With respect to this specific code, I would like do this the next time we do a round of refactoring, possibly factor such code to a util class that can be used as a general purpose line parsing static method and add unit tests. For now, at least the code takes care of malformed inputs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jburwell

jburwell commented Aug 25, 2015

Copy link
Copy Markdown
Contributor

While it is a small nit and not expressly within the scope of this PR, could you fix the spelling mistake in the deleteExitingLinkLocalRouteTable name?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@yadvr
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input
7e455fa
Based on @jburwell's comment on PR apache#718

This closes apache#735

Signed-off-by: Rohit Yadav <[email protected]>
@yadvr
yadvr force-pushed the kvm-linkbr-checks-master branch from 972117e to 7e455fa Compare August 26, 2015 08:04
@yadvr

yadvr commented Aug 26, 2015

Copy link
Copy Markdown
Member Author

renamed the method, s/deleteExitingLinkLocalRouteTable/deleteExistingLinkLocalRouteTable/g

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@asfbot

asfbot commented Aug 26, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #403 SUCCESS
This pull request looks good

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@asfgit
asfgit merged commit 7e455fa into apache:master Aug 26, 2015
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@yadvr
Merge pull request #735 from shapeblue/kvm-linkbr-checks-master
5d232ea
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected inputBased on @jburwell's comment on PR #718

* pr/735:
  CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

Signed-off-by: Rohit Yadav <[email protected]>
@asfbot

asfbot commented Aug 26, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #336 UNSTABLE
Looks like there's a problem with this pull request

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

yadvr pushed a commit that referenced this pull request Jan 20, 2021
Hoang Nguyen @yadvr
project: The message empty or undefined when switch project (#735)
173b8e3
* fix message empty or undefined when switch project

* transalte message text

Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@yadvr @asfbot @remibergsma @jburwell @asfgit
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.