GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: add project skill queries and authorization by jaaydenh · Pull Request #30826 · coder/coder

Conversation

jaaydenh commented Oct 15, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Adds the storage and authorization layer for chat project skills. The skills table already allows a project_id owner (migration 000621); this adds the queries for it and authorizes them through the parent chat project, the same way project instructions work.

New queries in skills.sql: insert, get by name, list metadata, update (COALESCE on description, content and enabled), delete, and GetProjectSkillByIDForUpdate for the shared update lock.
dbauthz checks chat_project:read on the project for reads and chat_project:update for writes. authorizeChatProjectInstructions became authorizeChatProjectConfig, shared by instructions and skills. Skill.RBACObject() still denies project rows so nothing reaches them without going through the project.
Audit: new chat_project_skill resource type (enum-only migration 000624), AuditableChatProjectSkill, and the usual diff/request/table/FriendlyString/AuditFilter wiring. The API that emits these entries comes in the next PR.

Stack (merge top to bottom):

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji

All reactions

👍 1 reaction

jaaydenh added 3 commits

October 15, 2026 07:09


          feat: add project skill queries and authorization

2ac1248

Add sqlc queries for skills owned by a chat project and authorize them
through the parent project in dbauthz: reading needs chat_project:read
and writing needs chat_project:update. Skill.RBACObject keeps denying
project rows so any unwrapped path fails closed.

Add the chat_project_skill audit resource type and
AuditableChatProjectSkill so the upcoming project skill API can record
audit entries.


          refactor(coderd/database): share chat project config authorization he…

836c956

…lper


          test(coderd/database): assert project skill reads stay scoped to thei…

7bc17ba

…r project

jaaydenh commented Oct 15, 2026

Copy link

Copy Markdown

Contributor Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

docs/admin/security/audit-logs.md

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot assigned jaaydenh

Oct 15, 2026

chatgpt-codex-connector Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-15T07:48:42.494623Z	`7bc17ba`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot commented Oct 15, 2026

Copy link

Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 7bc17baca4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Oct 15, 2026

feat: add project skill API routes #30827

Merged

feat: load project skills in chats #30838

Merged

fix(site/src/pages/AgentsPage): use the root chat's project for subagent chat skills #30840

Closed

ibetitsmike added this pull request to stack #30842

October 15, 2026 12:14

This was referenced Oct 15, 2026

refactor(site/src/pages/AgentsPage): extract SkillEditorForm and shared skill helpers #30854

Merged

feat(site): add the project skills dialog #30855

Merged

feat: manage project skills from the project page #30856

Merged

feat: send skill invocations as structured message parts #30861

Merged

feat(site/src): insert skills as chips in the composer #30880

Merged

feat: render skill invocations in the transcript and edit flow #30881

Merged

feat: add skill action and automatic-use settings #30882

Merged

feat: show project skill actions above project chat composers #30884

Merged

jaaydenh marked this pull request as ready for review

October 16, 2026 09:30

jaaydenh requested a review from nickvigilante as a code owner

October 16, 2026 09:30

jaaydenh added 2 commits

October 16, 2026 09:46


          Merge remote-tracking branch 'origin/main' into HEAD

e6af784


          fix(coderd/database/migrations): renumber chat project skill audit mi…

ebb0776

…gration after main

pr-queue-manager Bot requested a review from ibetitsmike

October 16, 2026 12:13

nickvigilante reviewed

Oct 16, 2026

View reviewed changes

nickvigilante left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ibetitsmike approved these changes

Oct 16, 2026

View reviewed changes

Comment thread

coderd/database/modelmethods.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

jaaydenh added 3 commits

October 18, 2026 05:28


          chore(coderd): remove non-essential project skill comments

f010477


          Merge remote-tracking branch 'origin/main' into rs-queries

cbb4bf7


          fix(coderd/database/migrations): renumber chat project skill audit mi…

…gration after main

jaaydenh merged commit a379c84 into main

Oct 18, 2026

32 checks passed

Uh oh!

There was an error while loading. Please reload this page.

jaaydenh deleted the chat-project-skills/queries branch

October 18, 2026 05:58

github-actions Bot locked and limited conversation to collaborators

Oct 18, 2026

Reviewers

nickvigilante

nickvigilante left review comments

ibetitsmike

ibetitsmike approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

jaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

jaaydenh commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaaydenh commented Oct 15, 2026

Uh oh!

github-actions Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docs preview

Uh oh!

chatgpt-codex-connector Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Oct 15, 2026

Uh oh!

nickvigilante left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jaaydenh commented Oct 15, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.