GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix(site/src/pages/AgentsPage): use the root chat's project for subagent chat skills by jaaydenh · Pull Request #30840 · coder/coder

Conversation

jaaydenh commented Oct 15, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Subagent chats have no project_id of their own; chatd gives them the project of their root chat. The site only looked at chat.project_id, so a subagent chat of a project chat showed no project skills in its / menu, and /clear or /compact ran the built-in command even when the project has a skill with that name.

A new useChatProjectId hook returns the chat's project, falling back to the root chat's project for subagent chats. The chat page and its composer both use it. While the root chat loads, project skills stay unresolved so /clear and /compact wait instead of running; if the root chat fails to load, the chat is treated as having no project.

Split out of #30838 to keep that PR under 1000 lines. Once #30683 gives subagent chats their root chat's project_id, the fallback can go away.

Stack (merge top to bottom):

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji

All reactions

👍 1 reaction


          fix(site/src/pages/AgentsPage): use the root chat's project for subag…

26deda5

…ent chat skills

github-actions Bot assigned jaaydenh

Oct 15, 2026

This was referenced Oct 15, 2026

feat: add project skill queries and authorization #30826

Merged

feat: add project skill API routes #30827

Merged

feat: load project skills in chats #30838

Merged

jaaydenh commented Oct 15, 2026

Copy link

Copy Markdown

Contributor Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-15T13:44:20.851316Z	`7b6c3e3`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot reviewed

Oct 15, 2026

View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26deda51c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

site/src/pages/AgentsPage/components/ChatPageContent.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

site/src/pages/AgentsPage/hooks/useChatProjectId.test.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

site/src/pages/AgentsPage/hooks/useChatProjectId.test.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.

ibetitsmike added this pull request to stack #30842

October 15, 2026 12:14


          fix(site/src/pages/AgentsPage): keep inherited project skills pending…

549a030

… in the composer

jaaydenh commented Oct 15, 2026

Copy link

Copy Markdown

Contributor Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot reviewed

Oct 15, 2026

View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 549a030c0a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

site/src/pages/AgentsPage/components/ChatPageContent.test.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

site/src/pages/AgentsPage/components/AgentChatInput.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.


          test(site/src/pages/AgentsPage/components): restore Range geometry st…

7b6c3e3

…ub after each test

jaaydenh commented Oct 15, 2026

Copy link

Copy Markdown

Contributor Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot commented Oct 15, 2026

Copy link

Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 7b6c3e359f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Oct 15, 2026

refactor(site/src/pages/AgentsPage): extract SkillEditorForm and shared skill helpers #30854

Merged

feat(site): add the project skills dialog #30855

Merged

feat: manage project skills from the project page #30856

Merged

feat: send skill invocations as structured message parts #30861

Merged

feat(site/src): insert skills as chips in the composer #30880

Merged

feat: render skill invocations in the transcript and edit flow #30881

Merged

feat: add skill action and automatic-use settings #30882

Merged

feat: show project skill actions above project chat composers #30884

Merged

jaaydenh marked this pull request as ready for review

October 16, 2026 09:39

jaaydenh requested a review from a team as a code owner

October 16, 2026 09:39


          Merge branch 'chat-project-skills/chatd' into chat-project-skills/sub…

958d217

…agent-project

jaaydenh added a commit that referenced this pull request

Oct 18, 2026


          feat: add project skill queries and authorization (#30826)

a379c84

Adds the storage and authorization layer for chat project skills. The
`skills` table already allows a `project_id` owner (migration 000621);
this adds the queries for it and authorizes them through the parent chat
project, the same way project instructions work.

- New queries in `skills.sql`: insert, get by name, list metadata,
update (COALESCE on description, content and enabled), delete, and
`GetProjectSkillByIDForUpdate` for the shared update lock.
- dbauthz checks `chat_project:read` on the project for reads and
`chat_project:update` for writes. `authorizeChatProjectInstructions`
became `authorizeChatProjectConfig`, shared by instructions and skills.
`Skill.RBACObject()` still denies project rows so nothing reaches them
without going through the project.
- Audit: new `chat_project_skill` resource type (enum-only migration
000624), `AuditableChatProjectSkill`, and the usual
diff/request/table/FriendlyString/AuditFilter wiring. The API that emits
these entries comes in the next PR.

Stack (merge top to bottom):
- #30826 👈
- #30827
- #30838
- #30840
- #30854
- #30855
- #30856
- #30861
- #30880
- #30881
- #30882
- #30884

jaaydenh added a commit that referenced this pull request

Oct 18, 2026


          feat: add project skill API routes (#30827)

e289c6f

Adds experimental routes for managing a chat project's skills under
`/api/experimental/organizations/{organization}/chats/projects/{project}/skills`:
list, create, get, update (PATCH) and delete by skill name.

The handlers reuse the shared skill create and update path from the
personal and organization skill APIs. Reading needs `chat_project:read`
on the project and writing needs `chat_project:update`; callers without
access get 404, matching the project instructions routes. Duplicate
names and the 100-skill-per-project cap return 409. Writes are audited
as `chat_project_skill` with the skill name as the target. The SDK gains
the matching `ExperimentalClient` methods.

Stack (merge top to bottom):
- #30826
- #30827 👈
- #30838
- #30840
- #30854
- #30855
- #30856
- #30861
- #30880
- #30881
- #30882
- #30884


          Merge branch 'chat-project-skills/chatd' into chat-project-skills/sub…

c39c1e0

…agent-project

jaaydenh requested a review from ethanndickson

October 19, 2026 05:44

ethanndickson reviewed

Oct 20, 2026

View reviewed changes

ethanndickson left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need this? This is temporary, and real users would basically never be opening subchats and using skills there?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jaaydenh commented Oct 20, 2026

Copy link

Copy Markdown

Contributor Author

Closing in favor of #30683

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaaydenh closed this

Oct 20, 2026

github-actions Bot locked and limited conversation to collaborators

Oct 20, 2026

jaaydenh removed this pull request from stack #30842

October 20, 2026 10:53

Reviewers

ethanndickson

ethanndickson left review comments

chatgpt-codex-connector[bot]

chatgpt-codex-connector[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

jaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

jaaydenh commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaaydenh commented Oct 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaaydenh commented Oct 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

jaaydenh commented Oct 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 15, 2026

Uh oh!

ethanndickson left a comment

Choose a reason for hiding this comment

Uh oh!

jaaydenh commented Oct 20, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jaaydenh commented Oct 15, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.