Description

kushalkolar

opened on Jan 19, 2023

Issue body actions

Currently if a user wants to close a plot they need to access the canvas, plot.canvas.close(), to reduce boilerplate we can implement plot.close().

@EricThomson, @clewis7 thoughts?

Activity

1. kushalkolar commented on Jan 19, 2023

   

   kushalkolar

   on Jan 19, 2023

   MemberAuthor

   More actions

   @EricThomson also let me know of any other boilerplate you notice that you think can be removed.
2. clewis7 commented on Jan 19, 2023

   

   clewis7

   on Jan 19, 2023

   Member

   More actions

   I think plot.close()
3. EricThomson commented on Jan 19, 2023

   

   EricThomson

   on Jan 19, 2023

   Contributor

   More actions

   Sounds like a good idea. What about with widgets, too, so widget.close()? Seems like this could be made a natural/expected part of the api. Basically, if you can show it, you can close it.
4. kushalkolar commented on Jan 20, 2023

   

   kushalkolar

   on Jan 20, 2023

   MemberAuthor

   More actions

   Yes like for ImageWidget, it can close all the sliders, VBox, and plot.

   @EricThomson is this your first contrib? :D
5. kushalkolar

   added a commit that references this issue on May 21, 2023

   finishes #107, #119, #192

   73ab462
6. kushalkolar

   closed this as completedin #200on May 21, 2023
7. kushalkolar

   added a commit that references this issue on May 21, 2023

   finishes #107, #119, #192 (#200)

   edc1701
8. EricThomson commented on May 21, 2023

   

   EricThomson

   on May 21, 2023

   Contributor

   More actions

   This is great, I obsessively like to close things. :)
9. kushalkolar

   added a commit that references this issue on Jun 14, 2023

   restarted tests, now work from the command line (#179)

   a08e84c

Issue actions